From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751772AbcFNVou (ORCPT ); Tue, 14 Jun 2016 17:44:50 -0400 Received: from mail-by2on0091.outbound.protection.outlook.com ([207.46.100.91]:20928 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750771AbcFNVor (ORCPT ); Tue, 14 Jun 2016 17:44:47 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Suravee.Suthikulpanit@amd.com; Subject: Re: [PATCH] KVM: SVM: compile out AVIC if !CONFIG_X86_LOCAL_APIC To: Paolo Bonzini References: <1465922420-53802-1-git-send-email-pbonzini@redhat.com> <573935ff-2310-b64f-d3c9-260a89de6752@amd.com> <29661011.22418691.1465939344668.JavaMail.zimbra@redhat.com> CC: , , From: Suravee Suthikulanit Message-ID: Date: Tue, 14 Jun 2016 16:44:39 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <29661011.22418691.1465939344668.JavaMail.zimbra@redhat.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: SN1PR17CA0037.namprd17.prod.outlook.com (10.169.33.175) To BY1PR12MB0438.namprd12.prod.outlook.com (10.162.147.14) X-MS-Office365-Filtering-Correlation-Id: d7e42e6c-559f-4ae2-806a-08d3949d19ac X-Microsoft-Exchange-Diagnostics: 1;BY1PR12MB0438;2:T2RuoshKS8ZN97vl05ojB00RZdBztb0qKPEaCpc5REVEEtYnVvP5OuG81jfqLPtZ9wmo7WJ7IkTkSVPSGHb7TEDLdgibQZmcdfZK6D5wbXj+VZpxNKdQZLTQ8jitkXgbUkOcPG2cNTQa6Yb2mNdGfdz4QDn3GH7l42pRwAhiCF6Nd0exl0hRNBntmch99AOv;3:CvfE1XJEn1aKI9CiNdxyKtnRqMEjbYU2Td+z6+6/NS9KiRmJFh3HbE0jnfTL7pFhbT4LolBpMuZGHF9HPBlp0DB9y+hr7RDy8GWWujTPWibtvUKzz1kfhhz9gucC68JZ X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR12MB0438; X-Microsoft-Exchange-Diagnostics: 1;BY1PR12MB0438;25:EfQ3v0zwDtRFncg6BMExflXpuz9WyGIQ+7NCcV588cdEW3kcl5fkUlQ8pEGL4SIfejh5cPIJvxxsX2BHWTgFkswmIwrq6AojmnLET9qBlTY48YCedRQTI29SrTGwqTmV0CMs7oLXKcNlPXLJeqTDQQmWS8F4My5Yw5rlpaYlEANFiqed4cbv4nj8Qar6GFpe3VVCLLPXstO2XUqXE42P15Pi9iIsM27K8KtpamyqCyWA7nijE/UVzEm/gFdUs6B85z4rqXDaM+n1rSUcM1bNgRVf27/1ZOO5xyi5yPu3uYErkv1me9qsa+nBB1ovcaRUJe00mlPxNnNe4dtxTMzlxXrlSugzbs519qDuc97gn2h8m0VU4pxzq7o4UAJU0A55Be8VrptUFMvqZKkIVjI66iKFBpsWFMJjnUaGEcLTwo3Mu4xgaxeHAhds10QpNZGZiPIt+75vcVlsW7HYNJhNlOy2p4sXTMp0YfvoA2zAUsWUnq971u5PwjD5GhGuA3RsJ3TxJq27yz8u22ISfCIqEfYmUTuXOGhJDty4C6K4sHQheIC2JGck0IcWbDa6xxrYP6A4kf6shrYLufouQ4ciHV2tnrq62QOt7+Udyd9UZZcoFTjdUsyzccIO7Ziqv0G3q8GY9lfjKgKDfyVJH4hAm7bvZOM2ocLSfrnKLMkkInPdyNM5gzZExDYZ2k2CM4aDwR08sekELUdrABoe4rxWr+L5U0hTSv3Eb43hJr3S6QX+F9BzCruoVNRLoXi57WemhaeDCmab+MQWDuQR3p1WISQqiwA0jFEefK77jS/aXxjSQogsalIOCJ0MVQkb43U2 X-Microsoft-Exchange-Diagnostics: 1;BY1PR12MB0438;20:9DPv6fasEOxxRfaD3D5Mr4sLLlBT8cDXTgVCHvrkqoV7SSGHwhW/oRcNvznbGo6Knw4VJm7MaXlIKnlnzfo2PZEgi4Y60NV6dA2rctAd0QYL8Bgu/7J/ANi4RJPdzPlW4eurD7MsKtHgIxPvHqmq6Eya0KF7IkrIE9beSXUsslzxa8viiv1GY2NNMyOD5/0Wl3JBKnJ1YRH6qafIVxSPHQQj+hanVXaliAIQcxml0LLdClwEir1Yl+9ouGxjpBISrg3/qCTYmuMPHSjZHGLuRfcMoScVOqKcdZ8F6wUBIco1mI+X0ugFjhI1iuZ/QXqmVotroJS2r5H+ed/dodKgfVY8Hc00Q2TZD4InKNJhB2qY6ZgCbWaHdsGTp+KSpWwiSlrZl23qd2vudy3+xt/1UoRHy2pTha1YSU7ZerS7DHRN9rBMDf/REOubwlYenXzowrxJ46N1qbB1AsbcaOBl943uAFUMqkL1/KfWWfjfl7SYDqwV+9VRvATHBO5rTyjv X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(9452136761055)(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026);SRVR:BY1PR12MB0438;BCL:0;PCL:0;RULEID:;SRVR:BY1PR12MB0438; X-Microsoft-Exchange-Diagnostics: 1;BY1PR12MB0438;4:yHbA6DyMJ66lrQCl0KyDZK8E+K1TJYFCQBOlEgxvwzB/77QOeAwSQz7ee9bGh3icKZ2cJCNK8QdbrQ+T3EY0X9tJzR4zOQH1TXzgxIr0uuXk9PMyDL8PulJk4ydAaC+6xYhPn4i2hdnpw03hO7YT64YRgZ+JvzR3vgzAZ8T6/237trD4Yd4o70V9jSJ17FU3CHS2MVTLEPyzAPS/L1Wwcx5v9h/7Dzn2yGv+YnANHLV3opG0+vFDMZa40XX2tTExiDJzCzh1QSwryIL2ic2+QsBMqXuWaiqZnXJo6CGCSc43ylOV3qB//2+VMLi144XWB+paLbw9K+8ui6Q2S1jNHifDovb6gMDivw9An2cLQRl983bXQeHz1IlQ30LT7owmk1dAJtx0silS1LMOVANAMssEmD0xqh2KIghAmhk1nXy8zJc0QxPGa2h9xGjc8xkw77D+IKnUHwcwxbo6AliVZQ== X-Forefront-PRVS: 09730BD177 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6049001)(6009001)(7916002)(50084003)(24454002)(13464003)(377454003)(199003)(189002)(97736004)(66066001)(47776003)(2950100001)(50466002)(110136002)(65956001)(65806001)(105586002)(106356001)(4001350100001)(77096005)(15975445007)(5004730100002)(33646002)(23676002)(101416001)(586003)(31696002)(68736007)(50986999)(86362001)(6116002)(3846002)(189998001)(76176999)(54356999)(92566002)(5008740100001)(4326007)(81156014)(81166006)(8676002)(36756003)(230700001)(31686004)(64126003)(42186005)(83506001)(19580395003)(19580405001)(2906002)(65826006)(15760500001);DIR:OUT;SFP:1101;SCL:1;SRVR:BY1PR12MB0438;H:[10.236.18.83];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;CAT:NONE;LANG:en;CAT:NONE; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWTFQUjEyTUIwNDM4OzIzOm1Ub2RPSGFnSGcrTVdZVlRLWW5IZ0Y5bnJt?= =?utf-8?B?Nld0UUhtRS9HSllIWm8zUmZ1VHJuMFV2QVE4YlYxRUZzTkZOTmdHejU4TVZv?= =?utf-8?B?Sys2VnZpZlpIOWRqdVMxTit4RE9QeWh6bXljQ2NIYXRhdlpic1R6MzltaUk1?= =?utf-8?B?U1NRYlA4b1pHa3Zwd0ptSnR1bnBLUElXeC9BdXQ0cHNLZXVBUDVYT290Mjd3?= =?utf-8?B?U09sSWw4MWQwN3lPaThpSUg2UTJFUE9vcWVSUUNnVWF3UEhwQjlpNjIxdUpu?= =?utf-8?B?SmR4KzdlMG5JWnhROVRaNVcxaEl4ZTlManNUcWhSRldrTWllRGpyUHg0dmhL?= =?utf-8?B?bEErbEtSbDlKRVJhQlhsbnlZR1Vla3dIOFhWYXdoRWNBZGtGeUZnTGZybVUx?= =?utf-8?B?TlJZRXhoemtnRTA3MnhKMzduWG51SStndUd4QzF0UjZYTWMwVU5UcGV1azht?= =?utf-8?B?eWk2emM3ejFNQUJCdVE2a05kRUYvUGNncVVxeDZyU3F4VVhhT2pFd28rZ0xF?= =?utf-8?B?SXhIbzVjZ0UvY3QyNXZmZm9uNDdPc1lVYWpFUnpJUUZ2dTBkU2VNTDBQRlA3?= =?utf-8?B?UW9qN2dKS3lKOVAzaHUzRFNXTXp1RzZrRUFoWitaam93U0xMVmFkcXBmdnVm?= =?utf-8?B?TS91U2lVNVFuNURlWngxSnBiRDVsa1BCZmNpU2ZqQkZMaW1INTg1RnJFRWN1?= =?utf-8?B?S0ZsSHpRdVNNSGJObWJwNnFONkJFTmVLeHZOQXdLTlpQU0pJVjNnNlFFVjlk?= =?utf-8?B?Mlh4OTBPTDhQdTN3UzllTDdtVGNIZ0oydW9CSGZLKythQktkY0x4T0dQSFl3?= =?utf-8?B?Yzl5MFRKL3owcVJaYjgrNm5IT3RVUXdLYzBsSkQySHRXOGhFWWNlamFvNG5s?= =?utf-8?B?Qi9rRUwzUFB6Lzkxcjh4bVkrMDBrczk1NWROSkxGcVVxUVluMEhKbXRCUDM0?= =?utf-8?B?NkVoMUJ4cDZFWllpWVFyUUpqRi9Ld09KY3NwcE5iTEtXRU05UGlLV29Qb3Fu?= =?utf-8?B?eW9xZlFZN1Q4bkRLaGRsMG9yNkFRQ25hZTdiNmhSdUJZUHlYOFFFTUJYNE5p?= =?utf-8?B?ZllnbVJ2QnIvTW1DSkRycnFDUjhxMkVteVFJNTRZKzZlU2JwaWdsTGhIeW1h?= =?utf-8?B?dkptczZxUmZScm9oTDFHWDVyS1UrajdRRThVb0o4bVFyZUJ5cm1YNTNxMy82?= =?utf-8?B?TDdqWUUzVy9YWXVnZ0c0L0J2RDBOQ014U04zMkZFQ2JjZ3RQd1YvVjRaTlRU?= =?utf-8?B?L3dVTGpXTXV0TDVSYnpSYndhUFRYY3dkT1pRcHRxSkdtdFU3aWlMMGxRZHZG?= =?utf-8?B?enFHVXczVlhIbG0wVWVPWndSN1AzU0ltWFdibE4wTkNKdDhSNGkySXNNNmFR?= =?utf-8?B?QTE0UCszWWQ2QUNKOEt4anhNZDZINlIxd2hxN0hhZHlwcGtQMGdXMmw3ZGJx?= =?utf-8?B?OXpzWkFINktlUkxhb2kyc3p6VHBYYWV3bkpuWmNWV0JaYk1ZbERXeVI5dWhh?= =?utf-8?B?UUJoMGpFQWlPOXozZDM0amNVUDBPNnQ1OEt3VWJEaFp1WkdmR0pkTFM2dUcz?= =?utf-8?B?SXNkUWwyY2hMQk9TcGZyTXJRajBURFpnWFVoRlpJdm53NitlYUpqMXdSVE14?= =?utf-8?B?VEY2aEJ0Tyt3Q1dqQ1F3a2dzcmFXeTVOVkJvVjdlcTgzeU1iK0ZPcDFuanRq?= =?utf-8?B?UHZuRjJ4cXNYbEsybThTeHp5NHduaHJrTlVvMkl3cXJIN0VVRXlibU5yYU56?= =?utf-8?B?YTVmMFYwTmVMWWF6Mll1K2FVSEVtSUtneUVYQWdWc2pFenliY1k2dUpORUg4?= =?utf-8?B?SEdKMEhPNlhYT0hNYzlQUFNUcXQyOXM5OWFTRzk4OXdpYVE9PQ==?= X-Microsoft-Exchange-Diagnostics: 1;BY1PR12MB0438;6:8bsmxr1FM8V5emjkeJenTPKqPsMt8EX9mx5XSGtgKGgfheTCbjsniiqCKwZj3ISkTVCRj5dpp9I8lJH1L3TnylC1RmfbOSbG5uxsNLgj4P6DAAAyOcbvFEUNQbJsr2o/KtNpPRW9wgjYKP89zgexkeZdluXmdBZFWJdRqWgY+FAIErmrlwr5ZWj8kERBHgagB7Rc43Ya0WbVxtB8nvWBS3XD+ycrQtBotxVmczE8prBz5rm3qTd9uSA+gMvlisJoTCvTHksdkxfjhA2nzM/5U8rzE8nFdhI0JODS6Ns08FceAoyEWseQmP+oQKRwHWCN;5:Gw/E9qvFh3I42HQsQozb7G33swLZ5Il5b32z54E0xbOPNEgXuYx1gvYZz8xBuiPMP8uqEK6YiRPERZ0MNs+EnKki+HvUGysg3aq414VK3Ts9NiWXkaknDqrC3+WzeQ86gERDJarwvUwVCpAoBRyWaA==;24:rDCoF8JGluPiwL+B7IszdzdArWuqxFU43CKZ/ZikVpyOM8vWeJf24bWhXkmzIy149Neu296yZP35OnJJJg/j4ezLdAM5Nc9oAmYrb31f6Bc=;7:OPvZhoM3Izg1Axo8pxkAcZDn7IFrqA3qzcU1ifiz4OfdaLH5nH2QPejZNPS1IRdyu5w4amQD8jyZyd7I9BtakE3EeotnudZlhe3rATWvYIuSmk5XQckEJ3YMs3Ii5Hl0HusJ22Qwkxt+Qgs+o0PZmUq1afHf9HXdkjbGZo3f8ir6Hht8Ryz2wN6MYb+CZCEPG7HzkCERHqj/vPWjq7mgCw== SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BY1PR12MB0438;20:CB81eoWxD9xiSG1ltYvxH0BcOiDPG1zdnck6m4vVGlmPhz2jIfEppRvmcQRms+0GR66T5AtBmjksjRgqTJJHT4UOFhaqA//ZiwPZatc28oGp6w6ZFF+kCHwBLzOJza+gqRLsXpYfo49c2eucsuDsRSmj08JJ0x4S4T5Wml0+01ifMVynMR/qGa6jFFp7a1wwHlOHCEYKROCpedLjxNdwpxGBoA7wKYTbAmcQPp8vd8pBhOh8rQ/A2cgR6y61O+pH X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2016 21:44:44.7380 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR12MB0438 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/14/2016 4:22 PM, Paolo Bonzini wrote: > ----- Original Message ----- >> From: "Suravee Suthikulanit" >> To: "Paolo Bonzini" , linux-kernel@vger.kernel.org, kvm@vger.kernel.org >> Cc: rkrcmar@redhat.com >> Sent: Tuesday, June 14, 2016 8:20:30 PM >> Subject: Re: [PATCH] KVM: SVM: compile out AVIC if !CONFIG_X86_LOCAL_APIC >> >> Hi Paolo, >> >> On 6/14/2016 11:40 AM, Paolo Bonzini wrote: >>> AVIC needs __default_cpu_present_to_apicid. Stub out all functions >>> that use it, and disable the module parameter, if Linux is >>> compiled without local APIC support. >> >> I think you are right that we should disable AVIC #ifndef >> CONFIG_X86_LOCAL_APIC. However, do you think we should just use >> default_cpu_present_to_apicid() instead of the >> __default_cpu_present_to_apicid()? > > I'm not sure why that would help? default_cpu_present_to_apicid > is also declared only if CONFIG_X86_LOCAL_APIC is defined. Actually, I also meant to include the change that I sent out (https://lkml.org/lkml/2016/6/13/898), which declares a dummy for the case #ifndef CONFIG_X86_LOCAL_APIC. That should help with the issue here. >> As for disabling AVIC, I think we can also do: >> >> if (!IS_ENABLED(CONFIG_X86_LOCAL_APIC)) >> avic = false; > > Yes, we'll need to do that once AVIC is enabled by default; or > > static bool avic = IS_ENABLED(CONFIG_X86_LOCAL_APIC); > > In any case the module parameter must be hidden if there's no > support in the kernel for the local APIC. > > Paolo > Agree. If you okay with using default_cpu_present_to_apicid(), I can send out the v2 of the "[PATCH] x86/SVM: Fix implicit declaration issue for __default_cpu_present_to_apicid()" with changes that you suggested here. Thanks, Suravee