From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E7E1C433FE for ; Thu, 10 Mar 2022 16:41:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242087AbiCJQmT (ORCPT ); Thu, 10 Mar 2022 11:42:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229769AbiCJQmQ (ORCPT ); Thu, 10 Mar 2022 11:42:16 -0500 Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1305918F23D; Thu, 10 Mar 2022 08:41:14 -0800 (PST) Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 22ACrQ0b029203; Thu, 10 Mar 2022 10:40:47 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=message-id : date : mime-version : from : to : subject : references : in-reply-to : content-type : content-transfer-encoding; s=PODMain02222019; bh=xt9jZcsbIc3uRwCBEAO7UWcKQ/BRR3pjfdwtdFoPCvo=; b=MjCm65YBhjQqTx8nYg+XemIJG21ENMfZDKNF82HZUvyie42dm4Tto6XCSdtAqXaG/gGR Y37IMrZSJW1VmAffmhfa11aJaSCw6snjw/2B3J4bEUvHbhhBm3oDJjNknxsy4fo+uiiy n0QshAZt42LCTjiBBsMhmH33LHsyTyJSWhqvljEtLnSJZrSWJ+YW/T/IKCFbehZTmEGk R96VroBI3R0z60hC0uANrIgennXgwTHE0JzmWg6oZL+TUIxH88P7dBX4VwxkAr157yYJ ik1yQtQiq9gKUyl/oM3akj/pey3qQ0hGxltaSM+YLftA9XF3NscxkTHVA4zyH99DMzE1 mw== Received: from ediex01.ad.cirrus.com ([84.19.233.68]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 3em55sybva-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Thu, 10 Mar 2022 10:40:47 -0600 Received: from EDIEX01.ad.cirrus.com (198.61.84.80) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.18; Thu, 10 Mar 2022 16:40:45 +0000 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.1.2375.18 via Frontend Transport; Thu, 10 Mar 2022 16:40:45 +0000 Received: from [198.61.65.38] (unknown [198.61.65.38]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id 551EBB16; Thu, 10 Mar 2022 16:40:45 +0000 (UTC) Message-ID: Date: Thu, 10 Mar 2022 16:40:45 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 From: To: Takashi Iwai , Liam Girdwood , Mark Brown , Rob Herring , Jaroslav Kysela , Takashi Iwai , , , , , Charles Keepax Subject: Re: [PATCH v3 01/16] sound: cs35l41: Unify hardware configuration References: <20220308171730.454587-1-tanureal@opensource.cirrus.com> <20220308171730.454587-2-tanureal@opensource.cirrus.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: vG94vteHVVNXs2KSuFkG7uoGHw8T7SbI X-Proofpoint-GUID: vG94vteHVVNXs2KSuFkG7uoGHw8T7SbI X-Proofpoint-Spam-Reason: safe Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/10/22 1:44 PM, Takashi Iwai wrote: > On Tue, 08 Mar 2022 18:17:15 +0100, > Lucas Tanure wrote: > > +enum cs35l41_gpio_func { > > + CS35L41_HIZ, > > + CS35L41_GPIO, > > + CS35L41_INT_OPEN_DRAIN_GPIO2, > > + CS35L41_MCLK, > > + CS35L41_INT_PUSH_PULL_LOW_GPIO2, > > + CS35L41_INT_PUSH_PULL_HIGH_GPIO2, > > + CS35L41_PDM_CLK_GPIO2, > > + CS35L41_PDM_DATA_GPIO2, > > + CS35L41_MDSYNC_GPIO1 = 2, > > + CS35L41_PDM_CLK_GPIO1 = 4, > > + CS35L41_PDM_DATA_GPIO1 = 5, > > }; > > So CS35L41_MDSYNC_GPIO1 is identical with *_DRAIN_GPIO2, i.e. it's an > alias? > > > thanks, > > Takashi > The value 2 sets GPIO1 as MDSYNC pin and GPIO2 as IRQ pin (Open drain). It could be the same label, like CS35L41_GPIO1_MDSYNC_GPIO2_IRQ, but I think separating them is better for understanding the code and organizing the code.