From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 253B3C4360C for ; Sun, 29 Sep 2019 22:07:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EBE2F217F5 for ; Sun, 29 Sep 2019 22:07:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729147AbfI2V5h (ORCPT ); Sun, 29 Sep 2019 17:57:37 -0400 Received: from jp.dhs.org ([62.251.46.73]:60036 "EHLO jpvw.nl" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726390AbfI2V5g (ORCPT ); Sun, 29 Sep 2019 17:57:36 -0400 X-Greylist: delayed 1032 seconds by postgrey-1.27 at vger.kernel.org; Sun, 29 Sep 2019 17:57:35 EDT Received: from localhost ([127.0.0.1] helo=jpvw.nl) by jpvw.nl with esmtp (Exim 4.92) (envelope-from ) id 1iEgvQ-0001uO-6a; Sun, 29 Sep 2019 23:40:16 +0200 Subject: Re: [PATCH 1/1] media: dvbsky: use a single mutex and state buffers for all R/W ops To: Andrei Koshkosh , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, Sean Young , =?UTF-8?Q?Stefan_Br=c3=bcns?= , Greg Kroah-Hartman , Thomas Gleixner , linux-kernel@vger.kernel.org References: <1569744245-23030-1-git-send-email-andreykosh000@mail.ru> From: JP Message-ID: Date: Sun, 29 Sep 2019 23:40:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <1569744245-23030-1-git-send-email-andreykosh000@mail.ru> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This works very well for me. (and please see unrelated comment below) On 9/29/19 10:04 AM, Andrei Koshkosh wrote: > Signed-off-by: Andrei Koshkosh > --- > drivers/media/usb/dvb-usb-v2/dvbsky.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/media/usb/dvb-usb-v2/dvbsky.c b/drivers/media/usb/dvb-usb-v2/dvbsky.c > index c41e10b..6a118a0 100644 > --- a/drivers/media/usb/dvb-usb-v2/dvbsky.c > +++ b/drivers/media/usb/dvb-usb-v2/dvbsky.c > @@ -22,7 +22,6 @@ MODULE_PARM_DESC(disable_rc, "Disable inbuilt IR receiver."); > DVB_DEFINE_MOD_OPT_ADAPTER_NR(adapter_nr); > > struct dvbsky_state { > - struct mutex stream_mutex; > u8 ibuf[DVBSKY_BUF_LEN]; > u8 obuf[DVBSKY_BUF_LEN]; > u8 last_lock; > @@ -61,16 +60,18 @@ static int dvbsky_stream_ctrl(struct dvb_usb_device *d, u8 onoff) > { > struct dvbsky_state *state = d_to_priv(d); > int ret; > - u8 obuf_pre[3] = { 0x37, 0, 0 }; > - u8 obuf_post[3] = { 0x36, 3, 0 }; > + static u8 obuf_pre[3] = { 0x37, 0, 0 }; > + static u8 obuf_post[3] = { 0x36, 3, 0 }; > > - mutex_lock(&state->stream_mutex); > - ret = dvbsky_usb_generic_rw(d, obuf_pre, 3, NULL, 0); > + mutex_lock(&d->usb_mutex); > + memcpy(state->obuf, obuf_pre, 3); > + ret = dvb_usbv2_generic_write_locked(d, state->obuf, 3); > if (!ret && onoff) { > msleep(20); > - ret = dvbsky_usb_generic_rw(d, obuf_post, 3, NULL, 0); > + memcpy(state->obuf, obuf_post, 3); > + ret = dvb_usbv2_generic_write_locked(d, state->obuf, 3); > } > - mutex_unlock(&state->stream_mutex); > + mutex_unlock(&d->usb_mutex); > return ret; > } > > @@ -599,7 +600,6 @@ static int dvbsky_init(struct dvb_usb_device *d) > if (ret) > return ret; > */ commented-out code has call to non-existing function. > - mutex_init(&state->stream_mutex); > > state->last_lock = 0; > Thanks, Jan Pieter.