From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 532EEC3A5A6 for ; Tue, 27 Aug 2019 00:11:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2872A20850 for ; Tue, 27 Aug 2019 00:11:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=aj.id.au header.i=@aj.id.au header.b="pMIvHTKZ"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="oi9vzr2o" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727309AbfH0ALE (ORCPT ); Mon, 26 Aug 2019 20:11:04 -0400 Received: from new3-smtp.messagingengine.com ([66.111.4.229]:33583 "EHLO new3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726543AbfH0ALD (ORCPT ); Mon, 26 Aug 2019 20:11:03 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.nyi.internal (Postfix) with ESMTP id CDCF33BCB; Mon, 26 Aug 2019 20:11:01 -0400 (EDT) Received: from imap2 ([10.202.2.52]) by compute4.internal (MEProxy); Mon, 26 Aug 2019 20:11:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm3; bh=CDTuiZrelUWEgf3y4KZ7WxVJzGTyvoY nwkgEV9GS9EA=; b=pMIvHTKZfpHH9DiPjpIImmW3Ww53CpcROqSmFp5Tys75FC4 TBMkOOioKeLUpn+0eyWjmt2bHiT0j1gjmAm2EM0D8d4a4czex3Scxw1LdcIbarZc jZUgoUkf2I/bJFh4UEA3AXiKP/PzDt0e2V1IOFCOA7qsGnwF0U4O56YD8zX0Pe2n Aqpjhw2SU30W1GAjSG6lXTKgTqoT/iiKSYdi7lDONGb1cVAKKtPubdxgbVNY++7N LJQ2HIhXr3egKtJlhvdme2KxFrE478QhhNgExi7HyrZV8BOpHDyIUSAcPEpLlw5p huCY1LaXN99OXfdn8r12DnPn/wrN6AIOvKnbpWQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=CDTuiZ relUWEgf3y4KZ7WxVJzGTyvoYnwkgEV9GS9EA=; b=oi9vzr2oQAO4M9UzRhnh7x xG/WjjXFbS9aYWXUHhD0sX20VMN0v1Ylj/GoOPxJn77BK0VfCJMwMCRL/fiG0DWF /TvV4rPWpwMWCClxFPBM+DxcO1SqWLREyw0Jh8EfKJKmkp5/AjB61jHD3ANsO6+P DCeTe7QKCCG8iWjn0PqZHSmIibVhG6VoVUU4HLYIC8O/LudJfArrj3b/Od0c6cYm sx8cQ32bmEwH45dbR4VPLuEb5Z8ldOxz+avgSxBYxDB/eMHFgL+v+ALfS23EVBnx QN4JzC484C0aXxJGcJ4xdVcl4GvNqjDOYvv99g5gyBSiUgaeFGvOwSuojOCKfCZw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrudehhedgfeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgesthdtredtreerjeenucfhrhhomhepfdetnhgu rhgvficulfgvfhhfvghrhidfuceorghnughrvgifsegrjhdrihgurdgruheqnecurfgrrh grmhepmhgrihhlfhhrohhmpegrnhgurhgvfiesrghjrdhiugdrrghunecuvehluhhsthgv rhfuihiivgeptd X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 5EF99E00A3; Mon, 26 Aug 2019 20:10:59 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.1.7-139-g73fcb67-fmstable-20190826v1 Mime-Version: 1.0 Message-Id: In-Reply-To: References: <20190826104636.19324-1-i.mikhaylov@yadro.com> <20190826104636.19324-5-i.mikhaylov@yadro.com> Date: Tue, 27 Aug 2019 09:41:20 +0930 From: "Andrew Jeffery" To: "Guenter Roeck" , "Ivan Mikhaylov" , "Wim Van Sebroeck" Cc: "Joel Stanley" , linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, "Alexander Amelkin" , openbmc@lists.ozlabs.org, "Rob Herring" , "Mark Rutland" , devicetree@vger.kernel.org Subject: =?UTF-8?Q?Re:_[PATCH_v2_4/4]_dt-bindings/watchdog:_Add_access=5Fcs0_opti?= =?UTF-8?Q?on_for_alt-boot?= Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 27 Aug 2019, at 09:38, Guenter Roeck wrote: > On 8/26/19 4:57 PM, Andrew Jeffery wrote: > > > > > > On Mon, 26 Aug 2019, at 20:17, Ivan Mikhaylov wrote: > >> The option for the ast2400/2500 to get access to CS0 at runtime. > >> > >> Signed-off-by: Ivan Mikhaylov > >> --- > >> Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt | 7 +++++++ > >> 1 file changed, 7 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt > >> b/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt > >> index c5077a1f5cb3..023a9b578df6 100644 > >> --- a/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt > >> +++ b/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt > >> @@ -34,6 +34,13 @@ Optional properties: > >> engine is responsible for this. > >> > >> - aspeed,alt-boot: If property is present then boot from alternate > >> block. > >> + At alternate side 'access_cs0' sysfs file > >> provides: > > > > Why are we talking about sysfs in the devicetree binding? This patch > > doesn't seem right to me. > > > > Correct; this is the wrong document. The attribute also will need > to be better explained. "At alternate side" does not explain (at > least not at all clearly enough) that the attribute only exists > if the system has booted from the alternate flash / block. > > > Also if we're not supporting the aspeed,alt-boot property we should > > probably document it as deprecated rather than making it disappear, > > unless you're going to fix the systems that are using it. > > > Sorry, you lost me here. Where is it made to disappear ? Oh, hah, I read the bullet '-' as a diff marker. Maybe I should go back to bed! Andrew