From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Stanislaw Gruszka <sgruszka@redhat.com>,
Helmut Schaa <helmut.schaa@googlemail.com>
Cc: Kalle Valo <kvalo@codeaurora.org>,
linux-wireless@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>
Subject: [PATCH 15/20] rt2x00: rt2500pci: mark expected switch fall-through
Date: Mon, 22 Oct 2018 22:45:19 +0200 [thread overview]
Message-ID: <faed31f010821046ae2ce03fd1c46d202d9086d4.1540239684.git.gustavo@embeddedor.com> (raw)
In-Reply-To: <cover.1540239684.git.gustavo@embeddedor.com>
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/net/wireless/ralink/rt2x00/rt2500pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ralink/rt2x00/rt2500pci.c b/drivers/net/wireless/ralink/rt2x00/rt2500pci.c
index 1ff5434..e8e7bfe 100644
--- a/drivers/net/wireless/ralink/rt2x00/rt2500pci.c
+++ b/drivers/net/wireless/ralink/rt2x00/rt2500pci.c
@@ -1430,7 +1430,7 @@ static void rt2500pci_txdone(struct rt2x00_dev *rt2x00dev,
break;
case 2: /* Failure, excessive retries */
__set_bit(TXDONE_EXCESSIVE_RETRY, &txdesc.flags);
- /* Don't break, this is a failed frame! */
+ /* Fall through - this is a failed frame! */
default: /* Failure */
__set_bit(TXDONE_FAILURE, &txdesc.flags);
}
--
2.7.4
next prev parent reply other threads:[~2018-10-22 20:45 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-22 20:37 [PATCH 00/20] Mark expected switch fall-throughs Gustavo A. R. Silva
2018-10-22 20:37 ` [PATCH 01/20] ath6kl: Mark expected switch fall-through Gustavo A. R. Silva
2018-10-22 21:11 ` Steve deRosier
2018-11-05 11:23 ` Kalle Valo
2018-10-22 20:37 ` [PATCH 02/20] ath9k: ar5008_phy: mark " Gustavo A. R. Silva
2018-11-05 11:16 ` Kalle Valo
2018-10-22 20:38 ` [PATCH 03/20] ath9k: ar9002_phy: mark expected switch fall-throughs Gustavo A. R. Silva
2018-10-22 20:39 ` [PATCH 04/20] ath9k: hw: mark expected switch fall-through Gustavo A. R. Silva
2018-10-22 20:39 ` [PATCH 05/20] carl9170: rx: " Gustavo A. R. Silva
2018-10-22 20:40 ` [PATCH 06/20] carl9170: tx: mark expected switch fall-throughs Gustavo A. R. Silva
2018-10-22 20:40 ` [PATCH 07/20] iwlegacy: 4965-mac: mark expected switch fall-through Gustavo A. R. Silva
2018-11-06 17:00 ` Kalle Valo
2018-10-22 20:41 ` [PATCH 08/20] iwlegacy: common: mark expected switch fall-throughs Gustavo A. R. Silva
2018-10-22 20:42 ` [PATCH 09/20] orinoco_usb: mark expected switch fall-through Gustavo A. R. Silva
2018-10-22 20:42 ` [PATCH 10/20] prism54: isl_38xx: Mark " Gustavo A. R. Silva
2018-10-22 20:42 ` [PATCH 11/20] prism54: isl_ioctl: mark " Gustavo A. R. Silva
2018-10-22 20:43 ` [PATCH 12/20] prism54: islpci_dev: " Gustavo A. R. Silva
2018-10-22 20:43 ` [PATCH 13/20] mwifiex: Mark " Gustavo A. R. Silva
2018-10-22 20:44 ` [PATCH 14/20] rt2x00: rt2400pci: mark " Gustavo A. R. Silva
2018-10-22 20:45 ` Gustavo A. R. Silva [this message]
2018-10-22 20:46 ` [PATCH 16/20] rt2x00: rt2800lib: mark expected switch fall-throughs Gustavo A. R. Silva
2018-10-22 20:46 ` [PATCH 17/20] rt2x00: rt61pci: mark expected switch fall-through Gustavo A. R. Silva
2018-10-22 20:47 ` [PATCH 18/20] ray_cs: mark expected switch fall-throughs Gustavo A. R. Silva
2018-10-22 20:47 ` [PATCH 19/20] rtlwifi: rtl8821ae: phy: Mark expected switch fall-through Gustavo A. R. Silva
2018-10-23 1:24 ` Pkshih
2018-10-22 20:48 ` [PATCH 20/20] zd1201: mark " Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=faed31f010821046ae2ce03fd1c46d202d9086d4.1540239684.git.gustavo@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=davem@davemloft.net \
--cc=helmut.schaa@googlemail.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).