From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936631AbdEWIkB (ORCPT ); Tue, 23 May 2017 04:40:01 -0400 Received: from mga06.intel.com ([134.134.136.31]:41462 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936615AbdEWIjm (ORCPT ); Tue, 23 May 2017 04:39:42 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,381,1491289200"; d="scan'208";a="105810682" Subject: Re: [Intel-gfx] [PATCH] drm/i915: mark wait_for_engine() __maybe_unused To: Nick Desaulniers References: <20170521040319.13007-1-nick.desaulniers@gmail.com> Cc: airlied@linux.ie, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, daniel.vetter@intel.com From: Tvrtko Ursulin Message-ID: Date: Tue, 23 May 2017 09:39:39 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170521040319.13007-1-nick.desaulniers@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 21/05/2017 05:03, Nick Desaulniers wrote: > This solves a warning when compiling the driver with Clang, -Werror enabled, > and CONFIG_DRM_I915_DEBUG_GEM unset, since Clang warns that: > > drivers/gpu/drm/i915/i915_gem.c:3274:12: error: function > 'wait_for_engine' is not needed > and will not be emitted [-Werror,-Wunneeded-internal-declaration] > static int wait_for_engine(struct intel_engine_cs *engine, int > timeout_ms) > ^ You have actually uncovered a bug here where the call is not supposed to be optional in the first place. I'll send a different fix and copy you on it. Regards, Tvrtko > Signed-off-by: Nick Desaulniers > --- > Additionally, it only has one call site. Should I mark it inline, too, while > I'm at it? > > drivers/gpu/drm/i915/i915_gem.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c > index b6ac3df18b58..73b82fb94b0e 100644 > --- a/drivers/gpu/drm/i915/i915_gem.c > +++ b/drivers/gpu/drm/i915/i915_gem.c > @@ -3271,7 +3271,8 @@ static int wait_for_timeline(struct i915_gem_timeline *tl, unsigned int flags) > return 0; > } > > -static int wait_for_engine(struct intel_engine_cs *engine, int timeout_ms) > +static __maybe_unused int wait_for_engine( > + struct intel_engine_cs *engine, int timeout_ms) > { > return wait_for(intel_engine_is_idle(engine), timeout_ms); > } >