From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04A27C433F5 for ; Thu, 19 May 2022 20:47:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244820AbiESUrb (ORCPT ); Thu, 19 May 2022 16:47:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49134 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244808AbiESUrU (ORCPT ); Thu, 19 May 2022 16:47:20 -0400 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD82C326C2; Thu, 19 May 2022 13:47:17 -0700 (PDT) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 436F15C0124; Thu, 19 May 2022 16:47:15 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 19 May 2022 16:47:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1652993235; x= 1653079635; bh=q5BGjZKz+6FtcEUB2nrwhoMEpxnZ+4GXO7xfwU4XT/U=; b=c y4UMVW57Y2WiPsJvtM88JQYGzBVwTpL5Sd/BYg08h4TqjYnQ471CuZMCcX1/mav+ dREkI4NlvscwSqlDttJAB4eJzzqVbOdjm7fMzazjlOfI+B2VoZDKXmarWRVB1WQ6 RPHIOGA/tWU2h/MwYF8Oz1AD0IkB5LfccF7OH+jFIefyODr6azc4W5pUJCAQEkqm ZSdPR1gzzNroTsrpD4uKGZZ4pVD1zg0DtLsdTXzqP6KCUfoBdW/7ly5t8X+oihmE 3I2tZ8a1aRAeh93kuSySIZXlFi79BQZqe03rGHhMM/LVVIOHlq/dtr9tZfKARd23 d75z/F6+ehmxRB+aUAnCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1652993235; x= 1653079635; bh=q5BGjZKz+6FtcEUB2nrwhoMEpxnZ+4GXO7xfwU4XT/U=; b=S a0MTcdopiluf+XV0Nce2eQ9u/XIH3gZalb3mMt0zZztacTFNCGXCUt/RHW5gqV3D EMIdcBztcJWJah0RAX2DutEOhVOCih2Ct2Ocm4E5X5ukwEj09znaQfdIf5d71hxy WnWF7FQxUtASEg9V5Ow8J6Q2U6T/9nRVDLu2PXLG+hhOHAxWpJXASS7M7/HKPyDj wbUd5iKmZPahAxXFRKU0rnlynp6M4qu7THG070elyEOaFmYmAzvnszIJXETknana TezfKO6LLLbQGoVwmH+S8dPKORtjpEb75tJlSD9IjYKpc+aS9oJT9zyTqRLfTF0y 3gurZW9BbrWY72IYE7ldQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedriedugdduhedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeeuvghr nhguucfutghhuhgsvghrthcuoegsvghrnhgurdhstghhuhgsvghrthesfhgrshhtmhgrih hlrdhfmheqnecuggftrfgrthhtvghrnhepkeehveekleekkeejhfehgeeftdffuddujeej ieehheduueelleeghfeukeefvedunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrg hmpehmrghilhhfrhhomhepsggvrhhnugdrshgthhhusggvrhhtsehfrghsthhmrghilhdr fhhm X-ME-Proxy: Feedback-ID: id8a24192:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 19 May 2022 16:47:13 -0400 (EDT) Message-ID: Date: Thu, 19 May 2022 22:47:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [fuse-devel] [PATCH v5 0/3] FUSE: Implement atomic lookup + open/create Content-Language: fr To: Miklos Szeredi , Bernd Schubert Cc: linux-fsdevel@vger.kernel.org, Dharmendra Singh , fuse-devel , linux-kernel@vger.kernel.org, Vivek Goyal References: <20220517100744.26849-1-dharamhans87@gmail.com> From: Bernd Schubert In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/19/22 20:16, Miklos Szeredi wrote: > On Thu, 19 May 2022 at 19:42, Bernd Schubert wrote: > >> Can you help me a bit to understand what we should change? I had also >> already thought to merge CREATE_EXT and OPEN_ATOMIC - so agreed. >> Shall we make the other cases more visible? > > Make it clear in the code flow if we are using the new request or the > old; e.g. rename current fuse_atomic_open() to fuse_open_nonatomic() > and do > > static int fuse_open_atomic(...) > { > ... > args.opcode = FUSE_OPEN_ATOMIC; > ... > err = fuse_simple_request(...); > if (err == -ENOSYS) > goto fallback; > ... > fallback: > return fuse_open_nonatomic(); > } > > static int fuse_atomic_open(...) > { > if (fc->no_open_atomic) > return fuse_open_nonatomic(); > else > return fuse_open_atomic(); > } > > Also we can tweak fuse_dentry_revalidate() so it always invalidates > negative dentries if the new atomic open is available, and possibly > for positive dentries as well, if the rfc patch makes it. Thank you, we will try to do it like that during the next day. Thanks, Bernd