From: Alexander Lobakin <aleksander.lobakin@intel.com>
To: Yang Li <yang.lee@linux.alibaba.com>
Cc: <kuba@kernel.org>, <davem@davemloft.net>, <edumazet@google.com>,
<pisa@cmp.felk.cvut.cz>, <ondrej.ille@gmail.com>,
<wg@grandegger.com>, <mkl@pengutronix.de>, <pabeni@redhat.com>,
<linux-can@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] can: ctucanfd: Use devm_platform_ioremap_resource()
Date: Thu, 16 Feb 2023 17:56:05 +0100 [thread overview]
Message-ID: <fb29db5d-645b-86c7-c31c-738df55687ab@intel.com> (raw)
In-Reply-To: <20230216090610.130860-1-yang.lee@linux.alibaba.com>
From: Yang Li <yang.lee@linux.alibaba.com>
Date: Thu, 16 Feb 2023 17:06:10 +0800
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to Use devm_platform_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Reviewed-by: Alexander Lobakin <aleksander.lobakin@intel.com>
> ---
> drivers/net/can/ctucanfd/ctucanfd_platform.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/net/can/ctucanfd/ctucanfd_platform.c b/drivers/net/can/ctucanfd/ctucanfd_platform.c
> index f83684f006ea..a17561d97192 100644
> --- a/drivers/net/can/ctucanfd/ctucanfd_platform.c
> +++ b/drivers/net/can/ctucanfd/ctucanfd_platform.c
> @@ -47,7 +47,6 @@ static void ctucan_platform_set_drvdata(struct device *dev,
> */
> static int ctucan_platform_probe(struct platform_device *pdev)
> {
> - struct resource *res; /* IO mem resources */
> struct device *dev = &pdev->dev;
> void __iomem *addr;
> int ret;
> @@ -55,8 +54,7 @@ static int ctucan_platform_probe(struct platform_device *pdev)
> int irq;
>
> /* Get the virtual base address for the device */
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - addr = devm_ioremap_resource(dev, res);
> + addr = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(addr)) {
> ret = PTR_ERR(addr);
> goto err;
Thanks,
Olek
next prev parent reply other threads:[~2023-02-16 16:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 9:06 [PATCH -next] can: ctucanfd: Use devm_platform_ioremap_resource() Yang Li
2023-02-16 9:36 ` Pavel Pisa
2023-02-16 16:56 ` Alexander Lobakin [this message]
2023-02-16 20:05 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb29db5d-645b-86c7-c31c-738df55687ab@intel.com \
--to=aleksander.lobakin@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=ondrej.ille@gmail.com \
--cc=pabeni@redhat.com \
--cc=pisa@cmp.felk.cvut.cz \
--cc=wg@grandegger.com \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).