From: Waiman Long <longman@redhat.com>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Dmitry Safonov <dima@arista.com>
Cc: Jiri Slaby <jslaby@suse.cz>,
kernel test robot <rong.a.chen@intel.com>,
lkp@01.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mikulas Patocka <mpatocka@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-serial@vger.kernel.org,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [LKP] [tty] c96cf923a9: WARNING:possible_circular_locking_dependency_detected
Date: Wed, 12 Dec 2018 10:12:11 -0500 [thread overview]
Message-ID: <fb2e249a-fbda-d197-95ea-0f8a85acf6e7@redhat.com> (raw)
In-Reply-To: <20181212050432.GE431@jagdpanzerIV>
On 12/12/2018 12:04 AM, Sergey Senozhatsky wrote:
> On (12/12/18 12:42), Sergey Senozhatsky wrote:
> [..]
>>>>> [ 87.255156] CPU0 CPU1
>>>>> [ 87.255813] ---- ----
>>>>> [ 87.256460] lock(&port_lock_key);
>>>>> [ 87.256973] lock(console_owner);
>>>>> [ 87.257829] lock(&port_lock_key);
>>>>> [ 87.258680] lock(&obj_hash[i].lock);
>> So it's like
>>
>> CPU0 CPU1
>>
>> uart_shutdown() db->lock
>> uart_port->lock debug_print_object()
>> free_page() printk
>> debug_check_no_obj_freed uart_port->lock
>> db->lock
>>
>>
>> In this particular case we probably can just move free_page()
>> out of uart_port lock scope. Note that free_page()->MM can printk()
>> on its own.
>>
> [..]
>> [1] https://lore.kernel.org/lkml/1542653726-5655-8-git-send-email-longman@redhat.com/T/#u
> That said, I'd first try Waiman's patch. The one I suggested is
> more of a defense move - there are too many things happening under
> uart_port->lock. This is not the first time we see lockdep complaining
> about the way uart and the rest of the kernel interact.
>
> -ss
Thanks for the information. I will extract my debugobjects patch out of
my lockdep patchset and send it out as standalone patch.
Cheers,
Longman
next prev parent reply other threads:[~2018-12-12 15:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 9:11 [LKP] [tty] c96cf923a9: WARNING:possible_circular_locking_dependency_detected kernel test robot
2018-12-11 13:49 ` Jiri Slaby
2018-12-11 20:59 ` Dmitry Safonov
2018-12-12 3:42 ` Sergey Senozhatsky
2018-12-12 5:04 ` Sergey Senozhatsky
2018-12-12 15:12 ` Waiman Long [this message]
2018-12-12 9:07 ` Peter Zijlstra
2018-12-13 5:38 ` Sergey Senozhatsky
2018-12-12 14:54 ` Dmitry Safonov
2018-12-13 2:19 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb2e249a-fbda-d197-95ea-0f8a85acf6e7@redhat.com \
--to=longman@redhat.com \
--cc=dima@arista.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lkp@01.org \
--cc=mpatocka@redhat.com \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=rong.a.chen@intel.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).