From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09716FA3741 for ; Mon, 31 Oct 2022 18:02:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229799AbiJaSCT (ORCPT ); Mon, 31 Oct 2022 14:02:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229500AbiJaSCQ (ORCPT ); Mon, 31 Oct 2022 14:02:16 -0400 Received: from omta35.uswest2.a.cloudfilter.net (omta35.uswest2.a.cloudfilter.net [35.89.44.34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C91413D2A for ; Mon, 31 Oct 2022 11:02:16 -0700 (PDT) Received: from eig-obgw-6015a.ext.cloudfilter.net ([10.0.30.134]) by cmsmtp with ESMTP id pXtaopQjMlI84pZ71o9odk; Mon, 31 Oct 2022 18:02:15 +0000 Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with ESMTP id pZ70oZv1hnQ2apZ70oW1oB; Mon, 31 Oct 2022 18:02:14 +0000 X-Authority-Analysis: v=2.4 cv=frvP2X0f c=1 sm=1 tr=0 ts=63600da6 a=1YbLdUo/zbTtOZ3uB5T3HA==:117 a=wTog8WU66it3cfrESHnF4A==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10 a=Qawa6l4ZSaYA:10 a=wYkD_t78qR0A:10 a=XPDCPBHLajm3aRFYHAUA:9 a=QEXdDO2ut3YA:10 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedor.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=4M+EkqO2JIQhdRROs6iO5knFvCzc2rYBZdIfB6LFo1M=; b=eYQmoSDCBMmgeFFVkQtGqxSpu6 VbhdOaE5Q6z1ta4Y4WbtONilXDaXlCi7bvqUp8/lBqNx3816DhW7waQaBPrFYo8iL6kIxedBrjOH/ jy9CgKAef2zrh7WR3I/lKcQ53sXf5Of1HnTWJZFr4xfyO9CbMtYVD4yD5xvLMRjZ5J2DEq5BgDRjc Nn/C6ck/0lGwUdTO81d7vAqLMQZUfRuqN6ooq3H9vgDYkCjV30tD7evQn4amKnGbjPgzJM1dmNs3G AwaJd2eIAZIIcJ2KrPdjC3v1jf9dcM/cj1vdI3Sgnd8kpkl9vxnClkoDV2kPABGgGES8vtrNo24uB wi3lTTag==; Received: from 187-162-31-110.static.axtel.net ([187.162.31.110]:60834 helo=[192.168.15.7]) by gator4166.hostgator.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.95) (envelope-from ) id 1opZ6x-002ncA-Um; Mon, 31 Oct 2022 13:02:12 -0500 Message-ID: Date: Mon, 31 Oct 2022 12:01:51 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v2 1/6] cfg80211: Avoid clashing function prototypes Content-Language: en-US To: Johannes Berg , "Gustavo A. R. Silva" , Stanislav Yakovlev , Kalle Valo , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Kees Cook , linux-hardening@vger.kernel.org References: From: "Gustavo A. R. Silva" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 187.162.31.110 X-Source-L: No X-Exim-ID: 1opZ6x-002ncA-Um X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 187-162-31-110.static.axtel.net ([192.168.15.7]) [187.162.31.110]:60834 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 3 X-Org: HG=hgshared;ORG=hostgator; X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfNGIoX4U4/TzhdNa4pbj9QFifKxxCrZjRxuTeweAep8XHdQmEpeyeOmMs13rg6tNtcTPb2Siriip0lzs1lgBR6znPJuDFKAkhtyjIsJ/HtW/ZvNf1u1w 4t0HqwneFEd19I3quDfpOyCgAyfrjPwovfRw4kB8h2Air/h2+pDiTK3VXQ5aIJ4xBUwK0HynovQ1QYY3L8exv9SZC8YioU8OTxEz3blOhL0977uE1pViXNSf Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/28/22 03:22, Johannes Berg wrote: > Hm. > > If you're splitting out per driver, > >> +++ b/drivers/net/wireless/intel/ipw2x00/ipw2200.c >> @@ -9870,7 +9870,7 @@ static int ipw_wx_sw_reset(struct net_device *dev, >> >> /* Rebase the WE IOCTLs to zero for the handler array */ >> static iw_handler ipw_wx_handlers[] = { >> - IW_HANDLER(SIOCGIWNAME, (iw_handler)cfg80211_wext_giwname), >> + IW_HANDLER(SIOCGIWNAME, cfg80211_wext_giwname), > > I can see how this (and similar) still belongs into this patch since > it's related to the cfg80211 change, but > >> +++ b/drivers/net/wireless/intersil/orinoco/wext.c >> @@ -154,9 +154,10 @@ static struct iw_statistics *orinoco_get_wireless_stats(struct net_device *dev) >> >> static int orinoco_ioctl_setwap(struct net_device *dev, >> struct iw_request_info *info, >> - struct sockaddr *ap_addr, >> + union iwreq_data *wrqu, >> char *extra) >> { >> + struct sockaddr *ap_addr = &wrqu->ap_addr; > > why this (and similar) too? mmh... yeah; orinoco should be a separate patch. :) Thanks -- Gustavo