From: Daniel Borkmann <daniel@iogearbox.net>
To: Martin KaFai Lau <kafai@fb.com>, David Laight <David.Laight@ACULAB.COM>
Cc: Okash Khawaja <osk@fb.com>, Alexei Starovoitov <ast@kernel.org>,
Yonghong Song <yhs@fb.com>,
Jakub Kicinski <jakub.kicinski@netronome.com>,
"David S. Miller" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"kernel-team@fb.com" <kernel-team@fb.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH bpf 1/1] bpf: btf: Fix bitfield extraction for big endian
Date: Tue, 10 Jul 2018 20:13:44 +0200 [thread overview]
Message-ID: <fb5cbecc-219b-b65c-cdc0-daddf6017d11@iogearbox.net> (raw)
In-Reply-To: <20180710171836.xcegzammqym4sqri@kafai-mbp.dhcp.thefacebook.com>
On 07/10/2018 07:18 PM, Martin KaFai Lau wrote:
[...]
> I would prefer to keep it as u16 which is the max width that is allowed for
> this field in the wire format. Keeping the usage consistent can avoid
> accidentally incorrect offsetting or writing wrong data out in other
> cases.
+1
prev parent reply other threads:[~2018-07-10 18:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 0:22 [PATCH bpf 0/1] bpf: btf: Fix endianness of bitfields Okash Khawaja
2018-07-09 0:22 ` [PATCH bpf 1/1] bpf: btf: Fix bitfield extraction for big endian Okash Khawaja
2018-07-09 17:32 ` Martin KaFai Lau
2018-07-09 18:32 ` Martin KaFai Lau
2018-07-10 8:21 ` Daniel Borkmann
[not found] ` <20180710174904.GA3247@w1t1fb>
2018-07-10 20:02 ` Daniel Borkmann
2018-07-10 16:35 ` David Laight
2018-07-10 17:18 ` Martin KaFai Lau
2018-07-10 18:13 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb5cbecc-219b-b65c-cdc0-daddf6017d11@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=David.Laight@ACULAB.COM \
--cc=ast@kernel.org \
--cc=davem@davemloft.net \
--cc=jakub.kicinski@netronome.com \
--cc=kafai@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=osk@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).