From: Dmitry Osipenko <digetx@gmail.com>
To: Ashish Mhetre <amhetre@nvidia.com>,
thierry.reding@gmail.com, jonathanh@nvidia.com,
linux-tegra@vger.kernel.org, krzysztof.kozlowski@canonical.com,
linux-kernel@vger.kernel.org
Cc: Snikam@nvidia.com, vdumpa@nvidia.com
Subject: Re: [Patch V1 1/4] memory: tegra: Add support for mc interrupts
Date: Wed, 19 Jan 2022 16:42:07 +0300 [thread overview]
Message-ID: <fb6a6827-06bf-992e-ed87-cb20eff3c19b@gmail.com> (raw)
In-Reply-To: <fb2fa56a-f1eb-bb19-36ab-a2d460dd3a9b@nvidia.com>
19.01.2022 11:47, Ashish Mhetre пишет:
>
>
> On 1/12/2022 1:43 PM, Dmitry Osipenko wrote:
>> External email: Use caution opening links or attachments
>>
>>
>> 11.01.2022 21:45, Ashish Mhetre пишет:
>>>
>>> @@ -765,16 +768,21 @@ static int tegra_mc_probe(struct
>>> platform_device *pdev)
>>> return err;
>>> }
>>>
>>> - if (mc->soc->ops && mc->soc->ops->handle_irq) {
>>> + if (mc->soc->interrupt_ops &&
>>> mc->soc->interrupt_ops->handle_irq) {
>>> mc->irq = platform_get_irq(pdev, 0);
>>> if (mc->irq < 0)
>>> return mc->irq;
>>>
>>> WARN(!mc->soc->client_id_mask, "missing client ID mask
>>> for this SoC\n");
>>>
>>> + /* clear any mc-errs that occurred before. */
>>
>> s/mc-errs/Memory Controller errors/
>>
> Sure, I'll update these in next version.
>>> + if (mc->soc->interrupt_ops->clear_interrupt)
>>> + mc->soc->interrupt_ops->clear_interrupt(mc);
>>
>> There is no explanation of this change neither in the code, nor in the
>> commit message. Please always provide detailed descriptions for a
>> non-trivial changes.
>>
>> Interrupts aren't cleared intentionally by the driver, otherwise you'll
>> never know about early-boot memory faults which happened before the
>> probe. Hence this change is incorrect.
> That's true, we should be logging early-boot memory faults as well.
> Ideally there shouldn't be any early-boot faults as all clients will
> be up after MC, right? But I agree that we should be checking and
> logging if any interrupt is present.
Normally there won't be any errors during early boot, otherwise they
need to be fixed.
next prev parent reply other threads:[~2022-01-19 13:42 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-11 18:45 [Patch V1 0/4] memory: tegra: Update mc interrupts Ashish Mhetre
2022-01-11 18:45 ` [Patch V1 1/4] memory: tegra: Add support for " Ashish Mhetre
2022-01-11 20:29 ` Krzysztof Kozlowski
2022-01-19 7:36 ` Ashish Mhetre
2022-01-12 8:13 ` Dmitry Osipenko
2022-01-19 8:47 ` Ashish Mhetre
2022-01-19 13:42 ` Dmitry Osipenko [this message]
2022-01-11 18:45 ` [Patch V1 2/4] memory: tegra: Add interrupt mask Ashish Mhetre
2022-01-11 20:32 ` Krzysztof Kozlowski
2022-01-19 7:38 ` Ashish Mhetre
2022-01-11 18:45 ` [Patch V1 3/4] memory: tegra: add mc-err support for T186 Ashish Mhetre
2022-01-11 20:56 ` Krzysztof Kozlowski
2022-01-19 8:33 ` Ashish Mhetre
2022-01-12 11:01 ` Dmitry Osipenko
2022-01-19 8:53 ` Ashish Mhetre
2022-01-19 13:41 ` Dmitry Osipenko
2022-01-12 11:02 ` Dmitry Osipenko
2022-01-19 8:58 ` Ashish Mhetre
2022-01-12 11:22 ` Dmitry Osipenko
2022-01-12 11:24 ` Dmitry Osipenko
2022-01-19 9:09 ` Ashish Mhetre
2022-01-19 13:42 ` Dmitry Osipenko
2022-01-11 18:45 ` [Patch V1 4/4] memory: tegra: add mc-err support for T194 Ashish Mhetre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb6a6827-06bf-992e-ed87-cb20eff3c19b@gmail.com \
--to=digetx@gmail.com \
--cc=Snikam@nvidia.com \
--cc=amhetre@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=vdumpa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).