From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98E6DC48BE5 for ; Tue, 15 Jun 2021 03:20:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7C40461400 for ; Tue, 15 Jun 2021 03:20:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230383AbhFODWM (ORCPT ); Mon, 14 Jun 2021 23:22:12 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:4908 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230181AbhFODWJ (ORCPT ); Mon, 14 Jun 2021 23:22:09 -0400 Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4G3s3n5J9Vz6ys2; Tue, 15 Jun 2021 10:00:53 +0800 (CST) Received: from dggpemm500019.china.huawei.com (7.185.36.180) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Tue, 15 Jun 2021 10:04:01 +0800 Received: from [10.67.109.184] (10.67.109.184) by dggpemm500019.china.huawei.com (7.185.36.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Tue, 15 Jun 2021 10:04:00 +0800 Subject: Re: [PATCH -next] drm/hyperv: Remove unused variable To: Thomas Zimmermann , , , CC: , , , References: <20210609024940.34933-1-pulehui@huawei.com> <078d9bb5-e7af-4961-f4c1-cd3ab415cff4@suse.de> From: Pu Lehui Message-ID: Date: Tue, 15 Jun 2021 10:04:00 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <078d9bb5-e7af-4961-f4c1-cd3ab415cff4@suse.de> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.109.184] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemm500019.china.huawei.com (7.185.36.180) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/6/9 15:46, Thomas Zimmermann wrote: > Hi > > Am 09.06.21 um 04:49 schrieb Pu Lehui: >> Fixes gcc '-Wunused-const-variable' warning: >>    drivers/gpu/drm/hyperv/hyperv_drm_modeset.c:152:23: warning: >>      'hyperv_modifiers' defined but not used [-Wunused-const-variable=] >> >> Signed-off-by: Pu Lehui >> --- >>   drivers/gpu/drm/hyperv/hyperv_drm_modeset.c | 5 ----- >>   1 file changed, 5 deletions(-) >> >> diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c >> b/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c >> index 02718e3e859e..3f83493909e6 100644 >> --- a/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c >> +++ b/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c >> @@ -149,11 +149,6 @@ static const uint32_t hyperv_formats[] = { >>       DRM_FORMAT_XRGB8888, >>   }; >> -static const uint64_t hyperv_modifiers[] = { >> -    DRM_FORMAT_MOD_LINEAR, >> -    DRM_FORMAT_MOD_INVALID >> -}; > > This constant should rather be used in the call to > drm_simple_display_pipe_init(). [1] > > Best regards > Thomas > > [1] > https://cgit.freedesktop.org/drm/drm-misc/tree/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c#n161 > > > >> - >>   static inline int hyperv_pipe_init(struct hyperv_drm_device *hv) >>   { >>       int ret; >> > Hi Thomas, Thanks for your suggestion, I will fix it in v2. Best regards Lehui