From: Aswath Govindraju <a-govindraju@ti.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Lokesh Vutla <lokeshvutla@ti.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] arm64: dts: ti: am65: align ti,pindir-d0-out-d1-in property with dt-shema
Date: Tue, 8 Jun 2021 10:54:37 +0530 [thread overview]
Message-ID: <fb6c6c73-a29b-e190-b4c0-3b8b030d8268@ti.com> (raw)
In-Reply-To: <8d466cbc-eb35-42a8-d4d6-5bcf44cf965e@siemens.com>
Hi Jan,
On 08/06/21 10:50 am, Jan Kiszka wrote:
> On 08.06.21 07:14, Aswath Govindraju wrote:
>> ti,pindir-d0-out-d1-in property is expected to be of type boolean.
>> Therefore, fix the property accordingly.
>>
>
> Is there a patch for Documentation/devicetree/bindings/spi/omap-spi.txt
> on the way as well that makes this even clearer?
>
Yes, these fixes are a part of conversion of omap-spi.txt to yaml
format. In the yaml file the type for the property is mentioned.
Link to yaml conversion patch,
https://lore.kernel.org/patchwork/project/lkml/list/?series=503240
>> Fixes: e180f76d0641 ("arm64: dts: ti: Add support for Siemens IOT2050 boards")
>> Fixes: 5da94b50475a ("arm64: dts: ti: k3-am654: Enable main domain McSPI0")
>> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
>> ---
>> arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi | 2 +-
>> arch/arm64/boot/dts/ti/k3-am654-base-board.dts | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
>> index f4ec9ed52939..23d51b6a9cf2 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
>> +++ b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
>> @@ -575,7 +575,7 @@
>>
>> #address-cells = <1>;
>> #size-cells= <0>;
>> - ti,pindir-d0-out-d1-in = <1>;
>> + ti,pindir-d0-out-d1-in;
>> };
>>
>
> Acked-by: Jan Kiszka <jan.kiszka@siemens.com>
>
Thanks,
Aswath
> Jan
>
>> &tscadc0 {
>> diff --git a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
>> index eddb2ffb93ca..1b947e2c2e74 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
>> +++ b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
>> @@ -299,7 +299,7 @@
>> pinctrl-0 = <&main_spi0_pins_default>;
>> #address-cells = <1>;
>> #size-cells= <0>;
>> - ti,pindir-d0-out-d1-in = <1>;
>> + ti,pindir-d0-out-d1-in;
>>
>> flash@0{
>> compatible = "jedec,spi-nor";
>>
>
>
next prev parent reply other threads:[~2021-06-08 5:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 5:14 [PATCH v2 0/2] arm64: am65/am64: Fix ti,pindir-d0-out-d1-in property to boolean Aswath Govindraju
2021-06-08 5:14 ` [PATCH v2 1/2] arm64: dts: ti: am65: align ti,pindir-d0-out-d1-in property with dt-shema Aswath Govindraju
2021-06-08 5:20 ` Jan Kiszka
2021-06-08 5:24 ` Aswath Govindraju [this message]
2021-06-09 13:48 ` Vignesh Raghavendra
2021-06-08 5:14 ` [PATCH v2 2/2] arm64: dts: ti: k3-am642-evm: " Aswath Govindraju
2021-06-09 13:47 ` Vignesh Raghavendra
2021-06-11 19:00 ` [PATCH v2 0/2] arm64: am65/am64: Fix ti,pindir-d0-out-d1-in property to boolean Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb6c6c73-a29b-e190-b4c0-3b8b030d8268@ti.com \
--to=a-govindraju@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=jan.kiszka@siemens.com \
--cc=kishon@ti.com \
--cc=kristo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lokeshvutla@ti.com \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).