From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
To: Haakon Bugge <haakon.bugge@oracle.com>
Cc: Tejun Heo <tj@kernel.org>, Bart Van Assche <bvanassche@acm.org>,
syzbot <syzbot+831661966588c802aae9@syzkaller.appspotmail.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
LKML <linux-kernel@vger.kernel.org>,
OFED mailing list <linux-rdma@vger.kernel.org>,
"syzkaller-bugs@googlegroups.com"
<syzkaller-bugs@googlegroups.com>,
Lai Jiangshan <jiangshanlai@gmail.com>
Subject: Re: [syzbot] possible deadlock in worker_thread
Date: Tue, 15 Feb 2022 21:48:58 +0900 [thread overview]
Message-ID: <fb854eea-a7e7-b526-a989-95784c1c593c@I-love.SAKURA.ne.jp> (raw)
In-Reply-To: <76616D2F-14F2-4D83-9DB4-576FB2ACB72C@oracle.com>
On 2022/02/15 19:43, Haakon Bugge wrote:
>> @@ -6070,6 +6087,13 @@ void __init workqueue_init_early(void)
>> !system_unbound_wq || !system_freezable_wq ||
>> !system_power_efficient_wq ||
>> !system_freezable_power_efficient_wq);
>> + system_wq->flags |= __WQ_SYSTEM_WIDE;
>> + system_highpri_wq->flags |= __WQ_SYSTEM_WIDE;
>> + system_long_wq->flags |= __WQ_SYSTEM_WIDE;
>> + system_unbound_wq->flags |= __WQ_SYSTEM_WIDE;
>> + system_freezable_wq->flags |= __WQ_SYSTEM_WIDE;
>> + system_power_efficient_wq->flags |= __WQ_SYSTEM_WIDE;
>> + system_freezable_power_efficient_wq->flags |= __WQ_SYSTEM_WIDE;
>
> Better to OR this in, in the alloc_workqueue() call? Perceive the notion of an opaque object?
>
I do not want to do like
- system_wq = alloc_workqueue("events", 0, 0);
+ system_wq = alloc_workqueue("events", __WQ_SYSTEM_WIDE, 0);
because the intent of this change is to ask developers to create their own WQs.
If I pass __WQ_SYSTEM_WIDE to alloc_workqueue(), developers might by error create like
srp_tl_err_wq = alloc_workqueue("srp_tl_err_wq", __WQ_SYSTEM_WIDE, 0);
because of
system_wq = alloc_workqueue("events", __WQ_SYSTEM_WIDE, 0);
line. The __WQ_SYSTEM_WIDE is absolutely meant to be applied to only 'system_wq',
'system_highpri_wq', 'system_long_wq', 'system_unbound_wq', 'system_freezable_wq',
'system_power_efficient_wq' and 'system_freezable_power_efficient_wq' WQs, in order
to avoid calling flush_workqueue() on these system-wide WQs.
I wish I could define __WQ_SYSTEM_WIDE inside kernel/workqueue_internal.h, but
it seems that kernel/workqueue_internal.h does not define internal flags.
next prev parent reply other threads:[~2022-02-15 12:49 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 19:27 [syzbot] possible deadlock in worker_thread syzbot
2022-02-11 18:59 ` Bart Van Assche
2022-02-12 5:31 ` Tetsuo Handa
2022-02-12 16:37 ` Bart Van Assche
2022-02-12 17:14 ` Tetsuo Handa
2022-02-13 15:33 ` Leon Romanovsky
2022-02-13 23:06 ` Bart Van Assche
2022-02-14 1:08 ` Tetsuo Handa
2022-02-14 3:44 ` Tejun Heo
2022-02-14 13:36 ` Tetsuo Handa
2022-02-14 17:34 ` Tejun Heo
2022-02-15 10:26 ` Tetsuo Handa
2022-02-15 10:43 ` Haakon Bugge
2022-02-15 12:48 ` Tetsuo Handa [this message]
2022-02-15 17:05 ` Bart Van Assche
2022-02-15 22:05 ` Tetsuo Handa
2022-02-22 18:26 ` Tejun Heo
2022-02-17 11:22 ` [PATCH v2] workqueue: Warn flush attempt using system-wide workqueues Tetsuo Handa
2022-02-22 18:36 ` Tejun Heo
[not found] ` <CGME20220223212048eucas1p1fab5e35ff398eff57808a8f1125dd15f@eucas1p1.samsung.com>
2022-02-23 21:20 ` Marek Szyprowski
2022-02-23 21:35 ` Tejun Heo
2022-02-23 22:06 ` Tetsuo Handa
2022-02-17 12:27 ` [syzbot] possible deadlock in worker_thread Fabio M. De Francesco
2022-02-22 18:30 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb854eea-a7e7-b526-a989-95784c1c593c@I-love.SAKURA.ne.jp \
--to=penguin-kernel@i-love.sakura.ne.jp \
--cc=bvanassche@acm.org \
--cc=haakon.bugge@oracle.com \
--cc=jgg@ziepe.ca \
--cc=jiangshanlai@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=syzbot+831661966588c802aae9@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).