From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61D62C43470 for ; Thu, 1 Apr 2021 07:02:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 173FE610E5 for ; Thu, 1 Apr 2021 07:02:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233543AbhDAHCA (ORCPT ); Thu, 1 Apr 2021 03:02:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33942 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233481AbhDAHBW (ORCPT ); Thu, 1 Apr 2021 03:01:22 -0400 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5A94C0613E6 for ; Thu, 1 Apr 2021 00:01:11 -0700 (PDT) Received: by mail-wr1-x42d.google.com with SMTP id c8so671908wrq.11 for ; Thu, 01 Apr 2021 00:01:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=XxW6GzMrN0Or1bqQ0qn35Sh1DN+NPsw4YzuK1fkqU8M=; b=uSQ7twNO8Hh+u3wc9cVoL6ADPfa0uu3xna/Rh02Bf4Xywxvm6b4/6ZcIsCYmavIpaf TzINuLiCIvRmI2dChUtfxEBkfTgKEQKirov5pdFW/mfNvhdjBi+AnErb5VWiYXv01oyP lwejUKPKVkTDm4gqFXsRIegotWDpYx30b15wDd3J6FhX2RLnCic+5D7/6YepP5HChbvM S/y87wVx9GDxyiVnooPP+bu0oMV2YNrhSLEb6WF34JJ/zEAcVEXalpdDQ8zwpDNNEqyH 7SzZdUmb3esYYDYZXdEO3Eay2osuh9v3KoiyR3oUmlD2EiLBFLXJ5UDs+2Ho5TxxZWtj 0zzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=XxW6GzMrN0Or1bqQ0qn35Sh1DN+NPsw4YzuK1fkqU8M=; b=H3Xh3g36pLOxgj52tqvMc6cMqBPCWs4L5U02wen1HqfnAanUNdwItHogBNWU5h22SV 0DQuBrJKzeoHeXk2CEHSLVcvk2iPkOvzrcd6duXL/Q1HyP2ULZt1DtTuNcpVLlblJxXX KKasHePcFlrb1+AHZmlyxSBd64/1Y6kZdnodxazo4DZm43V42oolDGtVhOZUtD/8TULb 7R4fZM3zGgm8gBv/DuO1sOXCYVASW92fWpV5EZItGr1EpkEe+oG7BSS+AOiwW0UVaPV6 QUpnYq8UFvJnRzqFhBWEG9d5Lv6JqdIYfvJM1YjTF83s6eavEphSWsdXJ76SntHuyLF/ pM7Q== X-Gm-Message-State: AOAM531InFIWrVDpFm1XCNmN6FnzNsFvUK013yfw+leFZ3K+4XB3LZiD qluRkVLVllS/CCNxbRm+zChDGg== X-Google-Smtp-Source: ABdhPJy4uwdCMh0heaa9ytrLR5P9/OzE4GjRaqDhpvlvNXJefDqYnWYoYL84Y4/RNP5KHUjSRPM/iA== X-Received: by 2002:a05:6000:223:: with SMTP id l3mr7811596wrz.5.1617260470516; Thu, 01 Apr 2021 00:01:10 -0700 (PDT) Received: from ?IPv6:2a01:e34:ed2f:f020:1573:1dd5:899d:6362? ([2a01:e34:ed2f:f020:1573:1dd5:899d:6362]) by smtp.googlemail.com with ESMTPSA id c8sm6894817wmb.34.2021.04.01.00.01.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Apr 2021 00:01:10 -0700 (PDT) Subject: Re: [PATCH v5 2/5] powercap/drivers/dtpm: Create a registering system To: Greg KH Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, lukasz.luba@arm.com, rafael@kernel.org References: <20210331110048.24956-1-daniel.lezcano@linaro.org> <20210331110048.24956-2-daniel.lezcano@linaro.org> <918bc42d-0bd7-753c-1132-fd19617349ed@linaro.org> From: Daniel Lezcano Message-ID: Date: Thu, 1 Apr 2021 09:01:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/04/2021 08:02, Greg KH wrote: > On Wed, Mar 31, 2021 at 10:46:48PM +0200, Daniel Lezcano wrote: >> >> Hi Greg, >> >> On 31/03/2021 20:06, Greg KH wrote: >>> On Wed, Mar 31, 2021 at 01:00:45PM +0200, Daniel Lezcano wrote: >>>> +struct dtpm *dtpm_lookup(const char *name); >>>> + >>>> +int dtpm_add(const char *name, struct dtpm *dtpm); >>>> + >>>> +void dtpm_del(const char *name); >>> >>> You can not add new kernel apis that have no user. How do you know if >>> they actually work or not? We have no idea as we do not see anyone >>> using them :( >>> >>> So no need to add things with no user, feel free to just drop this patch >>> until you have one. >> >> I've sent a couple of patches [1] on top of the previous series. I'm >> finishing to respin it against this new one. >> >> -- Daniel >> >> [1] https://lkml.org/lkml/2021/3/12/1514 > > Please use lore.kernel.org, we do not control lkml and it has been down > in the past and it's impossible to reply from. > > Please always provide a user of a function in the patch series, > otherwise you will end up with comments like mine above. Ok, will do. Thanks -- Daniel -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog