From: Bhaumik Bhatt <bbhatt@codeaurora.org>
To: Hemant Kumar <hemantk@codeaurora.org>
Cc: manivannan.sadhasivam@linaro.org, linux-arm-msm@vger.kernel.org,
loic.poulain@linaro.org, jhugo@codeaurora.org,
linux-kernel@vger.kernel.org,
hemantk=codeaurora.org@codeaurora.org
Subject: Re: [PATCH v3 1/7] bus: mhi: core: Allow receiving a STOP channel command response
Date: Thu, 03 Dec 2020 17:43:42 -0800 [thread overview]
Message-ID: <fbc578fa720b6f492d77c64efdb80e67@codeaurora.org> (raw)
In-Reply-To: <6668b99c-a1a7-920a-4a7e-e2cb2729baee@codeaurora.org>
On 2020-12-02 04:15 PM, Hemant Kumar wrote:
> Hi Bhaumik,
>
> On 12/2/20 3:40 PM, Bhaumik Bhatt wrote:
>> Add support to receive the response to a STOP channel command to the
> How about saying "Add support to send the STOP channel command ?
Addressed in v4.
>> MHI bus. If a client would like to STOP a channel instead of issuing
>> a RESET to it, this would provide support for it.
>>
>> Signed-off-by: Bhaumik Bhatt <bbhatt@codeaurora.org>
>> ---
>> drivers/bus/mhi/core/main.c | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/bus/mhi/core/main.c b/drivers/bus/mhi/core/main.c
>> index 702c31b..a7bb8a7 100644
>> --- a/drivers/bus/mhi/core/main.c
>> +++ b/drivers/bus/mhi/core/main.c
>> @@ -1193,6 +1193,11 @@ int mhi_send_cmd(struct mhi_controller
>> *mhi_cntrl,
>> cmd_tre->dword[0] = MHI_TRE_CMD_RESET_DWORD0;
>> cmd_tre->dword[1] = MHI_TRE_CMD_RESET_DWORD1(chan);
>> break;
>> + case MHI_CMD_STOP_CHAN:
>> + cmd_tre->ptr = MHI_TRE_CMD_STOP_PTR;
>> + cmd_tre->dword[0] = MHI_TRE_CMD_STOP_DWORD0;
>> + cmd_tre->dword[1] = MHI_TRE_CMD_STOP_DWORD1(chan);
>> + break;
>> case MHI_CMD_START_CHAN:
>> cmd_tre->ptr = MHI_TRE_CMD_START_PTR;
>> cmd_tre->dword[0] = MHI_TRE_CMD_START_DWORD0;
>>
>
> Thanks,
> Hemant
Thanks,
Bhaumik
---
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2020-12-04 1:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 23:40 [PATCH v3 0/7] Updates to MHI channel handling Bhaumik Bhatt
2020-12-02 23:40 ` [PATCH v3 1/7] bus: mhi: core: Allow receiving a STOP channel command response Bhaumik Bhatt
2020-12-03 0:15 ` Hemant Kumar
2020-12-04 1:43 ` Bhaumik Bhatt [this message]
2020-12-02 23:40 ` [PATCH v3 2/7] bus: mhi: core: Allow channel to be disabled from stopped state Bhaumik Bhatt
2020-12-03 0:17 ` Hemant Kumar
2020-12-02 23:40 ` [PATCH v3 3/7] bus: mhi: core: Improvements to the channel handling state machine Bhaumik Bhatt
2020-12-03 0:51 ` Hemant Kumar
2020-12-02 23:40 ` [PATCH v3 4/7] bus: mhi: core: Add support to stop or start channel data transfers Bhaumik Bhatt
2020-12-03 0:33 ` Hemant Kumar
2020-12-04 1:44 ` Bhaumik Bhatt
2020-12-02 23:40 ` [PATCH v3 5/7] bus: mhi: core: Check execution environment for channel before issuing reset Bhaumik Bhatt
2020-12-03 0:54 ` Hemant Kumar
2020-12-02 23:40 ` [PATCH v3 6/7] bus: mhi: core: Remove __ prefix for MHI channel unprepare function Bhaumik Bhatt
2020-12-02 23:48 ` Hemant Kumar
2020-12-02 23:40 ` [PATCH v3 7/7] bus: mhi: Improve documentation on channel transfer setup APIs Bhaumik Bhatt
2020-12-03 0:56 ` Hemant Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fbc578fa720b6f492d77c64efdb80e67@codeaurora.org \
--to=bbhatt@codeaurora.org \
--cc=hemantk=codeaurora.org@codeaurora.org \
--cc=hemantk@codeaurora.org \
--cc=jhugo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=manivannan.sadhasivam@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).