From: Chao Yu <chao@kernel.org>
To: Mel Gorman <mgorman@techsingularity.net>
Cc: Matthew Wilcox <willy@infradead.org>,
Jaegeuk Kim <jaegeuk@kernel.org>,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org
Subject: Re: [f2fs-dev] [PATCH] f2fs: initialize page->private when using for our internal use
Date: Sat, 10 Jul 2021 16:11:38 +0800 [thread overview]
Message-ID: <fc0de0c2-a3b6-df91-5b90-524768a85d82@kernel.org> (raw)
In-Reply-To: <20210707095706.GT3840@techsingularity.net>
On 2021/7/7 17:57, Mel Gorman wrote:
> I think it would work but it would be preferable to find out why the
> tail page has an order set in the first place. I've looked over
Agreed.
> mm/page_alloc.c and mm/compaction.c a few times and did not spot where
> set_private_page(page, 0) is missed when it should be covered by
> clear_page_guard or del_page_from_free_list :(
I didn't enable CONFIG_DEBUG_PAGEALLOC, so we will expect page private
should be cleared by del_page_from_free_list(), but I guess it only clears
the buddy's private field rather than original page's, so I added below
diff and check the dmesg, it looks stall private value in original page
will be left commonly... Let me know if I missed something?
---
mm/page_alloc.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index a06bcfe6f786..1e7031ff548e 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -1029,6 +1029,7 @@ static inline void __free_one_page(struct page *page,
unsigned long combined_pfn;
unsigned int max_order;
struct page *buddy;
+ struct page *orig_page = page;
bool to_tail;
max_order = min_t(unsigned int, MAX_ORDER - 1, pageblock_order);
@@ -1097,6 +1098,10 @@ static inline void __free_one_page(struct page *page,
done_merging:
set_buddy_order(page, order);
+ if (orig_page != page) {
+ if (WARN_ON_ONCE(orig_page->private))
+ pr_info("2order:%x, origpage.private:%x", order, orig_page->private);
+ }
if (fpi_flags & FPI_TO_TAIL)
to_tail = true;
--
2.22.1
>
next prev parent reply other threads:[~2021-07-10 8:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-05 5:22 [PATCH] f2fs: initialize page->private when using for our internal use Jaegeuk Kim
2021-07-05 6:32 ` [f2fs-dev] " Chao Yu
2021-07-05 8:56 ` Jaegeuk Kim
2021-07-05 11:33 ` Chao Yu
2021-07-05 11:47 ` Matthew Wilcox
2021-07-05 16:09 ` Chao Yu
2021-07-05 18:06 ` Jaegeuk Kim
2021-07-06 0:16 ` Chao Yu
2021-07-05 18:04 ` Jaegeuk Kim
2021-07-05 18:45 ` Matthew Wilcox
2021-07-06 9:12 ` Mel Gorman
2021-07-07 0:48 ` Chao Yu
2021-07-07 9:57 ` Mel Gorman
2021-07-10 8:11 ` Chao Yu [this message]
2021-07-12 6:53 ` Michal Hocko
2021-07-13 0:46 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc0de0c2-a3b6-df91-5b90-524768a85d82@kernel.org \
--to=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).