From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH] clocksource/drivers: depend on sub-architecture for Exynos MCT and Samsung PWM
Date: Thu, 21 Oct 2021 14:07:45 +0200 [thread overview]
Message-ID: <fc0e9d34-72f6-0d95-fa4f-a25f5d8e5125@linaro.org> (raw)
In-Reply-To: <20211021063500.39314-1-krzysztof.kozlowski@canonical.com>
On 21/10/2021 08:35, Krzysztof Kozlowski wrote:
> The Exynos MCT and Samsung PWM Timer clocksource drivers are not usable
> on anything else than Samsung Exynos, S3C or S5P SoC platforms. These
> are integral parts of a SoC. Even though the drivers are not user
> selectable, still document the hardware architecture explicitly with
> depends on ARCH_EXYNOS and others. This also serves a purpose of
> documenting use-case, if someone ever wonders whether to select the
> driver for his platform. No functional change, because drivers are
> already selected by the platform described in depends. We follow similar
> approach also for other SoC-specific drivers.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
> drivers/clocksource/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index 0f5e3983951a..3ff6e1f87246 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -418,12 +418,14 @@ config ATMEL_TCB_CLKSRC
> config CLKSRC_EXYNOS_MCT
> bool "Exynos multi core timer driver" if COMPILE_TEST
> depends on ARM || ARM64
> + depends on ARCH_EXYNOS || COMPILE_TEST
> help
> Support for Multi Core Timer controller on Exynos SoCs.
>
> config CLKSRC_SAMSUNG_PWM
> bool "PWM timer driver for Samsung S3C, S5P" if COMPILE_TEST
> depends on HAS_IOMEM
> + depends on ARCH_EXYNOS || ARCH_S3C24XX || ARCH_S3C64XX || ARCH_S5PV210 || COMPILE_TEST
> help
> This is a new clocksource driver for the PWM timer found in
> Samsung S3C, S5P and Exynos SoCs, replacing an earlier driver
>
Applied, thanks
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2021-10-21 12:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 6:35 [PATCH] clocksource/drivers: depend on sub-architecture for Exynos MCT and Samsung PWM Krzysztof Kozlowski
2021-10-21 12:07 ` Daniel Lezcano [this message]
2021-10-24 15:39 ` [tip: timers/core] clocksource/drivers/exynosy: Depend " tip-bot2 for Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc0e9d34-72f6-0d95-fa4f-a25f5d8e5125@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).