From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760834AbcINHhi (ORCPT ); Wed, 14 Sep 2016 03:37:38 -0400 Received: from mail-by2nam03on0064.outbound.protection.outlook.com ([104.47.42.64]:12296 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1759565AbcINHhg (ORCPT ); Wed, 14 Sep 2016 03:37:36 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Christian.Koenig@amd.com; Subject: Re: [PATCH] drm/radeon/radeon_device: clean function declarations in radeon_device.c up To: Baoyou Xie , , References: <1473833457-1729-1-git-send-email-baoyou.xie@linaro.org> CC: , , , From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: Date: Wed, 14 Sep 2016 09:22:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1473833457-1729-1-git-send-email-baoyou.xie@linaro.org> Content-Type: text/plain; charset="iso-8859-15"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [2a02:908:1251:7981:cf5:cde0:25a3:46e7] X-ClientProxiedBy: AM3PR07CA0015.eurprd07.prod.outlook.com (10.141.45.143) To BN6PR12MB1298.namprd12.prod.outlook.com (10.168.227.148) X-MS-Office365-Filtering-Correlation-Id: e2675cb0-6317-492c-fb6f-08d3dc6fdd15 X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1298;2:0R9XgFew06Oaeabxlqf/1VQvo7dcK/Fim3VDC8pYjmLGYLZAgL4rszPjUq+nT2vrqgiBP2zX4zWpv9Q+oVpFj5pLgW7m7QBBGCWnQUiTQyFBAMHVu78RKpwHvC00TAjWutMgz3bBkbzYXTcz6s4w+kWslgpNsGzoxD/ZW577Rj4Z1jd0vOLSzJWj6n529NhE;3:yLDsBgIPL4qYSIxjcikA4TTtQCWwFIcSWZHfGD4eI5T3FMahLS+1mNENOBf5wHlHwDaEoOOgofFbTaspIxG8kuevUNOPb1N+E/fOSvuTLRwqt4KwXipJJwTHW9oxeGSZ X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN6PR12MB1298; X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1298;25:LtlHCVbL/G7RwnodXHAT0nJ9gcCrz8NrS2qHO2bm3XofgOr036TTfmVkwdD0Rr+gjgdz9698tXidKdbtIOujUd/9v3j2ODtAX2H/UmLSnJo7StrYgkWSV23/xN/FxrNqWmFhACmlqg9grua3Nw1mldwI0KBIK0BeLquVFRBfbhbBopMi5eXBl2WtVqdfq+GWTAZaRmGpYObEtDBY7aEi3GsWC7ibUYubJGsCgfTHvnlt0ITvqEdKa81cqnZf06FXoAXl08XkQUQUct7ddccT6e92SIKVjjvPJz3bcj32qtVaTuwYwSPY3QU/BCfamhyNPATE518V97zmXDAlGNTWMZQvnZ1xySbFifaXHUSLPdQm61VCAHS19noP7NP1BuRoiQ1eRZAMlWA4NIBGpd1SFS5XAb+CB8t9lYTs5mKPZ8ORBOUfz7ieHQrZxJfe2idcteLfX0DGWhZCF/aHAQ2oCokyPNwiTZSD+dUw35xJl2QbPxChuwa4A/J+8PJ0nqYGncFd5xeHtUUcgSDF1RKEW8RLTY9Q8fWNJmHHDBJK/LWTKKUoz6NYhDA3BJQKTNOdjYqtgqlVR16RhTW5Ke46YzY2pz53qZvO3kAzGB8ra99LsGEpdQncw8sjA/5vonDAMQ97bNX+eSJk1N30X/XNytrgt3rG68hakWWTCdawkikUFrEx/1NKkE8qxrhtt9WKCoFC9fmGBP65XfJp9je+Lk7vzzbX6hcDFP2CsD5+nt9Yg6aakZ0isKuT+qy+vCee X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1298;31:0vdyHudvaLGfMbyx+E68QHMojajhS3j8hAJRptY1vBioCSGDUx65GX380P8GUT11Efy7DYupDDstnN1RsrAWztyua5mWO/Qh83LXhMjNlcw9pbRGZNh5fThNIuc6zqOb/NnM3+wlNoYjrwher6DIItGEn8rgCTigTtsMg+A4QykBDrID1Slagh5UZimk2n/MhbvL8E39hDjtEUqkcCVesDcoHDTZOZHwVfnlR2D44no=;20:1LTLG60f5y1vhGoeDaZoAo1j09eDG3opH9nvaxwvchg+L8idQ7av86ah49mEk/t9P2JZ3jeBvqjW1xM898T9CE7E4/Qvq7Frp6YQWXQaBKeSmA0nJqi42maDOcjsTq+TFNXCQttS3tbODavB9JgBiO1svo+PvHqcKqo4nRTgYi0zniKYFh0/QHSpnpPVnfiCArkiqHFYAH7s7deg/ajIP+hgPluksNQu45U/dCtzvWxe2p/Jn0XXaxg6t0kUYGyUqL2zIbod93fe+IFWzfwShqJ2ueLZhMk5wkwBwwZBmRAaI5glmYwFFoh3UzEGP3PbwhlcVt6rcv6RUqwYYTS9Oy09481LSoeHjciDMU3ATqhSPlpIC7xeI3In4Im6An+zMi7GErldhRuVohXqJo1jh6b7XSotgVzIXqDcXlhdBO4EI02IZusK6Gs0syMtyTKEEz7TlUq1ZA140eAN5C60CPD04iDQWf0qFQvtrBDa+9k9FoRggd/YTBFu+ABUzptB X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026);SRVR:BN6PR12MB1298;BCL:0;PCL:0;RULEID:;SRVR:BN6PR12MB1298; X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1298;4:fahW0W1jMr8PXuFJltNsG3AVmO6cdnZhpYlUHnbcEsma4g/y05PGU4mEIrngaHuWRM8F3eh6nXdamk8rhg9NydYh/O8/xJ1DPzPIEmLtApQj6Oe5A9W1g1Fr0BYagTlHe70Wb1FtG/gKFWAwz68xus6+kT58NZ8kdUVqec3R4aYMqin63mhe4Wz8PhM4EOVDxgIbAXb9Sz2SUsN4qnKBzbogykDsopLaMLhgAXyqNj5o+j2zhbo4Cr1V5UdljHAkM6g+R8V/zwsg+m7FiZueaULoguUd4eOH6q1Jota43LG3rbEKBlIt8JLI3RvLlldB7NxRV+56lSefk+vgAGNmyY5thk4Rr786+KmqGbPU+IfRpuc9M0XyeplQEU7LsKRAOM4Wt2WPQwgwmBBi/2YMsQ== X-Forefront-PRVS: 006546F32A X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(189002)(199003)(575784001)(1706002)(586003)(305945005)(83506001)(36756003)(31696002)(230700001)(6116002)(7736002)(92566002)(65826007)(101416001)(68736007)(4001350100001)(106356001)(189998001)(4326007)(5001770100001)(5660300001)(2201001)(2906002)(97736004)(86362001)(64126003)(19580405001)(77096005)(65956001)(65806001)(7846002)(23756003)(76176999)(54356999)(50986999)(47776003)(2950100001)(19580395003)(50466002)(105586002)(8676002)(42186005)(33646002)(31686004)(81156014)(81166006)(3826002)(2101003);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR12MB1298;H:[IPv6:2a02:908:1251:7981:cf5:cde0:25a3:46e7];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?iso-8859-15?Q?1;BN6PR12MB1298;23:MjYcOl76W6+3A+rJoyA8NKVHgXGlwERWIXaga7?= =?iso-8859-15?Q?YEwDYnTFtTkPoJlcHkfX6hD+wRlf8wjY8/l7n+OUKMy+QXSs1EzSWYWKH?= =?iso-8859-15?Q?0gal6H7em1Lizrl+tmMnmH0GesfgGE08hQAdbQINT4HjzVn7o3WBnFD9D?= =?iso-8859-15?Q?lXI9hE3zbS9reK0ygQx89jYY/AEjBzvMrUPd04N49eWhkDXtXRGDA+wlU?= =?iso-8859-15?Q?WK/b8Vb4iU9Pzgu22PV2U3s8W6y1t6A82fRemRDL0ZI5eZV8xOBLbVjrF?= =?iso-8859-15?Q?XiJwVy+2G4juNZRyBO7UZGJE84gLlfwRw+ZwFK/bhQgIgQ1Fht/tEqu2V?= =?iso-8859-15?Q?k5OjHUPwnTeoKb+6xE3HUC4l3YgVjx7CE7Zi1VQXQfscj79nuq4AZ4BTc?= =?iso-8859-15?Q?LCCmB4NwE1C8706pC5WIkM3TnV0aNBKULwE8qs/0iaX4FQgs/55dLC3Cl?= =?iso-8859-15?Q?ZlHYmIGlFmKmQVK7yQbP0RmHmEasHtO/FwzAOtJ9+daqJyWE/j+1vRFBg?= =?iso-8859-15?Q?u+1SZd62mr0sS6hQzt5ZxVsVRfXCGNFG5wBgmjzjMh18JYmDoxNDkhX5g?= =?iso-8859-15?Q?7cFttj0IT7zSLXjMFvFvTEAbvuZMYyUv8pJH9bw0W07l9n9ZBKwHThDoI?= =?iso-8859-15?Q?LspF6Jm82b8JBFwglXqypaToVAdBRwdXP9opTB4D7QCF2udSEbqdd4yW8?= =?iso-8859-15?Q?ULbsS7tzOawMGWYVD9HU1padwtjLnPz2yAJ3J/l7olTRBih4ueH07RmbB?= =?iso-8859-15?Q?fEjhw+eqehnB4ORaeKOug7Zx4yEvwXGj37Ml+KMBnJcIKWV1UQpQmfUyt?= =?iso-8859-15?Q?HLtAdkYKf28MmXO8P/WadLlNzkUeKCXg7Olbbx4mzzEYwmutn9ovjGv7B?= =?iso-8859-15?Q?YXBP55smSjUOxMlo7S0k4MhZGA/n/CqYkEDOSIV3wR92dX5EuSh2IVLLD?= =?iso-8859-15?Q?3I6hcI2MtmEpWwwEe9VL9P0Yy5WzS91Gdyl/LXj7O7VfThpEBLwmNrFt9?= =?iso-8859-15?Q?qUyeg/zR7c29753wnwstj5KTHAkkaMwGh6dg9toEkFX7gRH9C5CA0yBi9?= =?iso-8859-15?Q?tAKZu4+MXfN2MJqsr14jgaIMR1y2Pe4XUr08S53nUKn1u0cB5kPS47Hc6?= =?iso-8859-15?Q?/+xTmIQIw5NdqzWDPowy/jpJn8r2eGnC1y7646fTXz0bTvzwOed/SGK53?= =?iso-8859-15?Q?963KOLP6Y8RLscAgSBl0/gukQd0Cqsh2Uk+5LYCtMKAsO+ent2cNCEPT9?= =?iso-8859-15?Q?h1Rs+J6uZFMA4kZd5Ir6RSczblAk7A+k0OJkXyj9Qi4xNhVaLpJPNU/xS?= =?iso-8859-15?Q?oSXDnCOWWt9Nvilq39MVp50Y4UrsPApTKmevpBLJr9FRuwNk9FcKTp8bP?= =?iso-8859-15?Q?HXTpPgvZLg=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1298;6:a6rrzsYO4OHo5t1+5G/1ZxIAEMe+KzyPS6fmRhORcjUp5X9+GAEqlcxoq4bjN4NMbBiYVA5SCev79bLaMsrzJWWs3SOzYyk6pqv8/ypFJrDivmMPJt+qkjeXusFSQnzPOeXD+j8V7FA9XJd+fZ4xG879OHscvoJTIO//OjKTpIlOwhclLyvmK1FhwCoV1CtIkzBzvA8cBsvHs8WoQW3q9iIKpDnM5Dm2G5ABfkqREcwFQboWfF9Q3YpOmphACE8icMxlaaWnr4OztlNXCxA6zuLba+xXQrCQNVZ6QJdfIZOakcko1Q/PEU+0ftE3HeL/bfuH5SIV0TLHIH/nLSFHdQ==;5:JmwOPcZNsvGdksJIZB6uYbYqVohQGoJJReeyzG8OZMM2fDqQAK3OLsJ5UTJhS4R+BiGMgp6NVVSsO2R+/qxXy6vH3RU5K1bIZJ5De+fY2M/4XKjlkKrA82FuhG/XWD7hEK/C7HvZRnTeaKqpWW/PVQ==;24:IqZG3PeEzcSHYJTOGB4YKhMjex8Bwer5YkQTxOvlBQELVjJjemOjtCQHFwZwXTwFGYMUMPURN0wT3RFuSzRvn/TgfcdaGl0Rz6DZt/wNHG0=;7:uxRwHxAvb1Q/Nso0xwOqRiYgdXP5OB4Ti8KVIke9rUHfU49ki4zzpEK5Cw5iOBkiPGQ9Guh4uavc2JgbMC4nGwzyseWzN9zzOEXxdR5q6sK5YlKuXUkhujn3uaxI4pUhhoq26ntUxT5Ytt0GZdSCLbaUMuugsB+7f9lUyiMWGed/+lDCyO4ob3QkuiSM/b7d3v9FFLnq9g2i4wFyMcNjynH5m31e5XCAq27OuAL/dE6l7DmZNIvERs5X/2qPpacb SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1298;20:FXJFzJzUW/VqwTuvJYG36Q3LAipOxLb1AnQ1K5TSYYSLfkR2DrDb+xg95s/w+AtwjnhI6+hjqNR1rIlr+nKOsf1MR1w3E46Ejcs2mZ55XJooTr6I1kdy3Dw723EEteejJ9CIHXM8JPlsIJAtmD6K9QBBZglw/1AssfB0WqCNMOaDYOmvD8/UwRPEn2Hu90wSdBGR4LQVI0QQg0fJocNrcyyJFftnAR/lrlfZKOLBZKS6Uzn7rhRCUoocwX5ZFldw X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2016 07:22:18.7518 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1298 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 14.09.2016 um 08:10 schrieb Baoyou Xie: > We get 2 warnings when building kernel with W=1: > drivers/gpu/drm/radeon/radeon_device.c:1961:5: warning: no previous prototype for 'radeon_debugfs_init' [-Wmissing-prototypes] > drivers/gpu/drm/radeon/radeon_device.c:1966:6: warning: no previous prototype for 'radeon_debugfs_cleanup' [-Wmissing-prototypes] > > In fact, both functions are declared in > drivers/gpu/drm/radeon/radeon_drv.c, but should be declared in > a header file, thus can be recognized in other file. > > So this patch moves the declarations into drivers/gpu/drm/radeon/radeon.h. > > Signed-off-by: Baoyou Xie Actually if I see it correctly we could also just remove the two callbacks cause they are optional and our implementations are just empty dummys. Christian. > --- > drivers/gpu/drm/radeon/radeon_device.c | 1 + > drivers/gpu/drm/radeon/radeon_drv.c | 5 ----- > drivers/gpu/drm/radeon/radeon_drv.h | 5 +++++ > 3 files changed, 6 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/radeon/radeon_device.c b/drivers/gpu/drm/radeon/radeon_device.c > index a00dd2f..811abde 100644 > --- a/drivers/gpu/drm/radeon/radeon_device.c > +++ b/drivers/gpu/drm/radeon/radeon_device.c > @@ -36,6 +36,7 @@ > #include > #include "radeon_reg.h" > #include "radeon.h" > +#include "radeon_drv.h" > #include "atom.h" > > static const char radeon_family_name[][16] = { > diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c > index 07e4493..6cc4a9e 100644 > --- a/drivers/gpu/drm/radeon/radeon_drv.c > +++ b/drivers/gpu/drm/radeon/radeon_drv.c > @@ -156,11 +156,6 @@ void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr); > extern long radeon_kms_compat_ioctl(struct file *filp, unsigned int cmd, > unsigned long arg); > > -#if defined(CONFIG_DEBUG_FS) > -int radeon_debugfs_init(struct drm_minor *minor); > -void radeon_debugfs_cleanup(struct drm_minor *minor); > -#endif > - > /* atpx handler */ > #if defined(CONFIG_VGA_SWITCHEROO) > void radeon_register_atpx_handler(void); > diff --git a/drivers/gpu/drm/radeon/radeon_drv.h b/drivers/gpu/drm/radeon/radeon_drv.h > index afef2d9..3d35e0e 100644 > --- a/drivers/gpu/drm/radeon/radeon_drv.h > +++ b/drivers/gpu/drm/radeon/radeon_drv.h > @@ -119,4 +119,9 @@ > long radeon_drm_ioctl(struct file *filp, > unsigned int cmd, unsigned long arg); > > +#if defined(CONFIG_DEBUG_FS) > +int radeon_debugfs_init(struct drm_minor *minor); > +void radeon_debugfs_cleanup(struct drm_minor *minor); > +#endif > + > #endif /* __RADEON_DRV_H__ */