From: Rex-BC Chen <rex-bc.chen@mediatek.com>
To: "CK Hu" <ck.hu@mediatek.com>,
"Guillaume Ranquet" <granquet@baylibre.com>,
"Chun-Kuang Hu" <chunkuang.hu@kernel.org>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Chunfeng Yun (云春峰)" <Chunfeng.Yun@mediatek.com>,
"Kishon Vijay Abraham I" <kishon@ti.com>,
"Vinod Koul" <vkoul@kernel.org>, "Helge Deller" <deller@gmx.de>,
"Jitao Shi (石记涛)" <jitao.shi@mediatek.com>
Cc: Markus Schneider-Pargmann <msp@baylibre.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>
Subject: Re: [PATCH v10 18/21] drm/mediatek: Add mt8195 Embedded DisplayPort driver
Date: Tue, 7 Jun 2022 20:46:31 +0800 [thread overview]
Message-ID: <fc37991f28247f593f0db668a2c1773e41ff9472.camel@mediatek.com> (raw)
In-Reply-To: <a93e5600ca3526651b728eceba51145b96d58037.camel@mediatek.com>
On Tue, 2022-06-07 at 15:30 +0800, CK Hu wrote:
> Hi, Rex:
>
> On Mon, 2022-05-23 at 12:47 +0200, Guillaume Ranquet wrote:
> > From: Markus Schneider-Pargmann <msp@baylibre.com>
> >
> > This patch adds a DisplayPort driver for the Mediatek mt8195 SoC.
> >
> > It supports the mt8195, the embedded DisplayPort units. It offers
> > DisplayPort 1.4 with up to 4 lanes.
> >
> > The driver creates a child device for the phy. The child device
> > will
> > never exist without the parent being active. As they are sharing a
> > register range, the parent passes a regmap pointer to the child so
> > that
> > both can work with the same register range. The phy driver sets
> > device
> > data that is read by the parent to get the phy device that can be
> > used
> > to control the phy properties.
> >
> > This driver is based on an initial version by
> > Jason-JH.Lin <jason-jh.lin@mediatek.com>.
> >
> > Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>
> > Signed-off-by: Guillaume Ranquet <granquet@baylibre.com>
> > ---
>
> [snip]
>
> > +
> > +static ssize_t mtk_dp_aux_transfer(struct drm_dp_aux *mtk_aux,
> > + struct drm_dp_aux_msg *msg)
> > +{
> > + struct mtk_dp *mtk_dp;
> > + bool is_read;
> > + u8 request;
> > + size_t accessed_bytes = 0;
> > + int ret = 0;
> > +
> > + mtk_dp = container_of(mtk_aux, struct mtk_dp, aux);
> > +
> > + if (!mtk_dp->train_info.cable_plugged_in ||
> > + mtk_dp->train_info.irq_status & MTK_DP_HPD_DISCONNECT) {
> > + mtk_dp->train_state = MTK_DP_TRAIN_STATE_CHECKCAP;
>
> Changing state here has no any effect, so drop this.
>
ok, I will drop it.
> > + return -EAGAIN;
> > + }
> > +
> > + switch (msg->request) {
> > + case DP_AUX_I2C_MOT:
> > + case DP_AUX_I2C_WRITE:
> > + case DP_AUX_NATIVE_WRITE:
> > + case DP_AUX_I2C_WRITE_STATUS_UPDATE:
> > + case DP_AUX_I2C_WRITE_STATUS_UPDATE | DP_AUX_I2C_MOT:
> > + request = msg->request &
> > ~DP_AUX_I2C_WRITE_STATUS_UPDATE;
> > + is_read = false;
> > + break;
> > + case DP_AUX_I2C_READ:
> > + case DP_AUX_NATIVE_READ:
> > + case DP_AUX_I2C_READ | DP_AUX_I2C_MOT:
> > + request = msg->request;
> > + is_read = true;
> > + break;
> > + default:
> > + drm_err(mtk_aux->drm_dev, "invalid aux cmd = %d\n",
> > + msg->request);
> > + return -EINVAL;
> > + }
> > +
> > + if (msg->size == 0) {
> > + ret = mtk_dp_aux_do_transfer(mtk_dp, is_read, request,
> > + msg->address +
> > accessed_bytes,
> > + msg->buffer +
> > accessed_bytes, 0);
> > + } else {
> > + while (accessed_bytes < msg->size) {
> > + size_t to_access =
> > + min_t(size_t, DP_AUX_MAX_PAYLOAD_BYTES,
> > + msg->size - accessed_bytes);
> > +
> > + ret = mtk_dp_aux_do_transfer(mtk_dp,
> > + is_read, request,
> > + msg->address +
> > accessed_bytes,
> > + msg->buffer +
> > accessed_bytes,
> > + to_access);
> > +
> > + if (ret) {
> > + drm_info(mtk_dp->drm_dev,
> > + "Failed to do AUX transfer:
> > %d\n", ret);
> > + break;
> > + }
> > + accessed_bytes += to_access;
> > + }
> > + }
> > +
> > + if (ret) {
> > + msg->reply = DP_AUX_NATIVE_REPLY_NACK |
> > DP_AUX_I2C_REPLY_NACK;
> > + return ret;
> > + }
> > +
> > + msg->reply = DP_AUX_NATIVE_REPLY_ACK | DP_AUX_I2C_REPLY_ACK;
> > + return msg->size;
> > +}
>
>
next prev parent reply other threads:[~2022-06-07 12:46 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-23 10:47 [PATCH v10 00/21] drm/mediatek: Add mt8195 DisplayPort driver Guillaume Ranquet
2022-05-23 10:47 ` [PATCH v10 01/21] dt-bindings: mediatek,dpi: Add DPINTF compatible Guillaume Ranquet
2022-05-23 12:33 ` Rob Herring
2022-05-24 3:29 ` Chunfeng Yun
2022-05-25 11:55 ` AngeloGioacchino Del Regno
2022-06-07 2:31 ` Rex-BC Chen
2022-05-25 12:49 ` Maxime Ripard
2022-06-07 2:35 ` Rex-BC Chen
2022-05-23 10:47 ` [PATCH v10 02/21] dt-bindings: mediatek,dp: Add Display Port binding Guillaume Ranquet
2022-05-24 3:35 ` Chunfeng Yun
2022-06-10 2:27 ` Rex-BC Chen
2022-05-25 15:30 ` AngeloGioacchino Del Regno
2022-06-10 2:29 ` Rex-BC Chen
2022-06-02 13:20 ` Rob Herring
2022-05-23 10:47 ` [PATCH v10 03/21] drm/edid: Convert cea_sad helper struct to kernelDoc Guillaume Ranquet
2022-05-23 10:57 ` Matthias Brugger
2022-06-07 2:44 ` Rex-BC Chen
2022-05-25 12:01 ` AngeloGioacchino Del Regno
2022-06-07 2:45 ` Rex-BC Chen
2022-05-23 10:47 ` [PATCH v10 04/21] drm/edid: Add cea_sad helpers for freq/length Guillaume Ranquet
2022-05-25 12:26 ` AngeloGioacchino Del Regno
2022-06-10 6:50 ` Rex-BC Chen
2022-05-23 10:47 ` [PATCH v10 05/21] video/hdmi: Add audio_infoframe packing for DP Guillaume Ranquet
2022-05-25 12:32 ` AngeloGioacchino Del Regno
2022-06-07 3:10 ` Rex-BC Chen
2022-05-23 10:47 ` [PATCH v10 06/21] drm/mediatek: dpi: move dpi limits to SoC config Guillaume Ranquet
2022-05-23 10:47 ` [PATCH v10 07/21] drm/mediatek: dpi: implement a CK/DE pol toggle in " Guillaume Ranquet
2022-05-30 7:44 ` CK Hu
2022-06-07 2:54 ` Rex-BC Chen
2022-05-23 10:47 ` [PATCH v10 08/21] drm/mediatek: dpi: implement a swap_input " Guillaume Ranquet
2022-05-30 7:50 ` CK Hu
2022-06-13 3:12 ` Rex-BC Chen
2022-05-23 10:47 ` [PATCH v10 09/21] drm/mediatek: dpi: move dimension mask to " Guillaume Ranquet
2022-05-30 7:55 ` CK Hu
2022-05-23 10:47 ` [PATCH v10 10/21] drm/mediatek: dpi: move hvsize_mask " Guillaume Ranquet
2022-05-30 8:21 ` CK Hu
2022-05-23 10:47 ` [PATCH v10 11/21] drm/mediatek: dpi: move swap_shift " Guillaume Ranquet
2022-05-30 8:38 ` CK Hu
2022-06-02 11:38 ` Rex-BC Chen
2022-06-02 12:19 ` Rex-BC Chen
2022-05-23 10:47 ` [PATCH v10 12/21] drm/mediatek: dpi: move the yuv422_en_bit " Guillaume Ranquet
2022-05-30 8:47 ` CK Hu
2022-05-23 10:47 ` [PATCH v10 13/21] drm/mediatek: dpi: move the csc_enable bit " Guillaume Ranquet
2022-05-23 10:47 ` [PATCH v10 14/21] drm/mediatek: dpi: Add dpintf support Guillaume Ranquet
2022-05-25 12:58 ` AngeloGioacchino Del Regno
2022-06-13 6:10 ` Rex-BC Chen
2022-06-02 5:48 ` Christophe JAILLET
2022-06-13 6:05 ` Rex-BC Chen
2022-05-23 10:47 ` [PATCH v10 15/21] drm/mediatek: dpi: Only enable dpi after the bridge is enabled Guillaume Ranquet
2022-05-23 10:47 ` [PATCH v10 16/21] drm/meditek: dpi: Add matrix_sel helper Guillaume Ranquet
2022-05-23 10:47 ` [PATCH v10 17/21] phy: phy-mtk-dp: Add driver for DP phy Guillaume Ranquet
2022-06-08 16:31 ` Vinod Koul
2022-05-23 10:47 ` [PATCH v10 18/21] drm/mediatek: Add mt8195 Embedded DisplayPort driver Guillaume Ranquet
2022-05-25 5:47 ` CK Hu
2022-05-30 9:34 ` CK Hu
2022-05-30 10:08 ` CK Hu
2022-06-07 6:21 ` CK Hu
2022-06-07 12:24 ` Rex-BC Chen
2022-06-08 2:23 ` CK Hu
2022-06-08 8:43 ` Rex-BC Chen
2022-06-08 9:15 ` CK Hu
2022-06-08 11:52 ` Rex-BC Chen
2022-06-07 6:44 ` CK Hu
2022-06-07 12:44 ` Rex-BC Chen
2022-06-08 2:44 ` CK Hu
2022-06-08 12:54 ` Rex-BC Chen
2022-06-07 7:30 ` CK Hu
2022-06-07 12:46 ` Rex-BC Chen [this message]
2022-06-07 7:47 ` CK Hu
2022-06-08 10:26 ` Rex-BC Chen
2022-06-09 2:30 ` CK Hu
2022-06-09 7:24 ` Rex-BC Chen
2022-06-07 8:01 ` CK Hu
2022-06-09 7:18 ` Rex-BC Chen
2022-06-07 8:12 ` CK Hu
2022-06-07 12:55 ` Rex-BC Chen
2022-06-07 9:04 ` CK Hu
2022-06-09 8:00 ` Rex-BC Chen
2022-06-08 8:30 ` CK Hu
2022-06-09 8:03 ` Rex-BC Chen
2022-06-08 8:45 ` CK Hu
2022-06-08 8:54 ` Rex-BC Chen
2022-06-09 9:37 ` CK Hu
2022-06-10 2:10 ` Rex-BC Chen
2022-05-23 10:47 ` [PATCH v10 19/21] drm/mediatek: Add mt8195 External DisplayPort support Guillaume Ranquet
2022-05-25 13:04 ` AngeloGioacchino Del Regno
2022-05-23 10:47 ` [PATCH v10 20/21] drm/mediatek: add hpd debounce Guillaume Ranquet
2022-05-23 10:47 ` [PATCH v10 21/21] drm/mediatek: DP audio support for mt8195 Guillaume Ranquet
2022-06-02 3:50 ` [PATCH v10 00/21] drm/mediatek: Add mt8195 DisplayPort driver Rex-BC Chen
2022-06-02 5:31 ` Rex-BC Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc37991f28247f593f0db668a2c1773e41ff9472.camel@mediatek.com \
--to=rex-bc.chen@mediatek.com \
--cc=Chunfeng.Yun@mediatek.com \
--cc=airlied@linux.ie \
--cc=chunkuang.hu@kernel.org \
--cc=ck.hu@mediatek.com \
--cc=daniel@ffwll.ch \
--cc=deller@gmx.de \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=granquet@baylibre.com \
--cc=jitao.shi@mediatek.com \
--cc=kishon@ti.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-phy@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=matthias.bgg@gmail.com \
--cc=mripard@kernel.org \
--cc=msp@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=tzimmermann@suse.de \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).