From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756129AbbKCX40 (ORCPT ); Tue, 3 Nov 2015 18:56:26 -0500 Received: from mta01.ornl.gov ([128.219.177.14]:56579 "EHLO mta01.ornl.gov" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752242AbbKCX4Z convert rfc822-to-8bit (ORCPT ); Tue, 3 Nov 2015 18:56:25 -0500 X-SG: RELAYLIST X-IronPort-AV: E=Sophos;i="5.20,240,1444708800"; d="scan'208";a="115327025" From: "Simmons, James A." To: "'Dan Carpenter'" CC: "'Greg Kroah-Hartman'" , James Simmons , "devel@driverdev.osuosl.org" , Oleg Drokin , "Linux Kernel Mailing List" , "lustre-devel@lists.lustre.org" Subject: RE: [lustre-devel] [PATCH 1/3] staging: lustre: checkpatch cleanups for nidstring.c Thread-Topic: [lustre-devel] [PATCH 1/3] staging: lustre: checkpatch cleanups for nidstring.c Thread-Index: AQHRFX2oUGws34Ec50uo7GdRnVMbT56K+ZKg Date: Tue, 3 Nov 2015 23:56:22 +0000 Message-ID: References: <1446161303-798-1-git-send-email-jsimmons@infradead.org> <1446161303-798-2-git-send-email-jsimmons@infradead.org> <20151030230148.GB2920@kroah.com> <229dae23c2f34950a21db4bd6dbdcfba@EXCHCS32.ornl.gov> <20151102144837.GG18797@mwanda> In-Reply-To: <20151102144837.GG18797@mwanda> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [128.219.12.132] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >Yeah. That is often the fastest way to fix all the checkpatch warnings. > >Checkpatch warnings are pretty mechanical. Just send like 100 patches >at a time until everything is fixed. Don't overthink. Say your patch >breaks the alignment then you have to fix that, but otherwise only fix >one thing at a time. Sometimes people will ask you to fix something >else on the same line, but just say "I didn't introduce that, but yes I >am planning to fix that in a later patchset since I am following the >one thing per patch rule." > >Don't feel shame about sending many small patches. We pretty much merge >everything. It was the sense of it taking forever with that amount of patches needed with the one file approach. Looking at the back log of fixes its not as bad as I thought for libcfs/LNet. Once those fixes are merged the style cleanups can happen pretty quickly.