From: Neil Armstrong <narmstrong@baylibre.com>
To: Christian Hewitt <christianshewitt@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Kevin Hilman <khilman@baylibre.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: Dongjin Kim <tobetter@hardkernel.com>
Subject: Re: [PATCH 3/3] arm64: dts: meson: add support for the ODROID-N2+
Date: Tue, 21 Jul 2020 10:19:16 +0200 [thread overview]
Message-ID: <fc679db1-be92-c384-0fe2-3b06c920ea75@baylibre.com> (raw)
In-Reply-To: <90da2697-9dcc-1d75-eded-bf4bdc4b594b@baylibre.com>
On 21/07/2020 10:10, Neil Armstrong wrote:
> On 19/07/2020 16:10, Christian Hewitt wrote:
>> HardKernel ODROID-N2+ uses an Amlogic S922X rev. C chip capable of higher
>> clock speeds than the original ODROID-N2. Hardkernel supports the big cpu
>> cluster at 2.4GHz and the little cpu cluster at 2.0GHz. Opp points and
>> regulator changess are from the HardKernel Linux kernel sources.
>>
>> Suggested-by: Dongjin Kim <tobetter@hardkernel.com>
>> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
>> ---
>> arch/arm64/boot/dts/amlogic/Makefile | 1 +
>> .../dts/amlogic/meson-g12b-odroid-n2-plus.dts | 53 +++++++++++++++++++
>> 2 files changed, 54 insertions(+)
>> create mode 100644 arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2-plus.dts
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile
>> index 5cac4d1d487d..6dc508b80133 100644
>> --- a/arch/arm64/boot/dts/amlogic/Makefile
>> +++ b/arch/arm64/boot/dts/amlogic/Makefile
>> @@ -8,6 +8,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-g12b-gtking-pro.dtb
>> dtb-$(CONFIG_ARCH_MESON) += meson-g12b-a311d-khadas-vim3.dtb
>> dtb-$(CONFIG_ARCH_MESON) += meson-g12b-s922x-khadas-vim3.dtb
>> dtb-$(CONFIG_ARCH_MESON) += meson-g12b-odroid-n2.dtb
>> +dtb-$(CONFIG_ARCH_MESON) += meson-g12b-odroid-n2-plus.dtb
>> dtb-$(CONFIG_ARCH_MESON) += meson-g12b-ugoos-am6.dtb
>> dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-kii-pro.dtb
>> dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-nanopi-k2.dtb
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2-plus.dts b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2-plus.dts
>> new file mode 100644
>> index 000000000000..99e96be509f8
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2-plus.dts
>> @@ -0,0 +1,53 @@
>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>> +/*
>> + * Copyright (c) 2019 BayLibre, SAS
>> + * Author: Neil Armstrong <narmstrong@baylibre.com>
>> + */
>> +
>> +/dts-v1/;
>> +
>> +#include "meson-g12b-odroid-n2.dtsi"
>> +
>> +/ {
>> + compatible = "hardkernel,odroid-n2-plus", "amlogic,s922x", "amlogic,g12b";
>> + model = "Hardkernel ODROID-N2+";
>> +
>> + vddcpu_a: regulator-vddcpu-a {
>> + regulator-min-microvolt = <680000>;
>> + regulator-max-microvolt = <1040000>;
>> +
>> + pwms = <&pwm_ab 0 1500 0>;
>> + };
>> +
>> + vddcpu_b: regulator-vddcpu-b {
>> + regulator-min-microvolt = <680000>;
>> + regulator-max-microvolt = <1040000>;
>> +
>> + pwms = <&pwm_AO_cd 1 1500 0>;
>> + };
>> +
>> + cpu_opp_table_0: opp-table-0 {
>> + opp-1908000000 {
>> + opp-hz = /bits/ 64 <1908000000>;
>> + opp-microvolt = <1030000>;
>> + };
>> +
>> + opp-2016000000 {
>> + opp-hz = /bits/ 64 <2016000000>;
>> + opp-microvolt = <1040000>;
>> + };
>> + };
>> +
>> + cpub_opp_table_1: opp-table-1 {
>> + opp-2304000000 {
>> + opp-hz = /bits/ 64 <2304000000>;
>> + opp-microvolt = <1030000>;
>> + };
>> +
>> + opp-2400000000 {
>> + opp-hz = /bits/ 64 <2400000000>;
>> + opp-microvolt = <1040000>;
>> + };
>> + };
>> +};
>> +
>>
> Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
>
Wait no, it should be:
/ {
compatible = "hardkernel,odroid-n2-plus", "amlogic,s922x", "amlogic,g12b";
model = "Hardkernel ODROID-N2+";
};
&vddcpu_a {
regulator-min-microvolt = <680000>;
regulator-max-microvolt = <1040000>;
pwms = <&pwm_ab 0 1500 0>;
};
&vddcpu_b {
regulator-min-microvolt = <680000>;
regulator-max-microvolt = <1040000>;
pwms = <&pwm_AO_cd 1 1500 0>;
};
&cpu_opp_table_0 {
opp-1908000000 {
opp-hz = /bits/ 64 <1908000000>;
opp-microvolt = <1030000>;
};
opp-2016000000 {
opp-hz = /bits/ 64 <2016000000>;
opp-microvolt = <1040000>;
};
};
&cpub_opp_table_1 {
opp-2304000000 {
opp-hz = /bits/ 64 <2304000000>;
opp-microvolt = <1030000>;
};
opp-2400000000 {
opp-hz = /bits/ 64 <2400000000>;
opp-microvolt = <1040000>;
};
};
Neil
next prev parent reply other threads:[~2020-07-21 8:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-19 14:10 [PATCH 0/3] arm64: dts: meson: add support for ODROID-N2+ Christian Hewitt
2020-07-19 14:10 ` [PATCH 1/3] arm64: dts: meson: convert ODROID-N2 to dtsi Christian Hewitt
2020-07-21 8:06 ` Neil Armstrong
2020-07-19 14:10 ` [PATCH 2/3] dt-bindings: arm: amlogic: add support for the ODROID-N2+ Christian Hewitt
2020-07-23 21:10 ` Rob Herring
2020-07-19 14:10 ` [PATCH 3/3] arm64: dts: meson: " Christian Hewitt
2020-07-21 8:10 ` Neil Armstrong
2020-07-21 8:19 ` Neil Armstrong [this message]
2020-07-21 9:24 ` Dongjin Kim
2020-07-21 9:58 ` Christian Hewitt
2020-07-21 9:14 ` Jerome Brunet
2020-07-21 11:07 ` Christian Hewitt
2020-07-22 23:03 ` Stefan Agner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc679db1-be92-c384-0fe2-3b06c920ea75@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=christianshewitt@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=tobetter@hardkernel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).