From: Hongbo Yao <yaohongbo@huawei.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <chenzhou10@huawei.com>, <davem@davemloft.net>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] drivers/net: netdevsim depends on INET
Date: Thu, 16 Jan 2020 21:13:28 +0800 [thread overview]
Message-ID: <fc6c7d33-479d-6cb6-3126-dc215789d6f3@huawei.com> (raw)
In-Reply-To: <20200116050506.18c2cce3@cakuba.hsd1.ca.comcast.net>
On 2020/1/16 21:05, Jakub Kicinski wrote:
> On Thu, 16 Jan 2020 20:52:19 +0800, Hongbo Yao wrote:
>> If CONFIG_INET is not set and CONFIG_NETDEVSIM=y.
>> Building drivers/net/netdevsim/fib.o will get the following error:
>>
>> drivers/net/netdevsim/fib.o: In function `nsim_fib4_rt_hw_flags_set':
>> fib.c:(.text+0x12b): undefined reference to `fib_alias_hw_flags_set'
>> drivers/net/netdevsim/fib.o: In function `nsim_fib4_rt_destroy':
>> fib.c:(.text+0xb11): undefined reference to `free_fib_info'
>>
>> Correct the Kconfig for netdevsim.
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Fixes: 83c9e13aa39ae("netdevsim: add software driver for testing
>> offloads")
>
> Please provide a _correct_ Fixes tag, and don't line wrap it.
> The commit you're pointing to doesn't use any of the fib functions
> so how can it be to blame?
Thank you for catching my mistake.
I'll resend it.
Best regards,
Hongbo.
>> Signed-off-by: Hongbo Yao <yaohongbo@huawei.com>
>> ---
>> drivers/net/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
>> index 77ee9afad038..25a8f9387d5a 100644
>> --- a/drivers/net/Kconfig
>> +++ b/drivers/net/Kconfig
>> @@ -549,6 +549,7 @@ source "drivers/net/hyperv/Kconfig"
>> config NETDEVSIM
>> tristate "Simulated networking device"
>> depends on DEBUG_FS
>> + depends on INET
>> depends on IPV6 || IPV6=n
>> select NET_DEVLINK
>> help
>
>
> .
>
prev parent reply other threads:[~2020-01-16 13:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 12:52 [PATCH -next] drivers/net: netdevsim depends on INET Hongbo Yao
2020-01-16 13:05 ` Jakub Kicinski
2020-01-16 13:13 ` Hongbo Yao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc6c7d33-479d-6cb6-3126-dc215789d6f3@huawei.com \
--to=yaohongbo@huawei.com \
--cc=chenzhou10@huawei.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).