From: Joe Perches <joe@perches.com>
To: Tamir Suliman <tsuliman@linuxvaults.com>,
thomas.petazzoni@free-electrons.com
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
devel@driverdev.osuosl.org
Subject: Re: [PATCH 1/2] FBTFT: fb_sh: Fix alignment and style problems Fixed Coding style issues Signed-off-by: Tamir Suliman <tsuliman@linuxvaults.com>
Date: Sat, 30 Jun 2018 09:20:27 -0700 [thread overview]
Message-ID: <fc7149540b1e70e82adb0f2698da78ed65e45ffb.camel@perches.com> (raw)
In-Reply-To: <1530369159-23872-1-git-send-email-tsuliman@linuxvaults.com>
On Sat, 2018-06-30 at 14:32 +0000, Tamir Suliman wrote:
> ---
> drivers/staging/fbtft/fb_sh1106.c | 26 +++++++++++++-------------
> 1 file changed, 13 insertions(+), 13 deletions(-)
Adding to what Greg's patchbot already wrote:
> diff --git a/drivers/staging/fbtft/fb_sh1106.c b/drivers/staging/fbtft/fb_sh1106.c
[]
> @@ -36,27 +36,27 @@ static int init_display(struct fbtft_par *par)
> par->fbtftops.reset(par);
>
> /* Set Display OFF */
> - write_reg(par, 0xAE);
> + write_reg(par, 0xAE);
Nope.
You are overly indenting already correctly indented code.
Statements start in the same column unless following an
if/for/do/while/else/case.
> @@ -89,8 +89,8 @@ static void set_addr_win(struct fbtft_par *par, int xs, int ys, int xe, int ye)
>
> static int blank(struct fbtft_par *par, bool on)
> {
> - fbtft_par_dbg(DEBUG_BLANK, par, "%s(blank=%s)\n",
> - __func__, on ? "true" : "false");
> + fbtft_par_dbg(DEBUG_BLANK, par, "%s(_func_=%s)\n",
> + __func__, on ? "true" : "false");
Again, nope.
Here you are misaligning a multi-line continuation
which is correctly aligned to the open parenthesis.
next prev parent reply other threads:[~2018-06-30 16:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-30 14:32 [PATCH 1/2] FBTFT: fb_sh: Fix alignment and style problems Fixed Coding style issues Signed-off-by: Tamir Suliman <tsuliman@linuxvaults.com> Tamir Suliman
2018-06-30 16:09 ` Greg KH
2018-06-30 16:20 ` Joe Perches [this message]
2018-07-04 19:58 ` Tamir Suliman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc7149540b1e70e82adb0f2698da78ed65e45ffb.camel@perches.com \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas.petazzoni@free-electrons.com \
--cc=tsuliman@linuxvaults.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).