linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: <Eugen.Hristev@microchip.com>
To: <peda@axentia.se>, <wsa@the-dreams.de>, <mark.rutland@arm.com>,
	<Ludovic.Desroches@microchip.com>, <linux-i2c@vger.kernel.org>,
	<devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <pierre-yves.mordret@st.com>,
	<alexandre.belloni@bootlin.com>, <robh+dt@kernel.org>
Subject: Re: [PATCH v4 1/9] dt-bindings: i2c: at91: add new compatible
Date: Mon, 2 Sep 2019 14:12:12 +0000	[thread overview]
Message-ID: <fc80aaff-fbb2-4a85-88e5-6a204cb9088f@microchip.com> (raw)
In-Reply-To: <47d618da-263f-199c-3cc6-35e8f8c6015d@axentia.se>



On 02.09.2019 13:44, Peter Rosin wrote:

> 
> On 2019-09-02 12:11, Eugen.Hristev@microchip.com wrote:
>> From: Eugen Hristev <eugen.hristev@microchip.com>
>>
>> Add compatible for new Microchip SoC, sam9x60
>>
>> Reviewed-by: Rob Herring <robh@kernel.org>
>> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
>> ---
>>   Documentation/devicetree/bindings/i2c/i2c-at91.txt | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/i2c/i2c-at91.txt b/Documentation/devicetree/bindings/i2c/i2c-at91.txt
>> index b7cec17..2210f43 100644
>> --- a/Documentation/devicetree/bindings/i2c/i2c-at91.txt
>> +++ b/Documentation/devicetree/bindings/i2c/i2c-at91.txt
>> @@ -3,7 +3,8 @@ I2C for Atmel platforms
>>   Required properties :
>>   - compatible : Must be "atmel,at91rm9200-i2c", "atmel,at91sam9261-i2c",
>>        "atmel,at91sam9260-i2c", "atmel,at91sam9g20-i2c", "atmel,at91sam9g10-i2c",
>> -     "atmel,at91sam9x5-i2c", "atmel,sama5d4-i2c" or "atmel,sama5d2-i2c"
>> +     "atmel,at91sam9x5-i2c", "atmel,sama5d4-i2c", "atmel,sama5d2-i2c" or
>> +     "microchip,sam9x60-i2c"
> 
> IIUC, this list should ideally be reformatted with one compatible per line.
> 
> Side note; unfortunate naming with SAM9x60, when there is a preexisting 9260
> fitting the "wildcard" (AFAICT, it's not a wildcard in this case, but it sure
> looks like one).
> 

Yes, this is a separate SoC. It is named SAM9X60 and not related to old 
9260

Reformatting the list would be useful perhaps in a different cosmetic 
patch ?

> Cheers,
> Peter
> 
>>   - reg: physical base address of the controller and length of memory mapped
>>        region.
>>   - interrupts: interrupt number to the cpu.
>>
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 
> 

  reply	other threads:[~2019-09-02 14:12 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-02 10:11 [PATCH v4 0/9] i2c: add support for filters Eugen.Hristev
2019-09-02 10:11 ` [PATCH v4 1/9] dt-bindings: i2c: at91: add new compatible Eugen.Hristev
2019-09-02 10:44   ` Peter Rosin
2019-09-02 14:12     ` Eugen.Hristev [this message]
2019-09-02 10:12 ` [PATCH v4 2/9] dt-bindings: i2c: add bindings for i2c analog and digital filter Eugen.Hristev
2019-09-02 10:49   ` Peter Rosin
2019-09-02 14:15     ` Eugen.Hristev
2019-09-02 14:22       ` Alexandre Belloni
2019-09-02 14:40       ` Peter Rosin
2019-09-02 15:47       ` Wolfram Sang
2019-09-02 10:12 ` [PATCH v4 3/9] i2c: add support for filter-width-ns optional property Eugen.Hristev
2019-09-02 10:12 ` [PATCH v4 4/9] i2c: at91: add new platform support for sam9x60 Eugen.Hristev
2019-09-02 10:12 ` [PATCH v4 5/9] i2c: at91: add support for digital filtering Eugen.Hristev
2019-09-02 10:12 ` [PATCH v4 6/9] i2c: at91: add support for advanced " Eugen.Hristev
2019-09-02 10:12 ` [PATCH v4 7/9] i2c: at91: add support for analog filtering Eugen.Hristev
2019-09-02 10:12 ` [PATCH v4 8/9] ARM: dts: at91: sama5d2_xplained: add analog and digital filter for i2c Eugen.Hristev
2019-09-02 10:12 ` [PATCH v4 9/9] ARM: dts: at91: sama5d4_xplained: add " Eugen.Hristev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fc80aaff-fbb2-4a85-88e5-6a204cb9088f@microchip.com \
    --to=eugen.hristev@microchip.com \
    --cc=Ludovic.Desroches@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=peda@axentia.se \
    --cc=pierre-yves.mordret@st.com \
    --cc=robh+dt@kernel.org \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).