From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Adam Borowski <kilobyte@angband.pl>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Arnd Bergmann <arnd@arndb.de>,
Nicholas Piggin <npiggin@gmail.com>,
Peter Wu <peter@lekensteyn.nl>,
Vince Weaver <vincent.weaver@maine.edu>,
Michal Marek <mmarek@suse.com>, Al Viro <viro@zeniv.linux.org.uk>,
linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
linux-arch@vger.kernel.org, regressions@leemhuis.info
Subject: Re: [PATCH reworded] x86/kbuild: enable modversions for symbols exported from asm
Date: Mon, 21 Nov 2016 17:49:41 +0100 [thread overview]
Message-ID: <fc83bd60-3298-7001-92ed-972b77ca8ea3@hartkopp.net> (raw)
In-Reply-To: <20161121145220.10430-1-kilobyte@angband.pl>
On 11/21/2016 03:52 PM, Adam Borowski wrote:
> Commit 4efca4ed ("kbuild: modversions for EXPORT_SYMBOL() for asm") adds
> modversion support for symbols exported from asm files. Architectures
> must include C-style declarations for those symbols in asm/asm-prototypes.h
> in order for them to be versioned.
>
> Add these declarations for x86, and an architecture-independent file that
> can be used for common symbols.
>
> User impact: kernels may fail to load modules at all when
> CONFIG_MODVERSIONS=y.
late but great :-)
Thanks for fixing this!
Tested-by: Oliver Hartkopp <socketcan@hartkopp.net>
(if you like)
Regards,
Oliver
>
> Signed-off-by: Adam Borowski <kilobyte@angband.pl>
> Tested-by: Kalle Valo <kvalo@codeaurora.org>
> Acked-by: Nicholas Piggin <npiggin@gmail.com>
> Tested-by: Peter Wu <oeter@lekensteyn.nl>
> ---
> arch/x86/include/asm/asm-prototypes.h | 12 ++++++++++++
> include/asm-generic/asm-prototypes.h | 7 +++++++
> 2 files changed, 19 insertions(+)
> create mode 100644 arch/x86/include/asm/asm-prototypes.h
> create mode 100644 include/asm-generic/asm-prototypes.h
>
> diff --git a/arch/x86/include/asm/asm-prototypes.h b/arch/x86/include/asm/asm-prototypes.h
> new file mode 100644
> index 0000000..ae87224
> --- /dev/null
> +++ b/arch/x86/include/asm/asm-prototypes.h
> @@ -0,0 +1,12 @@
> +#include <asm/ftrace.h>
> +#include <asm/uaccess.h>
> +#include <asm/string.h>
> +#include <asm/page.h>
> +#include <asm/checksum.h>
> +
> +#include <asm-generic/asm-prototypes.h>
> +
> +#include <asm/page.h>
> +#include <asm/pgtable.h>
> +#include <asm/special_insns.h>
> +#include <asm/preempt.h>
> diff --git a/include/asm-generic/asm-prototypes.h b/include/asm-generic/asm-prototypes.h
> new file mode 100644
> index 0000000..df13637
> --- /dev/null
> +++ b/include/asm-generic/asm-prototypes.h
> @@ -0,0 +1,7 @@
> +#include <linux/bitops.h>
> +extern void *__memset(void *, int, __kernel_size_t);
> +extern void *__memcpy(void *, const void *, __kernel_size_t);
> +extern void *__memmove(void *, const void *, __kernel_size_t);
> +extern void *memset(void *, int, __kernel_size_t);
> +extern void *memcpy(void *, const void *, __kernel_size_t);
> +extern void *memmove(void *, const void *, __kernel_size_t);
>
prev parent reply other threads:[~2016-11-21 16:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-21 16:23 'kbuild' merge before 4.9-rc1 breaks build and boot Oliver Hartkopp
2016-10-24 5:21 ` Oliver Hartkopp
2016-10-27 15:42 ` Peter Wu
2016-11-07 19:10 ` Vince Weaver
2016-11-07 21:39 ` Peter Wu
2016-11-08 1:33 ` Nicholas Piggin
2016-11-20 18:26 ` Peter Wu
2016-11-21 5:49 ` Nicholas Piggin
2016-11-21 6:39 ` [PATCH resend] kbuild: provide include/asm/asm-prototypes.h for x86 Adam Borowski
2016-11-21 7:27 ` Nicholas Piggin
2016-11-21 8:00 ` Peter Wu
2016-11-21 14:52 ` [PATCH reworded] x86/kbuild: enable modversions for symbols exported from asm Adam Borowski
2016-11-21 15:04 ` Peter Wu
2016-11-21 16:49 ` Oliver Hartkopp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc83bd60-3298-7001-92ed-972b77ca8ea3@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=arnd@arndb.de \
--cc=hpa@zytor.com \
--cc=kilobyte@angband.pl \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mmarek@suse.com \
--cc=npiggin@gmail.com \
--cc=peter@lekensteyn.nl \
--cc=regressions@leemhuis.info \
--cc=tglx@linutronix.de \
--cc=vincent.weaver@maine.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).