From: Paolo Bonzini <pbonzini@redhat.com>
To: Hamza Mahfooz <someguy@effective-light.com>,
linux-kernel@vger.kernel.org
Cc: Peter Xu <peterx@redhat.com>,
Sean Christopherson <seanjc@google.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
kvm@vger.kernel.org
Subject: Re: [PATCH v2] KVM: const-ify all relevant uses of struct kvm_memory_slot
Date: Mon, 2 Aug 2021 15:40:08 +0200 [thread overview]
Message-ID: <fcab24b9-0573-9165-20e9-683586e86bdf@redhat.com> (raw)
In-Reply-To: <20210730222704.61672-1-someguy@effective-light.com>
On 31/07/21 00:27, Hamza Mahfooz wrote:
> @@ -1440,7 +1440,7 @@ static bool kvm_set_pte_rmapp(struct kvm *kvm, struct kvm_rmap_head *rmap_head,
>
> struct slot_rmap_walk_iterator {
> /* input fields. */
> - struct kvm_memory_slot *slot;
> + const struct kvm_memory_slot *slot;
> gfn_t start_gfn;
> gfn_t end_gfn;
> int start_level;
> @@ -1467,16 +1467,20 @@ rmap_walk_init_level(struct slot_rmap_walk_iterator *iterator, int level)
>
> static void
> slot_rmap_walk_init(struct slot_rmap_walk_iterator *iterator,
> - struct kvm_memory_slot *slot, int start_level,
> + const struct kvm_memory_slot *slot, int start_level,
> int end_level, gfn_t start_gfn, gfn_t end_gfn)
> {
> - iterator->slot = slot;
> - iterator->start_level = start_level;
> - iterator->end_level = end_level;
> - iterator->start_gfn = start_gfn;
> - iterator->end_gfn = end_gfn;
> + struct slot_rmap_walk_iterator iter = {
> + .slot = slot,
> + .start_gfn = start_gfn,
> + .end_gfn = end_gfn,
> + .start_level = start_level,
> + .end_level = end_level
> + };
> +
> + rmap_walk_init_level(&iter, start_level);
>
> - rmap_walk_init_level(iterator, iterator->start_level);
> + memcpy(iterator, &iter, sizeof(struct slot_rmap_walk_iterator));
> }
>
> static bool slot_rmap_walk_okay(struct slot_rmap_walk_iterator *iterator)
I don't understand, just changing the argument works. There is no need
to change the body of the function.
Paolo
prev parent reply other threads:[~2021-08-02 13:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-30 22:27 [PATCH v2] KVM: const-ify all relevant uses of struct kvm_memory_slot Hamza Mahfooz
2021-08-02 13:40 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcab24b9-0573-9165-20e9-683586e86bdf@redhat.com \
--to=pbonzini@redhat.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterx@redhat.com \
--cc=seanjc@google.com \
--cc=someguy@effective-light.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).