From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5F89C43216 for ; Mon, 2 Aug 2021 13:40:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AFC4460FA0 for ; Mon, 2 Aug 2021 13:40:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234053AbhHBNkY (ORCPT ); Mon, 2 Aug 2021 09:40:24 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:35968 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233973AbhHBNkX (ORCPT ); Mon, 2 Aug 2021 09:40:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627911613; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WKwQt8hS8BrVUXgi476JAPrD0widSfYwWzVDlE+fv9w=; b=SN/powEelJP4C9d/6KHkkeRZBjt9siO20hZLvxqcK2pfFAv51cu/XK0eT/KzbJCqn86UW4 AhZ4i4ISxX0/dD6e1Yr3Hh1PO7r/7RfYV08AXQEHL0SrAOh65MnV9LgCcVo+tcZEdEaPY4 yVqEpzwbL4ueyxSvaupl0FhBQ+518Oc= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-239-U5WsKXAROyur4V-jCi-h3Q-1; Mon, 02 Aug 2021 09:40:12 -0400 X-MC-Unique: U5WsKXAROyur4V-jCi-h3Q-1 Received: by mail-ej1-f69.google.com with SMTP id n9-20020a1709063789b02905854bda39fcso4699956ejc.1 for ; Mon, 02 Aug 2021 06:40:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=WKwQt8hS8BrVUXgi476JAPrD0widSfYwWzVDlE+fv9w=; b=AS/8uQ75sKj+TZNHNT88etLAgjfzdOCTJwIAy8ypr3mmhvmuueFkHulRXpmQgaGB1v kXOZV/QCD0S5D4bBzygDg950yuqjl9S56Zb2XjTNM6xfhP1WqKSOOLudSlhN28yNshPF 0yhQ6+TDxijwtEIR0poCH/pd6Fg/NUE91KCETdxVnH82E0m0NcUIZurTwUD68KZUNJ7o InaBudzDjpqLOQKIg+tJ2FEVkVJgU52b7gtxPY4lNF3alJkF8HFdqcE/SKoPb9JdmJQR L3WMRKWRsI00Fq+BpuW4WHb2sDJ3hpLq/nduHXF6M9RTr9iQsN0VAUQC5e2wasNNWvEC gXZA== X-Gm-Message-State: AOAM5328yVwS+HvG9FlP+B1628wI3/kIFdypNJbYwMvB7gDyYGGMOvpG LyIufcnXw1itS5AfXz4ZsGAyDDZ5spceipBN/NUBWcrT1IfP2BryzaM1Hpv3qyQ7ZHjGtoR1vL/ L75nknR4PJLuh8dvNBVUxS1kl X-Received: by 2002:a05:6402:1a3a:: with SMTP id be26mr19172049edb.232.1627911611267; Mon, 02 Aug 2021 06:40:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzUWEzOJJD/hxS92H0wTVDl/3c+XTETCnw/2v3cRopIXxvPQkBYzXV1oByaHJLt1XJdso7X1Q== X-Received: by 2002:a05:6402:1a3a:: with SMTP id be26mr19172028edb.232.1627911611022; Mon, 02 Aug 2021 06:40:11 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id x42sm6170929edy.86.2021.08.02.06.40.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Aug 2021 06:40:10 -0700 (PDT) Subject: Re: [PATCH v2] KVM: const-ify all relevant uses of struct kvm_memory_slot To: Hamza Mahfooz , linux-kernel@vger.kernel.org Cc: Peter Xu , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , kvm@vger.kernel.org References: <20210730222704.61672-1-someguy@effective-light.com> From: Paolo Bonzini Message-ID: Date: Mon, 2 Aug 2021 15:40:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210730222704.61672-1-someguy@effective-light.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 31/07/21 00:27, Hamza Mahfooz wrote: > @@ -1440,7 +1440,7 @@ static bool kvm_set_pte_rmapp(struct kvm *kvm, struct kvm_rmap_head *rmap_head, > > struct slot_rmap_walk_iterator { > /* input fields. */ > - struct kvm_memory_slot *slot; > + const struct kvm_memory_slot *slot; > gfn_t start_gfn; > gfn_t end_gfn; > int start_level; > @@ -1467,16 +1467,20 @@ rmap_walk_init_level(struct slot_rmap_walk_iterator *iterator, int level) > > static void > slot_rmap_walk_init(struct slot_rmap_walk_iterator *iterator, > - struct kvm_memory_slot *slot, int start_level, > + const struct kvm_memory_slot *slot, int start_level, > int end_level, gfn_t start_gfn, gfn_t end_gfn) > { > - iterator->slot = slot; > - iterator->start_level = start_level; > - iterator->end_level = end_level; > - iterator->start_gfn = start_gfn; > - iterator->end_gfn = end_gfn; > + struct slot_rmap_walk_iterator iter = { > + .slot = slot, > + .start_gfn = start_gfn, > + .end_gfn = end_gfn, > + .start_level = start_level, > + .end_level = end_level > + }; > + > + rmap_walk_init_level(&iter, start_level); > > - rmap_walk_init_level(iterator, iterator->start_level); > + memcpy(iterator, &iter, sizeof(struct slot_rmap_walk_iterator)); > } > > static bool slot_rmap_walk_okay(struct slot_rmap_walk_iterator *iterator) I don't understand, just changing the argument works. There is no need to change the body of the function. Paolo