From: Wenjia Zhang <wenjia@linux.ibm.com>
To: Guangguan Wang <guangguan.wang@linux.alibaba.com>
Cc: davem@davemloft.net, Karsten Graul <kgraul@linux.ibm.com>,
liuyacan@corp.netease.com, kuba@kernel.org,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
netdev@vger.kernel.org, pabeni@redhat.com
Subject: Re: [PATCH net-next v2] net/smc: align the connect behaviour with TCP
Date: Thu, 30 Jun 2022 22:16:14 +0200 [thread overview]
Message-ID: <fcac3b0c-db51-7221-d41a-0207144f131c@linux.ibm.com> (raw)
In-Reply-To: <d2195919-1cae-b667-c137-8398848fa43b@linux.alibaba.com>
On 30.06.22 16:29, Guangguan Wang wrote:
> I'm so sorry I missed the last emails for this discussion.
>
> Yes, commit (86434744) is the trigger of the problem described in
> https://lore.kernel.org/linux-s390/45a19f8b-1b64-3459-c28c-aebab4fd8f1e@linux.alibaba.com/#t .
>
> And I have tested just remove the following lines from smc_connection() can solve the above problem.
> if (smc->use_fallback)
> goto out;
>
> I aggree that partly reverting the commit (86434744) is a better solution.
>
> Thanks,
> Guangguan Wang
Thank you for your effort!
Would you like to revert this patch? We'll revert the commit (86434744)
partly.
next prev parent reply other threads:[~2022-06-30 20:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-13 2:24 [PATCH net-next v2] net/smc: align the connect behaviour with TCP Guangguan Wang
2022-05-16 9:50 ` patchwork-bot+netdevbpf
2022-05-23 12:24 ` Karsten Graul
2022-05-24 2:59 ` Guangguan Wang
2022-05-24 12:04 ` Karsten Graul
2022-05-24 12:57 ` liuyacan
2022-05-24 13:05 ` Karsten Graul
2022-06-29 20:29 ` Wenjia Zhang
[not found] ` <8a15e288-4534-501c-8b3d-c235ae93238f@linux.ibm.com>
2022-06-30 14:29 ` Guangguan Wang
2022-06-30 20:16 ` Wenjia Zhang [this message]
2022-07-01 2:03 ` Guangguan Wang
2022-07-01 12:45 ` Wenjia Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcac3b0c-db51-7221-d41a-0207144f131c@linux.ibm.com \
--to=wenjia@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=guangguan.wang@linux.alibaba.com \
--cc=kgraul@linux.ibm.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=liuyacan@corp.netease.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).