LKML Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] doc: cgroup: add f2fs and xfs to supported list for writeback
@ 2020-06-29 19:08 Eric Sandeen
  2020-06-30  1:18 ` Chao Yu
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Eric Sandeen @ 2020-06-29 19:08 UTC (permalink / raw)
  To: linux-kernel, linux-mm, Jonathan Corbet
  Cc: cgroups, linux-f2fs-devel, linux-xfs

f2fs and xfs have both added support for cgroup writeback:

578c647 f2fs: implement cgroup writeback support
adfb5fb xfs: implement cgroup aware writeback

so add them to the supported list in the docs.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

TBH I wonder about the wisdom of having this detail in
the doc, as it apparently gets missed quite often ...

diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
index ce3e05e..4f82afa 100644
--- a/Documentation/admin-guide/cgroup-v2.rst
+++ b/Documentation/admin-guide/cgroup-v2.rst
@@ -1684,9 +1684,9 @@ per-cgroup dirty memory states are examined and the more restrictive
 of the two is enforced.
 
 cgroup writeback requires explicit support from the underlying
-filesystem.  Currently, cgroup writeback is implemented on ext2, ext4
-and btrfs.  On other filesystems, all writeback IOs are attributed to
-the root cgroup.
+filesystem.  Currently, cgroup writeback is implemented on ext2, ext4,
+btrfs, f2fs, and xfs.  On other filesystems, all writeback IOs are 
+attributed to the root cgroup.
 
 There are inherent differences in memory and writeback management
 which affects how cgroup ownership is tracked.  Memory is tracked per


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] doc: cgroup: add f2fs and xfs to supported list for writeback
  2020-06-29 19:08 [PATCH] doc: cgroup: add f2fs and xfs to supported list for writeback Eric Sandeen
@ 2020-06-30  1:18 ` Chao Yu
  2020-06-30  5:42 ` Christoph Hellwig
  2020-07-05 20:35 ` Jonathan Corbet
  2 siblings, 0 replies; 7+ messages in thread
From: Chao Yu @ 2020-06-30  1:18 UTC (permalink / raw)
  To: Eric Sandeen, linux-kernel, linux-mm, Jonathan Corbet
  Cc: cgroups, linux-f2fs-devel, linux-xfs

On 2020/6/30 3:08, Eric Sandeen wrote:
> f2fs and xfs have both added support for cgroup writeback:
> 
> 578c647 f2fs: implement cgroup writeback support
> adfb5fb xfs: implement cgroup aware writeback
> 
> so add them to the supported list in the docs.

Thanks for the fix.

> 
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>

Acked-by: Chao Yu <yuchao0@huawei.com>

Thanks,

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] doc: cgroup: add f2fs and xfs to supported list for writeback
  2020-06-29 19:08 [PATCH] doc: cgroup: add f2fs and xfs to supported list for writeback Eric Sandeen
  2020-06-30  1:18 ` Chao Yu
@ 2020-06-30  5:42 ` Christoph Hellwig
  2020-06-30 13:59   ` Eric Sandeen
  2020-07-05 20:35 ` Jonathan Corbet
  2 siblings, 1 reply; 7+ messages in thread
From: Christoph Hellwig @ 2020-06-30  5:42 UTC (permalink / raw)
  To: Eric Sandeen
  Cc: linux-kernel, linux-mm, Jonathan Corbet, cgroups,
	linux-f2fs-devel, linux-xfs

On Mon, Jun 29, 2020 at 02:08:09PM -0500, Eric Sandeen wrote:
> f2fs and xfs have both added support for cgroup writeback:
> 
> 578c647 f2fs: implement cgroup writeback support
> adfb5fb xfs: implement cgroup aware writeback
> 
> so add them to the supported list in the docs.
> 
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
> 
> TBH I wonder about the wisdom of having this detail in
> the doc, as it apparently gets missed quite often ...

I'd rather remove the list of file systems.  It has no chance of
staying uptodate.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] doc: cgroup: add f2fs and xfs to supported list for writeback
  2020-06-30  5:42 ` Christoph Hellwig
@ 2020-06-30 13:59   ` Eric Sandeen
  2020-07-01  8:32     ` Christoph Hellwig
  0 siblings, 1 reply; 7+ messages in thread
From: Eric Sandeen @ 2020-06-30 13:59 UTC (permalink / raw)
  To: Christoph Hellwig, Eric Sandeen
  Cc: linux-kernel, linux-mm, Jonathan Corbet, cgroups,
	linux-f2fs-devel, linux-xfs

On 6/30/20 12:42 AM, Christoph Hellwig wrote:
> On Mon, Jun 29, 2020 at 02:08:09PM -0500, Eric Sandeen wrote:
>> f2fs and xfs have both added support for cgroup writeback:
>>
>> 578c647 f2fs: implement cgroup writeback support
>> adfb5fb xfs: implement cgroup aware writeback
>>
>> so add them to the supported list in the docs.
>>
>> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
>> ---
>>
>> TBH I wonder about the wisdom of having this detail in
>> the doc, as it apparently gets missed quite often ...
> 
> I'd rather remove the list of file systems.  It has no chance of
> staying uptodate.

Is there any way for a user to know whether a filesytem does or doesn't
support it, in practice?

Thanks,
-Eric

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] doc: cgroup: add f2fs and xfs to supported list for writeback
  2020-06-30 13:59   ` Eric Sandeen
@ 2020-07-01  8:32     ` Christoph Hellwig
  2020-07-01 13:25       ` Eric Sandeen
  0 siblings, 1 reply; 7+ messages in thread
From: Christoph Hellwig @ 2020-07-01  8:32 UTC (permalink / raw)
  To: Eric Sandeen
  Cc: Christoph Hellwig, Eric Sandeen, linux-kernel, linux-mm,
	Jonathan Corbet, cgroups, linux-f2fs-devel, linux-xfs

On Tue, Jun 30, 2020 at 08:59:34AM -0500, Eric Sandeen wrote:
> On 6/30/20 12:42 AM, Christoph Hellwig wrote:
> > On Mon, Jun 29, 2020 at 02:08:09PM -0500, Eric Sandeen wrote:
> >> f2fs and xfs have both added support for cgroup writeback:
> >>
> >> 578c647 f2fs: implement cgroup writeback support
> >> adfb5fb xfs: implement cgroup aware writeback
> >>
> >> so add them to the supported list in the docs.
> >>
> >> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> >> ---
> >>
> >> TBH I wonder about the wisdom of having this detail in
> >> the doc, as it apparently gets missed quite often ...
> > 
> > I'd rather remove the list of file systems.  It has no chance of
> > staying uptodate.
> 
> Is there any way for a user to know whether a filesytem does or doesn't
> support it, in practice?

git-grep SB_I_CGROUPWB

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] doc: cgroup: add f2fs and xfs to supported list for writeback
  2020-07-01  8:32     ` Christoph Hellwig
@ 2020-07-01 13:25       ` Eric Sandeen
  0 siblings, 0 replies; 7+ messages in thread
From: Eric Sandeen @ 2020-07-01 13:25 UTC (permalink / raw)
  To: Christoph Hellwig
  Cc: Eric Sandeen, linux-kernel, linux-mm, Jonathan Corbet, cgroups,
	linux-f2fs-devel, linux-xfs

On 7/1/20 3:32 AM, Christoph Hellwig wrote:
> On Tue, Jun 30, 2020 at 08:59:34AM -0500, Eric Sandeen wrote:
>> On 6/30/20 12:42 AM, Christoph Hellwig wrote:
>>> On Mon, Jun 29, 2020 at 02:08:09PM -0500, Eric Sandeen wrote:
>>>> f2fs and xfs have both added support for cgroup writeback:
>>>>
>>>> 578c647 f2fs: implement cgroup writeback support
>>>> adfb5fb xfs: implement cgroup aware writeback
>>>>
>>>> so add them to the supported list in the docs.
>>>>
>>>> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
>>>> ---
>>>>
>>>> TBH I wonder about the wisdom of having this detail in
>>>> the doc, as it apparently gets missed quite often ...
>>>
>>> I'd rather remove the list of file systems.  It has no chance of
>>> staying uptodate.
>>
>> Is there any way for a user to know whether a filesytem does or doesn't
>> support it, in practice?
> 
> git-grep SB_I_CGROUPWB

Sure, but that's not quite what I meant by "a user" :)  So I'll take that
as a no.

Thanks,
-Eric

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] doc: cgroup: add f2fs and xfs to supported list for writeback
  2020-06-29 19:08 [PATCH] doc: cgroup: add f2fs and xfs to supported list for writeback Eric Sandeen
  2020-06-30  1:18 ` Chao Yu
  2020-06-30  5:42 ` Christoph Hellwig
@ 2020-07-05 20:35 ` Jonathan Corbet
  2 siblings, 0 replies; 7+ messages in thread
From: Jonathan Corbet @ 2020-07-05 20:35 UTC (permalink / raw)
  To: Eric Sandeen; +Cc: linux-kernel, linux-mm, cgroups, linux-f2fs-devel, linux-xfs

On Mon, 29 Jun 2020 14:08:09 -0500
Eric Sandeen <sandeen@redhat.com> wrote:

> f2fs and xfs have both added support for cgroup writeback:
> 
> 578c647 f2fs: implement cgroup writeback support
> adfb5fb xfs: implement cgroup aware writeback
> 
> so add them to the supported list in the docs.
> 
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
> 
> TBH I wonder about the wisdom of having this detail in
> the doc, as it apparently gets missed quite often ...

Good question, but as long as it's there it might as well be correct;
applied, thanks.

jon

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, back to index

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-29 19:08 [PATCH] doc: cgroup: add f2fs and xfs to supported list for writeback Eric Sandeen
2020-06-30  1:18 ` Chao Yu
2020-06-30  5:42 ` Christoph Hellwig
2020-06-30 13:59   ` Eric Sandeen
2020-07-01  8:32     ` Christoph Hellwig
2020-07-01 13:25       ` Eric Sandeen
2020-07-05 20:35 ` Jonathan Corbet

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git
	git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git