From: Bob Liu <bob.liu@oracle.com>
To: Martijn Coenen <maco@android.com>, axboe@kernel.dk, hch@lst.de
Cc: ming.lei@redhat.com, bvanassche@acm.org,
Chaitanya.Kulkarni@wdc.com, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-team@android.com
Subject: Re: [PATCH] loop: Call loop_config_discard() only after new config is applied.
Date: Fri, 17 Apr 2020 08:19:52 +0800 [thread overview]
Message-ID: <fcdeb6a5-5da0-6759-3568-f5fa517e1c5d@oracle.com> (raw)
In-Reply-To: <20200331114116.21642-1-maco@android.com>
On 3/31/20 7:41 PM, Martijn Coenen wrote:
> loop_set_status() calls loop_config_discard() to configure discard for
> the loop device; however, the discard configuration depends on whether
> the loop device uses encryption, and when we call it the encryption
> configuration has not been updated yet. Move the call down so we apply
> the correct discard configuration based on the new configuration.
>
> Signed-off-by: Martijn Coenen <maco@android.com>
Looks fine to me.
Reviewed-by: Bob Liu <bob.liu@oracle.com>
> ---
> drivers/block/loop.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/block/loop.c b/drivers/block/loop.c
> index 739b372a5112..7c9dcb6007a6 100644
> --- a/drivers/block/loop.c
> +++ b/drivers/block/loop.c
> @@ -1312,8 +1312,6 @@ loop_set_status(struct loop_device *lo, const struct loop_info64 *info)
> }
> }
>
> - loop_config_discard(lo);
> -
> memcpy(lo->lo_file_name, info->lo_file_name, LO_NAME_SIZE);
> memcpy(lo->lo_crypt_name, info->lo_crypt_name, LO_NAME_SIZE);
> lo->lo_file_name[LO_NAME_SIZE-1] = 0;
> @@ -1337,6 +1335,8 @@ loop_set_status(struct loop_device *lo, const struct loop_info64 *info)
> lo->lo_key_owner = uid;
> }
>
> + loop_config_discard(lo);
> +
> /* update dio if lo_offset or transfer is changed */
> __loop_update_dio(lo, lo->use_dio);
>
>
next prev parent reply other threads:[~2020-04-17 0:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-31 11:41 [PATCH] loop: Call loop_config_discard() only after new config is applied Martijn Coenen
2020-04-14 8:13 ` Martijn Coenen
2020-04-14 8:16 ` Christoph Hellwig
2020-04-17 0:19 ` Bob Liu [this message]
2020-04-18 15:46 ` Bart Van Assche
2020-05-04 19:32 ` Martijn Coenen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcdeb6a5-5da0-6759-3568-f5fa517e1c5d@oracle.com \
--to=bob.liu@oracle.com \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=hch@lst.de \
--cc=kernel-team@android.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).