From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751522AbeBVTIw (ORCPT ); Thu, 22 Feb 2018 14:08:52 -0500 Received: from mail-lf0-f53.google.com ([209.85.215.53]:43488 "EHLO mail-lf0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751412AbeBVTIu (ORCPT ); Thu, 22 Feb 2018 14:08:50 -0500 X-Google-Smtp-Source: AH8x2275VGdlS53BdCHR7oFrAlGadJhDMmLgEPzng9U9DPTvJz9/8LzM5tMqAJwiRjr9YXP4x4Uk8w== Subject: Re: [PATCH v2 19/19] ARM64: dts: r8a77965: Add EtherAVB device node To: Simon Horman Cc: jacopo mondi , Jacopo Mondi , geert@linux-m68k.org, magnus.damm@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <1519139541-18783-1-git-send-email-jacopo+renesas@jmondi.org> <1519139541-18783-20-git-send-email-jacopo+renesas@jmondi.org> <20180221100716.GF7203@w540> <20180221173106.vgyshbz3kkc4p3cu@verge.net.au> <321c6c8c-8853-ac00-7567-c0be82b510f4@cogentembedded.com> <35959135-cb3b-040a-1944-26845e0c07b0@cogentembedded.com> <20180221182340.wvdvgtv5pw7pvd3v@verge.net.au> <20180222155411.gnn42poawtlf3rze@verge.net.au> From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: Date: Thu, 22 Feb 2018 22:08:46 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20180222155411.gnn42poawtlf3rze@verge.net.au> Content-Type: text/plain; charset=utf-8 Content-Language: en-MW Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello! On 02/22/2018 06:54 PM, Simon Horman wrote: >>> ... >>> >>>>>>>>>> + clocks = <&cpg CPG_MOD 812>; >>>>>>>>>> + power-domains = <&sysc 32>; >>>>>>>>>> + resets = <&cpg 812>; >>>>>>>>>> + phy-mode = "rgmii-txid"; >>>>>>>>> >>>>>>>>> Why not just "rgmii"? TX delay is a board specific detail, no? >>>>>>>>> >>>>>>>> I admit I took this one straight from r8a7796 dtsi. >>>>>>>> Would you like to me resend and change this? >>>>>>> >>>>>>> Yes, unless Simon would fix it while merging... >>>>>> >>>>>> Can I confirm the desired change is s/rgmii-txid/rgmii/ ? >>>>> >>>>> Yes. >>>> >>>> Apparently that means that this prop should be overridden in the board file >>>> (which may not be an easy task given the board is Salvator-XS again). >>>> >>>> [...] >>> >>> Can we override it in r8a77965-salvator-x.dts or r8a77965-salvator-xs.dts? >> >> In salvator-common.dtsi most probably -- it has the PHY data for Ether AVB. >> >>> I feel that I'm missing an important point here. >> >> Well, r8a779{5|6}.dtsi also have phy-mode = "rgmii-txid" (which was >> unjustified in my current understanding). Thus such board override >> wouldn't hurt them. But we lack a patch modifying salvator-common.dtsi >> in htis series, so I'm now thinking a respin of this series is needed >> anyway... sorry for being unclear. :-) > > While I've applied other patches in this series I have > not applied this one - mainly to allow this discussion to conclude. > > Is an appropriate solution to do the following? > > 1) Atomically update > a) r8a779{5|6}.dtsi to use "rgmii" and > b) salvator-common.dtsi to use "rgmii-txid" > 2) Update this patch to use "rgmii" Yeah, I was thinking about doing exactly this... > Sorry if I'm still missing the point. I was referring to what the 2nd paragraph of [1] said about the internal delays (perhaps I just misunderstood it)... [1] https://en.wikipedia.org/wiki/Media-independent_interface#Reduced_gigabit_media-independent_interface MBR, Sergei