From: Joe Perches <joe@perches.com>
To: Nishad Kamdar <nishadkamdar@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: NeilBrown <neil@brown.name>,
devel@driverdev.osuosl.org,
"Christian Lütke-Stetzkamp" <christian@lkamp.de>,
linux-kernel@vger.kernel.org, "John Crispin" <blogic@openwrt.org>,
"Dan Carpenter" <dan.carpenter@oracle.com>
Subject: Re: [PATCH] staging: mt7621-mmc: Remove do {} while (0) loop for single statement macro
Date: Mon, 17 Sep 2018 09:20:39 -0700 [thread overview]
Message-ID: <fcec8bb6dd5bb0d9c18dc4d839dee9782ec8ac9d.camel@perches.com> (raw)
In-Reply-To: <20180915131748.GA19661@nishad>
On Sat, 2018-09-15 at 18:47 +0530, Nishad Kamdar wrote:
> This patch removes do {} while (0) loop for single statement macros.
> Issue found by checkpatch.
Some or all of this code is not used and should be deleted instead.
> Signed-off-by: Nishad Kamdar <nishadkamdar@gmail.com>
> ---
> drivers/staging/mt7621-mmc/sd.c | 28 +++++++---------------------
> 1 file changed, 7 insertions(+), 21 deletions(-)
>
> diff --git a/drivers/staging/mt7621-mmc/sd.c b/drivers/staging/mt7621-mmc/sd.c
> index 7474f9ed7b5b..ec12a3a5a926 100644
> --- a/drivers/staging/mt7621-mmc/sd.c
> +++ b/drivers/staging/mt7621-mmc/sd.c
> @@ -104,14 +104,10 @@ static int cd_active_low = 1;
> /* gate means clock power down */
> static int g_clk_gate = 0;
> #define msdc_gate_clock(id) \
> - do { \
> - g_clk_gate &= ~(1 << ((id) + PERI_MSDC0_PDN)); \
> - } while (0)
> + (g_clk_gate &= ~(1 << ((id) + PERI_MSDC0_PDN)))
> /* not like power down register. 1 means clock on. */
> #define msdc_ungate_clock(id) \
> - do { \
> - g_clk_gate |= 1 << ((id) + PERI_MSDC0_PDN); \
> - } while (0)
> + (g_clk_gate |= 1 << ((id) + PERI_MSDC0_PDN))
>
> // do we need sync object or not
> void msdc_clk_status(int *status)
> @@ -170,9 +166,7 @@ static void msdc_clr_fifo(struct msdc_host *host)
> } while (0)
>
> #define msdc_irq_restore(val) \
> - do { \
> - sdr_set_bits(host->base + MSDC_INTEN, val); \
> - } while (0)
> + (sdr_set_bits(host->base + MSDC_INTEN, val))
>
> /* clock source for host: global */
> #if defined(CONFIG_SOC_MT7620)
> @@ -186,26 +180,18 @@ static u32 hclks[] = {50000000}; /* +/- by chhung */
> // always keep the VMC on.
> //============================================
> #define msdc_vcore_on(host) \
> - do { \
> - (void)hwPowerOn(MT65XX_POWER_LDO_VMC, VOL_3300, "SD"); \
> - } while (0)
> + ((void)hwPowerOn(MT65XX_POWER_LDO_VMC, VOL_3300, "SD"))
> #define msdc_vcore_off(host) \
> - do { \
> - (void)hwPowerDown(MT65XX_POWER_LDO_VMC, "SD"); \
> - } while (0)
> + ((void)hwPowerDown(MT65XX_POWER_LDO_VMC, "SD"))
>
> //====================================
> // the vdd output for card: global
> // always keep the VMCH on.
> //====================================
> #define msdc_vdd_on(host) \
> - do { \
> - (void)hwPowerOn(MT65XX_POWER_LDO_VMCH, VOL_3300, "SD"); \
> - } while (0)
> + ((void)hwPowerOn(MT65XX_POWER_LDO_VMCH, VOL_3300, "SD"))
> #define msdc_vdd_off(host) \
> - do { \
> - (void)hwPowerDown(MT65XX_POWER_LDO_VMCH, "SD"); \
> - } while (0)
> + ((void)hwPowerDown(MT65XX_POWER_LDO_VMCH, "SD"))
>
> #define sdc_is_busy() (readl(host->base + SDC_STS) & SDC_STS_SDCBUSY)
> #define sdc_is_cmd_busy() (readl(host->base + SDC_STS) & SDC_STS_CMDBUSY)
next prev parent reply other threads:[~2018-09-17 16:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-15 13:17 [PATCH] staging: mt7621-mmc: Remove do {} while (0) loop for single statement macro Nishad Kamdar
2018-09-17 16:20 ` Joe Perches [this message]
2018-09-18 11:27 ` Greg Kroah-Hartman
2018-09-23 9:34 ` Nishad Kamdar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcec8bb6dd5bb0d9c18dc4d839dee9782ec8ac9d.camel@perches.com \
--to=joe@perches.com \
--cc=blogic@openwrt.org \
--cc=christian@lkamp.de \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil@brown.name \
--cc=nishadkamdar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).