[PATCH] staging: erofs: select LZ4_DECOMPRESS to fix build error

[PATCH] staging: erofs: select LZ4_DECOMPRESS to fix build error

[Randy Dunlap]

From: Randy Dunlap <rdunlap@infradead.org>

EROFS Data Compression support uses LZ4 decompression, so it
should select LZ4_DECOMPRESS to prevent this build error:

drivers/staging/erofs/unzip_vle_lz4.o: In function `z_erofs_unzip_lz4':
drivers/staging/erofs/unzip_vle_lz4.c:18: undefined reference to `LZ4_decompress_safe_partial'

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: kbuild test robot <lkp@intel.com>
Cc: Gao Xiang <gaoxiang25@huawei.com>
Cc: Chao Yu <yuchao0@huawei.com>
Cc: linux-erofs@lists.ozlabs.org
---
 drivers/staging/erofs/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- linux-next-20181109.orig/drivers/staging/erofs/Kconfig
+++ linux-next-20181109/drivers/staging/erofs/Kconfig
@@ -90,6 +90,7 @@ config EROFS_FS_IO_MAX_RETRIES
 config EROFS_FS_ZIP
 	bool "EROFS Data Compresssion Support"
 	depends on EROFS_FS
+	select LZ4_DECOMPRESS
 	help
 	  Currently we support VLE Compression only.
 	  Play at your own risk.

Re: [PATCH] staging: erofs: select LZ4_DECOMPRESS to fix build error

[Gao Xiang]

Hi Randy,

Thanks for taking time, I have sent a patch to Greg fixing this issue. :)
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/commit/?h=staging-testing&id=7962e63a2f4140631ad10d475d96193a3bc8ec2f

Thanks,
Gao Xiang

On 2018/11/10 1:58, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
> 
> EROFS Data Compression support uses LZ4 decompression, so it
> should select LZ4_DECOMPRESS to prevent this build error:
> 
> drivers/staging/erofs/unzip_vle_lz4.o: In function `z_erofs_unzip_lz4':
> drivers/staging/erofs/unzip_vle_lz4.c:18: undefined reference to `LZ4_decompress_safe_partial'
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kbuild test robot <lkp@intel.com>