* [PATCH] mailmap: add entry for Jaegeuk Kim
@ 2019-08-02 1:21 Chao Yu
2019-08-02 13:26 ` Jonathan Corbet
0 siblings, 1 reply; 6+ messages in thread
From: Chao Yu @ 2019-08-02 1:21 UTC (permalink / raw)
To: corbet; +Cc: linux-doc, linux-kernel, chao, jaegeuk, Chao Yu
Add entry to connect all Jaegeuk's email addresses.
Acked-by: Jaegeuk Kim <jaegeuk@kernel.org>
Signed-off-by: Chao Yu <yuchao0@huawei.com>
---
.mailmap | 3 +++
1 file changed, 3 insertions(+)
diff --git a/.mailmap b/.mailmap
index 477debe3d960..70d41c86e644 100644
--- a/.mailmap
+++ b/.mailmap
@@ -89,6 +89,9 @@ Henrik Kretzschmar <henne@nachtwindheim.de>
Henrik Rydberg <rydberg@bitmath.org>
Herbert Xu <herbert@gondor.apana.org.au>
Jacob Shin <Jacob.Shin@amd.com>
+Jaegeuk Kim <jaegeuk@kernel.org> <jaegeuk@google.com>
+Jaegeuk Kim <jaegeuk@kernel.org> <jaegeuk@motorola.com>
+Jaegeuk Kim <jaegeuk@kernel.org> <jaegeuk.kim@samsung.com>
James Bottomley <jejb@mulgrave.(none)>
James Bottomley <jejb@titanic.il.steeleye.com>
James E Wilson <wilson@specifix.com>
--
2.18.0.rc1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] mailmap: add entry for Jaegeuk Kim
2019-08-02 1:21 [PATCH] mailmap: add entry for Jaegeuk Kim Chao Yu
@ 2019-08-02 13:26 ` Jonathan Corbet
2019-08-02 14:23 ` Chao Yu
0 siblings, 1 reply; 6+ messages in thread
From: Jonathan Corbet @ 2019-08-02 13:26 UTC (permalink / raw)
To: Chao Yu; +Cc: linux-doc, linux-kernel, chao, jaegeuk
On Fri, 2 Aug 2019 09:21:35 +0800
Chao Yu <yuchao0@huawei.com> wrote:
> Add entry to connect all Jaegeuk's email addresses.
>
> Acked-by: Jaegeuk Kim <jaegeuk@kernel.org>
> Signed-off-by: Chao Yu <yuchao0@huawei.com>
> ---
> .mailmap | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/.mailmap b/.mailmap
> index 477debe3d960..70d41c86e644 100644
> --- a/.mailmap
> +++ b/.mailmap
> @@ -89,6 +89,9 @@ Henrik Kretzschmar <henne@nachtwindheim.de>
> Henrik Rydberg <rydberg@bitmath.org>
> Herbert Xu <herbert@gondor.apana.org.au>
> Jacob Shin <Jacob.Shin@amd.com>
> +Jaegeuk Kim <jaegeuk@kernel.org> <jaegeuk@google.com>
> +Jaegeuk Kim <jaegeuk@kernel.org> <jaegeuk@motorola.com>
> +Jaegeuk Kim <jaegeuk@kernel.org> <jaegeuk.kim@samsung.com>
So as I understand it, the mailmap file is there mostly to ensure that a
person's changesets are properly collected in 'git shortlog' and such. As
documented on the man page, it is used when a person's name is spelled
differently at different times.
That doesn't appear to be the case here, and shortlog output is correct
already. Given that, do we *really* need to maintain a collection of old
email addresses in the mailmap file? What is the benefit of that?
Thanks,
jon
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mailmap: add entry for Jaegeuk Kim
2019-08-02 13:26 ` Jonathan Corbet
@ 2019-08-02 14:23 ` Chao Yu
2019-08-08 14:37 ` Chao Yu
0 siblings, 1 reply; 6+ messages in thread
From: Chao Yu @ 2019-08-02 14:23 UTC (permalink / raw)
To: Jonathan Corbet, Chao Yu; +Cc: linux-doc, linux-kernel, jaegeuk
On 2019-8-2 21:26, Jonathan Corbet wrote:
> On Fri, 2 Aug 2019 09:21:35 +0800
> Chao Yu <yuchao0@huawei.com> wrote:
>
>> Add entry to connect all Jaegeuk's email addresses.
>>
>> Acked-by: Jaegeuk Kim <jaegeuk@kernel.org>
>> Signed-off-by: Chao Yu <yuchao0@huawei.com>
>> ---
>> .mailmap | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/.mailmap b/.mailmap
>> index 477debe3d960..70d41c86e644 100644
>> --- a/.mailmap
>> +++ b/.mailmap
>> @@ -89,6 +89,9 @@ Henrik Kretzschmar <henne@nachtwindheim.de>
>> Henrik Rydberg <rydberg@bitmath.org>
>> Herbert Xu <herbert@gondor.apana.org.au>
>> Jacob Shin <Jacob.Shin@amd.com>
>> +Jaegeuk Kim <jaegeuk@kernel.org> <jaegeuk@google.com>
>> +Jaegeuk Kim <jaegeuk@kernel.org> <jaegeuk@motorola.com>
>> +Jaegeuk Kim <jaegeuk@kernel.org> <jaegeuk.kim@samsung.com>
>
> So as I understand it, the mailmap file is there mostly to ensure that a
> person's changesets are properly collected in 'git shortlog' and such. As
> documented on the man page, it is used when a person's name is spelled
> differently at different times.
>
> That doesn't appear to be the case here, and shortlog output is correct
> already. Given that, do we *really* need to maintain a collection of old
> email addresses in the mailmap file? What is the benefit of that?
IMO, when we use git-blame to find out who is response for specified code, w/o
mailmap we may just found old obsolete email address in the related commit; even
we can search full name for his/her new email address, how can we make sure they
are the same person... so anyway, it can help to find last valid/canonical email
address of someone.
Thanks,
>
> Thanks,
>
> jon
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mailmap: add entry for Jaegeuk Kim
2019-08-02 14:23 ` Chao Yu
@ 2019-08-08 14:37 ` Chao Yu
2019-08-09 16:28 ` Jonathan Corbet
0 siblings, 1 reply; 6+ messages in thread
From: Chao Yu @ 2019-08-08 14:37 UTC (permalink / raw)
To: Jonathan Corbet, Chao Yu; +Cc: linux-doc, linux-kernel, jaegeuk
On 2019-8-2 22:23, Chao Yu wrote:
> On 2019-8-2 21:26, Jonathan Corbet wrote:
>> On Fri, 2 Aug 2019 09:21:35 +0800
>> Chao Yu <yuchao0@huawei.com> wrote:
>>
>>> Add entry to connect all Jaegeuk's email addresses.
>>>
>>> Acked-by: Jaegeuk Kim <jaegeuk@kernel.org>
>>> Signed-off-by: Chao Yu <yuchao0@huawei.com>
>>> ---
>>> .mailmap | 3 +++
>>> 1 file changed, 3 insertions(+)
>>>
>>> diff --git a/.mailmap b/.mailmap
>>> index 477debe3d960..70d41c86e644 100644
>>> --- a/.mailmap
>>> +++ b/.mailmap
>>> @@ -89,6 +89,9 @@ Henrik Kretzschmar <henne@nachtwindheim.de>
>>> Henrik Rydberg <rydberg@bitmath.org>
>>> Herbert Xu <herbert@gondor.apana.org.au>
>>> Jacob Shin <Jacob.Shin@amd.com>
>>> +Jaegeuk Kim <jaegeuk@kernel.org> <jaegeuk@google.com>
>>> +Jaegeuk Kim <jaegeuk@kernel.org> <jaegeuk@motorola.com>
>>> +Jaegeuk Kim <jaegeuk@kernel.org> <jaegeuk.kim@samsung.com>
>>
>> So as I understand it, the mailmap file is there mostly to ensure that a
>> person's changesets are properly collected in 'git shortlog' and such. As
>> documented on the man page, it is used when a person's name is spelled
>> differently at different times.
>>
>> That doesn't appear to be the case here, and shortlog output is correct
>> already. Given that, do we *really* need to maintain a collection of old
>> email addresses in the mailmap file? What is the benefit of that?
>
> IMO, when we use git-blame to find out who is response for specified code, w/o
> mailmap we may just found old obsolete email address in the related commit; even
> we can search full name for his/her new email address, how can we make sure they
> are the same person... so anyway, it can help to find last valid/canonical email
> address of someone.
Any thoughts?
Thanks,
>
> Thanks,
>
>>
>> Thanks,
>>
>> jon
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mailmap: add entry for Jaegeuk Kim
2019-08-08 14:37 ` Chao Yu
@ 2019-08-09 16:28 ` Jonathan Corbet
2019-08-12 1:49 ` Chao Yu
0 siblings, 1 reply; 6+ messages in thread
From: Jonathan Corbet @ 2019-08-09 16:28 UTC (permalink / raw)
To: Chao Yu; +Cc: Chao Yu, linux-doc, linux-kernel, jaegeuk
On Thu, 8 Aug 2019 22:37:41 +0800
Chao Yu <chao@kernel.org> wrote:
> > IMO, when we use git-blame to find out who is response for specified code, w/o
> > mailmap we may just found old obsolete email address in the related commit; even
> > we can search full name for his/her new email address, how can we make sure they
> > are the same person... so anyway, it can help to find last valid/canonical email
> > address of someone.
>
> Any thoughts?
I'm not fully convinced that we want to maintain a database of every
developer's email history. But I did merge this patch a few days ago.
Thanks,
jon
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mailmap: add entry for Jaegeuk Kim
2019-08-09 16:28 ` Jonathan Corbet
@ 2019-08-12 1:49 ` Chao Yu
0 siblings, 0 replies; 6+ messages in thread
From: Chao Yu @ 2019-08-12 1:49 UTC (permalink / raw)
To: Jonathan Corbet, Chao Yu; +Cc: linux-doc, linux-kernel, jaegeuk
On 2019/8/10 0:28, Jonathan Corbet wrote:
> On Thu, 8 Aug 2019 22:37:41 +0800
> Chao Yu <chao@kernel.org> wrote:
>
>>> IMO, when we use git-blame to find out who is response for specified code, w/o
>>> mailmap we may just found old obsolete email address in the related commit; even
>>> we can search full name for his/her new email address, how can we make sure they
>>> are the same person... so anyway, it can help to find last valid/canonical email
>>> address of someone.
>>
>> Any thoughts?
>
> I'm not fully convinced that we want to maintain a database of every
> developer's email history. But I did merge this patch a few days ago.
Thanks for the merging anyway. :)
>
> Thanks,
>
> jon
> .
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-08-12 1:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-02 1:21 [PATCH] mailmap: add entry for Jaegeuk Kim Chao Yu
2019-08-02 13:26 ` Jonathan Corbet
2019-08-02 14:23 ` Chao Yu
2019-08-08 14:37 ` Chao Yu
2019-08-09 16:28 ` Jonathan Corbet
2019-08-12 1:49 ` Chao Yu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).