From: Christophe LEROY <christophe.leroy@c-s.fr>
To: Laurent Dufour <ldufour@linux.vnet.ibm.com>,
Michal Hocko <mhocko@kernel.org>
Cc: Rich Felker <dalias@libc.org>,
linux-doc@vger.kernel.org,
Catalin Marinas <catalin.marinas@arm.com>,
Palmer Dabbelt <palmer@sifive.com>,
Will Deacon <will.deacon@arm.com>,
x86@kernel.org, linux-mm@kvack.org, paulus@samba.org,
sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-s390@vger.kernel.org,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Jonathan Corbet <corbet@lwn.net>,
linux-sh@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
linux-snps-arc@lists.infradead.org,
Heiko Carstens <heiko.carstens@de.ibm.com>,
David Rientjes <rientjes@google.com>,
Robin Murphy <robin.murphy@arm.com>,
Jerome Glisse <jglisse@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org,
Vineet Gupta <vgupta@synopsys.com>,
linux-kernel@vger.kernel.org, aneesh.kumar@linux.vnet.ibm.com,
Albert Ou <albert@sifive.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
akpm@linux-foundation.org, linuxppc-dev@lists.ozlabs.org,
"David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH v3 2/2] mm: remove odd HAVE_PTE_SPECIAL
Date: Wed, 11 Apr 2018 10:59:58 +0200 [thread overview]
Message-ID: <fd1be042-c957-feb3-05d5-11244a3626da@c-s.fr> (raw)
In-Reply-To: <5bd1bb46-8f71-e6db-7fb7-43d023a37f58@linux.vnet.ibm.com>
Le 11/04/2018 à 10:41, Laurent Dufour a écrit :
> On 11/04/2018 10:33, Michal Hocko wrote:
>> On Wed 11-04-18 10:03:36, Laurent Dufour wrote:
>>> @@ -881,7 +876,8 @@ struct page *_vm_normal_page(struct vm_area_struct *vma, unsigned long addr,
>>>
>>> if (is_zero_pfn(pfn))
>>> return NULL;
>>> -check_pfn:
>>> +
>>> +check_pfn: __maybe_unused
>>> if (unlikely(pfn > highest_memmap_pfn)) {
>>> print_bad_pte(vma, addr, pte, NULL);
>>> return NULL;
>>> @@ -891,7 +887,7 @@ struct page *_vm_normal_page(struct vm_area_struct *vma, unsigned long addr,
>>> * NOTE! We still have PageReserved() pages in the page tables.
>>> * eg. VDSO mappings can cause them to exist.
>>> */
>>> -out:
>>> +out: __maybe_unused
>>> return pfn_to_page(pfn);
>>
>> Why do we need this ugliness all of the sudden?
> Indeed the compiler doesn't complaint but in theory it should since these
> labels are not used depending on CONFIG_ARCH_HAS_PTE_SPECIAL.
Why should it complain ?
Regards
Christophe
>
next prev parent reply other threads:[~2018-04-11 9:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-11 8:03 [PATCH v3 0/2] move __HAVE_ARCH_PTE_SPECIAL in Kconfig Laurent Dufour
2018-04-11 8:03 ` [PATCH v3 1/2] mm: introduce ARCH_HAS_PTE_SPECIAL Laurent Dufour
2018-04-11 8:34 ` Michal Hocko
2018-04-11 8:03 ` [PATCH v3 2/2] mm: remove odd HAVE_PTE_SPECIAL Laurent Dufour
2018-04-11 8:33 ` Michal Hocko
2018-04-11 8:41 ` Laurent Dufour
2018-04-11 8:49 ` Michal Hocko
2018-04-11 8:59 ` Christophe LEROY [this message]
2018-04-11 8:58 ` Christophe LEROY
2018-04-11 9:03 ` Laurent Dufour
2018-04-11 9:09 ` Christophe LEROY
2018-04-11 10:32 ` Laurent Dufour
2018-04-11 11:09 ` Michal Hocko
2018-04-12 11:48 ` [PATCH v4] " Laurent Dufour
2018-04-12 20:46 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd1be042-c957-feb3-05d5-11244a3626da@c-s.fr \
--to=christophe.leroy@c-s.fr \
--cc=akpm@linux-foundation.org \
--cc=albert@sifive.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=dalias@libc.org \
--cc=davem@davemloft.net \
--cc=heiko.carstens@de.ibm.com \
--cc=jglisse@redhat.com \
--cc=ldufour@linux.vnet.ibm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mhocko@kernel.org \
--cc=mingo@redhat.com \
--cc=palmer@sifive.com \
--cc=paulus@samba.org \
--cc=rientjes@google.com \
--cc=robin.murphy@arm.com \
--cc=schwidefsky@de.ibm.com \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=vgupta@synopsys.com \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).