From: Dan Murphy <dmurphy@ti.com>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>,
<linux-kernel@vger.kernel.org>
Cc: Collabora Kernel ML <kernel@collabora.com>,
"David S. Miller" <davem@davemloft.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Marc Kleine-Budde <mkl@pengutronix.de>,
Thomas Gleixner <tglx@linutronix.de>,
Wolfgang Grandegger <wg@grandegger.com>,
<linux-can@vger.kernel.org>, <netdev@vger.kernel.org>
Subject: Re: [PATCH] can: tcan4x5x: Replace depends on REGMAP_SPI with depends on SPI
Date: Fri, 17 Apr 2020 07:00:52 -0500 [thread overview]
Message-ID: <fd411219-f528-683c-ab39-1786a99c392b@ti.com> (raw)
In-Reply-To: <20200413141013.506613-1-enric.balletbo@collabora.com>
Enric
On 4/13/20 9:10 AM, Enric Balletbo i Serra wrote:
> regmap is a library function that gets selected by drivers that need
> it. No driver modules should depend on it. Instead depends on SPI and
> select REGMAP_SPI. Depending on REGMAP_SPI makes this driver only build
> if another driver already selected REGMAP_SPI, as the symbol can't be
> selected through the menu kernel configuration.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
>
> drivers/net/can/m_can/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/can/m_can/Kconfig b/drivers/net/can/m_can/Kconfig
> index 1ff0b7fe81d6..c10932a7f1fe 100644
> --- a/drivers/net/can/m_can/Kconfig
> +++ b/drivers/net/can/m_can/Kconfig
> @@ -16,7 +16,8 @@ config CAN_M_CAN_PLATFORM
>
> config CAN_M_CAN_TCAN4X5X
> depends on CAN_M_CAN
> - depends on REGMAP_SPI
> + depends on SPI
> + select REGMAP_SPI
> tristate "TCAN4X5X M_CAN device"
> ---help---
> Say Y here if you want support for Texas Instruments TCAN4x5x
Reviewed-by: Dan Murphy <dmurphy@ti.com>
prev parent reply other threads:[~2020-04-17 12:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-13 14:10 [PATCH] can: tcan4x5x: Replace depends on REGMAP_SPI with depends on SPI Enric Balletbo i Serra
2020-04-17 12:00 ` Dan Murphy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd411219-f528-683c-ab39-1786a99c392b@ti.com \
--to=dmurphy@ti.com \
--cc=davem@davemloft.net \
--cc=enric.balletbo@collabora.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@collabora.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).