From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF9BCC433EF for ; Sun, 5 Jun 2022 15:12:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349557AbiFEPMz (ORCPT ); Sun, 5 Jun 2022 11:12:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349763AbiFEPMv (ORCPT ); Sun, 5 Jun 2022 11:12:51 -0400 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A33581570B for ; Sun, 5 Jun 2022 08:12:45 -0700 (PDT) Received: by mail-ed1-x536.google.com with SMTP id x62so15753366ede.10 for ; Sun, 05 Jun 2022 08:12:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=x+fdYMlfBqjJsfTMeBXwmbk6chP7/1R1+jVisQRo6VE=; b=Y1Dch9GREjMHFir6ioGvURLkQcuw1g/GFu4AvifmbQxrXTFtiEQQQwOnIa1DupKNs8 LFmAJFhsUYiH18tTruEBMCG2jUj/pYHTjOxm9t3f/o1LVjRzYdE4i8srROR12Bi/Rf34 Z+BDwI09IuDxRGyOcGLNNh8D8cGSNMue7TpiVtw0lTI9BAovmCEqhgeqwQutCJQoGrmy DKgX5V7hA/FsrlpDmH0LFzjtso0R02MT3VCy569uPDn6Gc7s9q32MwAtkE+iYMYBJj64 rOG9eB9wJ/ttxnw0dk2/p1LGwy0OA8MZVOSb/6AmJ70Vvx4qyf9raZcGkfG9mkVHdK3g lWrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=x+fdYMlfBqjJsfTMeBXwmbk6chP7/1R1+jVisQRo6VE=; b=X6IMFdHF++2o8WLjKQy3qOQwN6Ixh219+g28Bb2gQQFfLCUN9rL5LmWvvt3rZP6IXy d3DZ+81kVZgl0G8+jWIlCRp7Z37Tc/t4cHyxelsdYkQPJ0Dy7M4WkF75a/jkjV65tupp SjomwUH4LML0rIZhpn7UgLhHB73WDZ0OBTXutjQwkMxiAOj3SDMXWdh1zueVB/giTGBN jZHVUYJQOGHE6OgBqNfr4DgaKqK258widLJmEdLpxi7enHAGufyvufQkAmfdHSpRr6l2 lHJMfuTaXLGfBvDT0fm2gciXkqlaaMfeUsgkuP9u49AfxWbtVFNz/WB59/Ak5eJvlKMG MVkA== X-Gm-Message-State: AOAM533BHV4KcuraiqoqbAM0QxLRvLo52c0c80YAVvjCq3Jxe5/Pod9i WZaIiovbW0G7dDxiYEOCzT7wmRkjRtQ/ww== X-Google-Smtp-Source: ABdhPJwIRqpcVDFlSRzOMhcXpNy5cRM9nogH70w6WrtmyUcI5vpHYq4qgXyi/wc8+zavNqoYDH36ng== X-Received: by 2002:a05:6402:c08:b0:42d:d005:13c1 with SMTP id co8-20020a0564020c0800b0042dd00513c1mr21453363edb.187.1654441964278; Sun, 05 Jun 2022 08:12:44 -0700 (PDT) Received: from [192.168.0.181] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id r25-20020aa7cb99000000b0042a5a39ba7esm6892714edt.25.2022.06.05.08.12.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 05 Jun 2022 08:12:43 -0700 (PDT) Message-ID: Date: Sun, 5 Jun 2022 17:12:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [RFC PATCH 1/2] dt-bindings: input: gpio-keys: enforce node names to match all properties Content-Language: en-US To: Jeff LaBundy Cc: Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Hansson , Andreas Kemnade References: <20220603101601.542054-1-krzysztof.kozlowski@linaro.org> <20220603101601.542054-2-krzysztof.kozlowski@linaro.org> <20220604030455.GA12308@nixie71> From: Krzysztof Kozlowski In-Reply-To: <20220604030455.GA12308@nixie71> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/06/2022 05:04, Jeff LaBundy wrote: >> - dependencies: >> - wakeup-event-action: [ wakeup-source ] >> - linux,input-value: [ gpios ] >> - >> - unevaluatedProperties: false >> + "^(key|key-[a-z0-9-]+|[a-z0-9-]+-key)$": > > Maybe this would be better as: > > "^((key|switch|axis)|(key|switch|axis)-[a-z0-9-]+|[a-z0-9-]+-(key|switch|axis))$": > > ...or perhaps a more efficient version of my counter-proposal. > > The reason is because it is confusing to see a lid or dock switch named > as "key-lid", etc. Nice point. "switch" I understand, but can you really have "axis" on GPIO keys? I had impression axis is related to joysticks. Best regards, Krzysztof