From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: Mike Rapoport <rppt@kernel.org>, <linux-arm-kernel@lists.infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mike Rapoport <rppt@linux.ibm.com>,
Russell King <linux@armlinux.org.uk>,
<linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>
Subject: Re: [PATCH v2 0/3] memblock, arm: fixes for freeing of the memory map
Date: Thu, 20 May 2021 14:21:29 +0800 [thread overview]
Message-ID: <fd5846e4-4c75-6de9-6bc1-7e993f4685b4@huawei.com> (raw)
In-Reply-To: <20210519141436.11961-1-rppt@kernel.org>
On 2021/5/19 22:14, Mike Rapoport wrote:
> From: Mike Rapoport <rppt@linux.ibm.com>
>
> Hi,
>
> The coordination between freeing of unused memory map, pfn_valid() and core
> mm assumptions about validity of the memory map in various ranges was not
> designed for complex layouts of the physical memory with a lot of holes all
> over the place.
>
> Kefen Wang reported crashes in move_freepages() on a system with the
> following memory layout:
>
> node 0: [mem 0x0000000080a00000-0x00000000855fffff]
> node 0: [mem 0x0000000086a00000-0x0000000087dfffff]
> node 0: [mem 0x000000008bd00000-0x000000008c4fffff]
> node 0: [mem 0x000000008e300000-0x000000008ecfffff]
> node 0: [mem 0x0000000090d00000-0x00000000bfffffff]
> node 0: [mem 0x00000000cc000000-0x00000000dc9fffff]
> node 0: [mem 0x00000000de700000-0x00000000de9fffff]
> node 0: [mem 0x00000000e0800000-0x00000000e0bfffff]
> node 0: [mem 0x00000000f4b00000-0x00000000f6ffffff]
> node 0: [mem 0x00000000fda00000-0x00000000ffffefff]
>
> The crashes can be mitigated by enabling CONFIG_HOLES_IN_ZONE and
> essentially turning pfn_valid_within() to pfn_valid() instead of having it
> hardwired to 1.
>
> Alternatively, we can update ARM's implementation of pfn_valid() to take
> into accounting rounding of the freed memory map to pageblock boundaries
> and make sure it returns true for PFNs that have memory map entries even if
> there is no physical memory.
>
> I can take the entire series via memblock tree.
>
> @Kefen, I didn't add your Tested-by yet because the patch is slightly
> different from the version you've tested.
Backport this version(also with link[2]) and oom test could pass too.
>
> v2:
> * Use single memblock_overlaps_region() instead of several
> memblock_is_map_memory() lookups. This makes this series depend on update
> of MEMBLOCK_NOMAP handling in the memory map [2]
>
> v1: Link: https://lore.kernel.org/lkml/20210518090613.21519-1-rppt@kernel.org
>
> [1] https://lore.kernel.org/lkml/2a1592ad-bc9d-4664-fd19-f7448a37edc0@huawei.com
> [2] https://lore.kernel.org/lkml/20210511100550.28178-1-rppt@kernel.org
>
> Mike Rapoport (3):
> memblock: free_unused_memmap: use pageblock units instead of MAX_ORDER
> memblock: align freed memory map on pageblock boundaries with SPARSEMEM
> arm: extend pfn_valid to take into accound freed memory map alignment
>
> arch/arm/mm/init.c | 13 ++++++++++++-
> mm/memblock.c | 23 ++++++++++++-----------
> 2 files changed, 24 insertions(+), 12 deletions(-)
>
>
> base-commit: d07f6ca923ea0927a1024dfccafc5b53b61cfecc
>
prev parent reply other threads:[~2021-05-20 6:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 14:14 [PATCH v2 0/3] memblock, arm: fixes for freeing of the memory map Mike Rapoport
2021-05-19 14:14 ` [PATCH v2 1/3] memblock: free_unused_memmap: use pageblock units instead of MAX_ORDER Mike Rapoport
2021-05-19 14:14 ` [PATCH v2 2/3] memblock: align freed memory map on pageblock boundaries with SPARSEMEM Mike Rapoport
2021-05-19 14:14 ` [PATCH v2 3/3] arm: extend pfn_valid to take into accound freed memory map alignment Mike Rapoport
2021-06-28 10:20 ` Tony Lindgren
2021-06-28 13:16 ` Mike Rapoport
2021-06-28 15:26 ` Tony Lindgren
2021-06-29 5:33 ` Mike Rapoport
2021-06-29 8:54 ` Tony Lindgren
2021-06-29 10:50 ` Mike Rapoport
2021-06-29 11:52 ` Tony Lindgren
2021-06-29 12:50 ` Mike Rapoport
2021-06-29 12:53 ` Tony Lindgren
2021-06-30 7:20 ` Mike Rapoport
2021-05-20 6:21 ` Kefeng Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd5846e4-4c75-6de9-6bc1-7e993f4685b4@huawei.com \
--to=wangkefeng.wang@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@armlinux.org.uk \
--cc=rppt@kernel.org \
--cc=rppt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).