From: Paul Menzel <pmenzel@molgen.mpg.de>
To: Matthew Tan <matthew.tan_1@nxp.com>
Cc: jeffrey.t.kirsher@intel.com, michael.kardonik@nxp.com,
mitch.a.williams@intel.com, linux-kernel@vger.kernel.org,
john.ronciak@intel.com, intel-wired-lan@lists.osuosl.org,
netdev@vger.kernel.org
Subject: Re: [Intel-wired-lan] [PATCH] e1000e: changed some expensive calls of udelay to usleep_range
Date: Mon, 4 Sep 2017 18:36:02 +0200 [thread overview]
Message-ID: <fd5c453e-bd2e-3dc7-5f93-5af0ca216fd8@molgen.mpg.de> (raw)
In-Reply-To: <1503503985-3869-1-git-send-email-matthew.tan_1@nxp.com>
Dear Matthew,
On 08/23/17 17:59, Matthew Tan wrote:
> Calls to udelay are not preemtable by userspace so userspace
> applications experience a large (~200us) latency when running on core
> 0. Instead usleep_range can be used to be more friendly to userspace
> since it is preemtable. This is due to udelay using busy-wait loops
> while usleep_rang uses hrtimers instead. It is recommended to use
> udelay when the delay is <10us since at that precision overhead of
> usleep_range hrtimer setup causes issues. However, the replaced calls
> are for 50us and 100us so this should not be not an issue.
Is there a reason for indenting the paragraph. (I guess, you did `git
show` or `git log -p` and copied the message?) Anyway, please remove
whitespace in the front, if there is no reason.
Also, it looks like you ran benchmarks, so what is the delay for
userspace applications with your changes?
> Signed-off-by: Matthew Tan <matthew.tan_1@nxp.com>
> ---
> drivers/net/ethernet/intel/e1000e/phy.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
[…]
Kind regards,
Paul
prev parent reply other threads:[~2017-09-04 16:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-23 15:59 [PATCH] e1000e: changed some expensive calls of udelay to usleep_range Matthew Tan
2017-08-29 7:19 ` [Intel-wired-lan] " Neftin, Sasha
2017-09-04 16:25 ` Pavel Machek
2017-09-07 22:19 ` [Intel-wired-lan] " Brown, Aaron F
2017-09-08 9:28 ` Pavel Machek
2017-09-04 16:36 ` Paul Menzel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd5c453e-bd2e-3dc7-5f93-5af0ca216fd8@molgen.mpg.de \
--to=pmenzel@molgen.mpg.de \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=john.ronciak@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.tan_1@nxp.com \
--cc=michael.kardonik@nxp.com \
--cc=mitch.a.williams@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).