From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C906DC4338F for ; Mon, 16 Aug 2021 17:31:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AE6AE60F41 for ; Mon, 16 Aug 2021 17:31:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231621AbhHPRbh (ORCPT ); Mon, 16 Aug 2021 13:31:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231639AbhHPRbd (ORCPT ); Mon, 16 Aug 2021 13:31:33 -0400 Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3326C061764; Mon, 16 Aug 2021 10:31:01 -0700 (PDT) Received: by mail-pj1-x102e.google.com with SMTP id hv22-20020a17090ae416b0290178c579e424so1317837pjb.3; Mon, 16 Aug 2021 10:31:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=shshp+f6owMomFz5kbGuNE9NZBaJdb72qeBwnp8hDC8=; b=QuQmimHZL5HaYJPJt/0XPDGmg2DNnPVhLLRgr2PN+hKYo0GvonbMFi+e1YcI8q5uET aimErX4CBB9upkoa+Ec5y+01d2r5kV7FO7LDzCcMPJx3t35FYbCD7Bpka7WbzySYw1af DZjSR8SzTXizhSJ63ScmbM3vrtfBIYJvKDiDPN+0qZJuTxBHG9yw0xRmSoTfmPxAterm pTaIt66MXE7d/yWpDUt+lOstq2kVjP1jieQCTx/+EG3P/kuVnqh+h7RI5N+dlBWcO17H NzjBu4pD/hHj22OVO05KsfZtV0MaacdhgBXiZ/0XUGNZIjfu5fATTO5QDrc1sBP/r07F wKzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=shshp+f6owMomFz5kbGuNE9NZBaJdb72qeBwnp8hDC8=; b=KnnBzRv4o6DYdECjxVcOAppPkY1Otcvns/eFOfGmgCRu35dAHbk3r+0FKoi0GthM6a yJMmOuD9i5zMxEGQOzsO8ifVtHhUZ1j4T+Njkg5qbm7M7y3FhbNlIaxeyEa5hjxSismO R0gnMROZQkPujYZnstXDApng+lgg8nMvD6yCQmx/aX+HuAmp2d65j51dHukXN9bm1Ckz H7e2Vfh8lfgKcGKcO1hQ0EP0aSviNoPyRIr0kku02BOvm1OdcupJkVmiya+nAX5alCV5 rT+xYEoVMMTCrYrCWxGzQOGPEc+6Q1H8+B4341n/sWt1vVSKr3RUHIiq/IVjqrVTRIkY cVIg== X-Gm-Message-State: AOAM530hZTUKSCOhZxn2KJToNH1Q5inYb1sxf6COg4CDEGjS55Eo/xEf 2SPsIsyYTE9VgBzZ/PfvfjY= X-Google-Smtp-Source: ABdhPJx/6C39T3P7Jfq6u9J6EQ6/PrEkGbtC38QreRnVAQet23W80ZCypZHPbMh2blVo/qsLP5fyMA== X-Received: by 2002:a17:902:9046:b029:12c:b5b7:e443 with SMTP id w6-20020a1709029046b029012cb5b7e443mr14028634plz.31.1629135061498; Mon, 16 Aug 2021 10:31:01 -0700 (PDT) Received: from xps.yggdrasil ([49.207.137.16]) by smtp.gmail.com with ESMTPSA id z1sm17146pfg.18.2021.08.16.10.30.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Aug 2021 10:31:01 -0700 (PDT) From: Aakash Hemadri To: Greg Kroah-Hartman Cc: Shuah Khan , Bjorn Helgaas , linux-staging@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] staging: rtl8732bs: incorrect type in assignment Date: Mon, 16 Aug 2021 23:00:42 +0530 Message-Id: X-Mailer: git-send-email 2.32.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Cast u32 to __le32 with __cpu_to_le32 to fix sparse warning: warning: incorrect type in assignment (different base types) expected restricted __le32 [usertype] got unsigned int Signed-off-by: Aakash Hemadri --- drivers/staging/rtl8723bs/core/rtw_security.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_security.c b/drivers/staging/rtl8723bs/core/rtw_security.c index a99f439328f1..381deeea99d0 100644 --- a/drivers/staging/rtl8723bs/core/rtw_security.c +++ b/drivers/staging/rtl8723bs/core/rtw_security.c @@ -8,6 +8,7 @@ #include #include #include +#include static const char * const _security_type_str[] = { "N/A", @@ -69,7 +70,7 @@ void rtw_wep_encrypt(struct adapter *padapter, u8 *pxmitframe) length = pattrib->last_txcmdsz-pattrib->hdrlen-pattrib->iv_len-pattrib->icv_len; - *((__le32 *)crc) = ~crc32_le(~0, payload, length); + *((__le32 *)crc) = __cpu_to_le32(~crc32_le(~0, payload, length)); arc4_setkey(ctx, wepkey, 3 + keylength); arc4_crypt(ctx, payload, payload, length); @@ -77,7 +78,7 @@ void rtw_wep_encrypt(struct adapter *padapter, u8 *pxmitframe) } else { length = pxmitpriv->frag_len-pattrib->hdrlen-pattrib->iv_len-pattrib->icv_len; - *((__le32 *)crc) = ~crc32_le(~0, payload, length); + *((__le32 *)crc) = __cpu_to_le32(~crc32_le(~0, payload, length)); arc4_setkey(ctx, wepkey, 3 + keylength); arc4_crypt(ctx, payload, payload, length); arc4_crypt(ctx, payload + length, crc, 4); @@ -506,7 +507,8 @@ u32 rtw_tkip_encrypt(struct adapter *padapter, u8 *pxmitframe) if ((curfragnum+1) == pattrib->nr_frags) { /* 4 the last fragment */ length = pattrib->last_txcmdsz-pattrib->hdrlen-pattrib->iv_len-pattrib->icv_len; - *((__le32 *)crc) = ~crc32_le(~0, payload, length); + *((__le32 *)crc) = + __cpu_to_le32(~crc32_le(~0, payload, length)); arc4_setkey(ctx, rc4key, 16); arc4_crypt(ctx, payload, payload, length); @@ -514,7 +516,8 @@ u32 rtw_tkip_encrypt(struct adapter *padapter, u8 *pxmitframe) } else { length = pxmitpriv->frag_len-pattrib->hdrlen-pattrib->iv_len-pattrib->icv_len; - *((__le32 *)crc) = ~crc32_le(~0, payload, length); + *((__le32 *)crc) = + __cpu_to_le32(~crc32_le(~0, payload, length)); arc4_setkey(ctx, rc4key, 16); arc4_crypt(ctx, payload, payload, length); -- 2.32.0