From: David Lechner <david@lechnology.com>
To: Sekhar Nori <nsekhar@ti.com>
Cc: Kevin Hilman <khilman@kernel.org>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: da850-lego-ev3: slow down A/DC as much as possible
Date: Tue, 25 Sep 2018 10:23:40 -0500 [thread overview]
Message-ID: <fda2606b-3c7b-539a-ae07-4d9b57c34335@lechnology.com> (raw)
In-Reply-To: <a6e9c7ce-8fc8-0ee2-2d3a-24c33b67bdcc@ti.com>
On 9/25/18 1:04 AM, Sekhar Nori wrote:
> Hi David,
>
> On Monday 24 September 2018 07:01 AM, David Lechner wrote:
>> Due to the electrical design of the A/DC circuits on LEGO MINDSTORMS EV3,
>> if we are reading analog values as fast as possible (i.e. using DMA to
>> service the SPI) the A/DC chip will read incorrect values - as much as
>> 0.1V off when the SPI is running at 10MHz. (This has to do with the
>> capacitor charge time when channels are muxed in the A/DC.)
>
> So you believe this is an issue with the board design rather than the
> limitation of the ADC chip itself? Because if its the later, the fix
> should be in the driver instead.
It is the board design. There are external 4.7k series resistors that
make the RC charge time so long.
>
>>
>> Both of these patches mentioned have been picked up in the respective
>> subsystems.
>
> Is this needed for the -rc cycle or can wait for v4.20?
v4.20
prev parent reply other threads:[~2018-09-25 15:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-24 1:31 [PATCH] ARM: dts: da850-lego-ev3: slow down A/DC as much as possible David Lechner
2018-09-25 6:04 ` Sekhar Nori
2018-09-25 15:23 ` David Lechner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fda2606b-3c7b-539a-ae07-4d9b57c34335@lechnology.com \
--to=david@lechnology.com \
--cc=devicetree@vger.kernel.org \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).