Re: [PATCH v4 1/2] dt-bindings: mfd: Add bindings for MAX5970 and MAX5978

[Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>]

On 01/11/2022 12:53, Naresh Solanki wrote:
> From: Marcello Sylvester Bauer <sylv@sylv.io>
> 
> The MAX597x is a hot swap controller with configurable fault protection.
> It also has 10bit ADC for current & voltage measurements.
> 
> Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
> Signed-off-by: Marcello Sylvester Bauer <sylv@sylv.io>
> Signed-off-by: Naresh Solanki <Naresh.Solanki@9elements.com>
> ---
>  .../devicetree/bindings/mfd/max5970.yaml      | 164 ++++++++++++++++++
>  1 file changed, 164 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mfd/max5970.yaml
> 
> diff --git a/Documentation/devicetree/bindings/mfd/max5970.yaml b/Documentation/devicetree/bindings/mfd/max5970.yaml
> new file mode 100644
> index 000000000000..a0cc6a7543b5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/max5970.yaml

Filename: missing vendor prefix.

> @@ -0,0 +1,164 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/max5970.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Regulator driver for MAX5970 smart switch from Maxim Integrated.

Drop "driver"

> +
> +maintainers:
> +  - Patrick Rudolph <patrick.rudolph@9elements.com>
> +
> +description: |
> +  The smart switch provides no output regulation, but independent fault protection
> +  and voltage and current sensing.
> +  Programming is done through I2C bus.
> +
> +  Datasheets:
> +    https://datasheets.maximintegrated.com/en/ds/MAX5970.pdf
> +    https://datasheets.maximintegrated.com/en/ds/MAX5978.pdf
> +
> +properties:
> +  compatible:
> +    enum:
> +      - maxim,max5970
> +      - maxim,max5978
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  leds:
> +    type: object
> +    description:
> +      Properties for single channel.
> +
> +    patternProperties:
> +      "^led@[0-3]$":
> +        $ref: /schemas/leds/common.yaml#
> +        type: object
> +
> +    additionalProperties: true

This should be rather: false

> +
> +  vss1-supply:
> +    description: Supply of the first channel.
> +
> +  "#io-channel-cells":
> +    const: 1
> +
> +  regulators:
> +    type: object
> +    description:
> +      Properties for single channel.
> +
> +    patternProperties:
> +      "^(sw[0-1])$":
> +        $ref: /schemas/regulator/regulator.yaml#
> +        type: object
> +
> +      shunt-resistor-micro-ohms:
> +        description: |
> +          The value of curent sense resistor in microohms.
> +          Must be specified for each channel.
> +
> +    additionalProperties: true
> +
> +required:
> +  - compatible
> +  - reg
> +  - regulators
> +  - vss1-supply
> +
> +allOf:
> +  - $ref: /schemas/regulator/regulator.yaml#
> +  - if:
> +      properties:
> +        compatible:
> +          enum:
> +            - maxim,max5970
> +    then:
> +      properties:
> +        vss2-supply:
> +          description: Supply of the second channel.
> +
> +        io-channels:
> +          items:
> +            - description: voltage first channel
> +            - description: current first channel
> +            - description: voltage second channel
> +            - description: current second channel
> +          description: |
> +            Voltage and current for first and second channel.
> +      required:
> +        - vss2-supply
> +
> +    else:
> +      properties:
> +        io-channels:
> +          items:
> +            - description: voltage first channel
> +            - description: current first channel
> +          description: |
> +            Voltage and current for first channel.
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +            #address-cells = <1>;
> +            #size-cells = <0>;

Use 4 spaces for example indentation.

> +            leds {
> +                #address-cells = <1>;
> +                #size-cells = <0>;
> +                led@0 {
> +                        reg = <0>;
> +                        label = "led0";
> +                        default-state = "on";
> +                };
> +                led@1 {
> +                        reg = <1>;
> +                        label = "led1";
> +                        default-state = "on";
> +                };
> +            };

What is this example about? It does not match your bindings.

> +            regulator@3a {
> +                    reg = <0x3a>;
> +                    vss1-supply = <&p3v3>;
> +                    compatible = "maxim,max5978";
> +
> +                    regulators {
> +                            sw0_ref_0: SW0 {

Does not look like you tested the bindings. Please run `make
dt_binding_check` (see
Documentation/devicetree/bindings/writing-schema.rst for instructions).

> +                                   regulator-compatible = "SW0";
> +                                   shunt-resistor-micro-ohms = <12000>;
> +                            };
> +                    };
> +            };
> +    };
> +
> +  - |
> +    i2c {
> +            #address-cells = <1>;
> +            #size-cells = <0>;
> +
> +            regulator@3a {
> +                    reg = <0x3a>;
> +                    vss1-supply = <&p3v3>;
> +                    vss2-supply = <&p5v>;
> +                    compatible = "maxim,max5970";

Compatible is first, then reg, then the rest.
> +
> +                    regulators {
> +                            sw0_ref_1: SW0 {
> +                                   regulator-compatible = "SW0";
> +                                   shunt-resistor-micro-ohms = <12000>;
> +                            };
> +                            sw1_ref_1: SW1 {
> +                                   regulator-compatible = "SW1";
> +                                   shunt-resistor-micro-ohms = <10000>;
> +                            };
> +                    };
> +            };
> +    };
> +...

Best regards,
Krzysztof