From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C081AC433FE for ; Mon, 25 Oct 2021 15:07:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A70DC60D43 for ; Mon, 25 Oct 2021 15:07:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233776AbhJYPJW (ORCPT ); Mon, 25 Oct 2021 11:09:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233672AbhJYPJV (ORCPT ); Mon, 25 Oct 2021 11:09:21 -0400 Received: from mail-oi1-x234.google.com (mail-oi1-x234.google.com [IPv6:2607:f8b0:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01840C061745; Mon, 25 Oct 2021 08:06:59 -0700 (PDT) Received: by mail-oi1-x234.google.com with SMTP id s9so15973882oiw.6; Mon, 25 Oct 2021 08:06:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=oM8yA7a5dVE7JX8EcdvOiaf5ULOdCzfUf0V8tBfwui4=; b=ER0GMacpTnOTj7tzZfbyTloQJCQVh+rQsBqHcRfmmYdWOumvJXTe2HsV5ap6NC5GvJ aeMQktuglIYN7hDPxydn1Iq0XD8omM7TtYKFZTOB10t3OnlX5P+aPxMUthsIyTFSB4Cp GRX/YsZkRm3799hkSHKK7TsH338+CWVDoHp4rDR9/nDz6CYKygOMy5HPrXmrU8UlCfPZ ++1UzUoUGZ6tVgfI98SoCmh1srXoqE8q0xYkPx6z8ZweOgZuS5l4XQAoS5LqbfwALSpq +e6RhL7ppbzVGken8xBQ6Z6jmBIbUYNLgPqTIu57s/Pl/QtrX4eW34x2GMz+XSNwkC+F YqtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=oM8yA7a5dVE7JX8EcdvOiaf5ULOdCzfUf0V8tBfwui4=; b=qsACwUOcDAMfOeW0ym2FVoXOvh9D1bEAnDV2JbgHtcZNBZdB8IWqOyQE/VsdeJru8w BpiiPPX9PEElV/aNuf0u6gNFbjyi1NfxQf1j6SRR3rdpGO835uIVNVa5Wk0ngDNYp54x amnZ/V9hJgh4wyJ3ugptpNZvPkAVSJE77+2un/XHz5Mq2MJb+dOOp8sq4x9lYJO9P7m5 TltnIPnCHeIhA1lDiC4GErIl1e0eIuVHG9Ay0GvtMXhfefLop0pkPf7yFWWbHbAartgE vCjO5YsGcVS/tR+pzdBTwNBOWnBuKs0juWD8aBq2w4MIFNfLV35n5UM7Rj7LBEkGL11N txaw== X-Gm-Message-State: AOAM530rF54s3uw5ns+h+Lv149N1PfVhKSvUqXUSJqWGntPHdXxbz4pl 46EaNVGO5pixaAdH+/xWGIY= X-Google-Smtp-Source: ABdhPJx7eHOV/Rj1dfcQbb+E4YkvGmIM8cWShmj+USs3dQQxpyMHv1C8wOTSbiYJDcuOPvRBc8Cdzw== X-Received: by 2002:aca:ac82:: with SMTP id v124mr23639856oie.0.1635174418293; Mon, 25 Oct 2021 08:06:58 -0700 (PDT) Received: from ?IPV6:2603:8090:2005:39b3::101e? (2603-8090-2005-39b3-0000-0000-0000-101e.res6.spectrum.com. [2603:8090:2005:39b3::101e]) by smtp.gmail.com with ESMTPSA id bk8sm3803285oib.57.2021.10.25.08.06.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Oct 2021 08:06:57 -0700 (PDT) Sender: Larry Finger Message-ID: Date: Mon, 25 Oct 2021 10:06:56 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH 1/2] staging: rtl8192u: fix control-message timeouts Content-Language: en-US To: Johan Hovold , Greg Kroah-Hartman Cc: Florian Schilhabel , linux-staging@lists.linux.dev, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20211025120910.6339-1-johan@kernel.org> <20211025120910.6339-2-johan@kernel.org> From: Larry Finger In-Reply-To: <20211025120910.6339-2-johan@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/25/21 07:09, Johan Hovold wrote: > USB control-message timeouts are specified in milliseconds and should > specifically not vary with CONFIG_HZ. > > Fixes: 8fc8598e61f6 ("Staging: Added Realtek rtl8192u driver to staging") > Cc: stable@vger.kernel.org # 2.6.33 > Signed-off-by: Johan Hovold > --- > drivers/staging/rtl8192u/r8192U_core.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) I would have preferred that you not use the magic number "500", but the patch is OK. Acked-by: Larry Finger Larry > > diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c > index b6698656fc01..cf5cfee2936f 100644 > --- a/drivers/staging/rtl8192u/r8192U_core.c > +++ b/drivers/staging/rtl8192u/r8192U_core.c > @@ -229,7 +229,7 @@ int write_nic_byte_E(struct net_device *dev, int indx, u8 data) > > status = usb_control_msg(udev, usb_sndctrlpipe(udev, 0), > RTL8187_REQ_SET_REGS, RTL8187_REQT_WRITE, > - indx | 0xfe00, 0, usbdata, 1, HZ / 2); > + indx | 0xfe00, 0, usbdata, 1, 500); > kfree(usbdata); > > if (status < 0) { > @@ -251,7 +251,7 @@ int read_nic_byte_E(struct net_device *dev, int indx, u8 *data) > > status = usb_control_msg(udev, usb_rcvctrlpipe(udev, 0), > RTL8187_REQ_GET_REGS, RTL8187_REQT_READ, > - indx | 0xfe00, 0, usbdata, 1, HZ / 2); > + indx | 0xfe00, 0, usbdata, 1, 500); > *data = *usbdata; > kfree(usbdata); > > @@ -279,7 +279,7 @@ int write_nic_byte(struct net_device *dev, int indx, u8 data) > status = usb_control_msg(udev, usb_sndctrlpipe(udev, 0), > RTL8187_REQ_SET_REGS, RTL8187_REQT_WRITE, > (indx & 0xff) | 0xff00, (indx >> 8) & 0x0f, > - usbdata, 1, HZ / 2); > + usbdata, 1, 500); > kfree(usbdata); > > if (status < 0) { > @@ -305,7 +305,7 @@ int write_nic_word(struct net_device *dev, int indx, u16 data) > status = usb_control_msg(udev, usb_sndctrlpipe(udev, 0), > RTL8187_REQ_SET_REGS, RTL8187_REQT_WRITE, > (indx & 0xff) | 0xff00, (indx >> 8) & 0x0f, > - usbdata, 2, HZ / 2); > + usbdata, 2, 500); > kfree(usbdata); > > if (status < 0) { > @@ -331,7 +331,7 @@ int write_nic_dword(struct net_device *dev, int indx, u32 data) > status = usb_control_msg(udev, usb_sndctrlpipe(udev, 0), > RTL8187_REQ_SET_REGS, RTL8187_REQT_WRITE, > (indx & 0xff) | 0xff00, (indx >> 8) & 0x0f, > - usbdata, 4, HZ / 2); > + usbdata, 4, 500); > kfree(usbdata); > > if (status < 0) { > @@ -355,7 +355,7 @@ int read_nic_byte(struct net_device *dev, int indx, u8 *data) > status = usb_control_msg(udev, usb_rcvctrlpipe(udev, 0), > RTL8187_REQ_GET_REGS, RTL8187_REQT_READ, > (indx & 0xff) | 0xff00, (indx >> 8) & 0x0f, > - usbdata, 1, HZ / 2); > + usbdata, 1, 500); > *data = *usbdata; > kfree(usbdata); > > @@ -380,7 +380,7 @@ int read_nic_word(struct net_device *dev, int indx, u16 *data) > status = usb_control_msg(udev, usb_rcvctrlpipe(udev, 0), > RTL8187_REQ_GET_REGS, RTL8187_REQT_READ, > (indx & 0xff) | 0xff00, (indx >> 8) & 0x0f, > - usbdata, 2, HZ / 2); > + usbdata, 2, 500); > *data = *usbdata; > kfree(usbdata); > > @@ -404,7 +404,7 @@ static int read_nic_word_E(struct net_device *dev, int indx, u16 *data) > > status = usb_control_msg(udev, usb_rcvctrlpipe(udev, 0), > RTL8187_REQ_GET_REGS, RTL8187_REQT_READ, > - indx | 0xfe00, 0, usbdata, 2, HZ / 2); > + indx | 0xfe00, 0, usbdata, 2, 500); > *data = *usbdata; > kfree(usbdata); > > @@ -430,7 +430,7 @@ int read_nic_dword(struct net_device *dev, int indx, u32 *data) > status = usb_control_msg(udev, usb_rcvctrlpipe(udev, 0), > RTL8187_REQ_GET_REGS, RTL8187_REQT_READ, > (indx & 0xff) | 0xff00, (indx >> 8) & 0x0f, > - usbdata, 4, HZ / 2); > + usbdata, 4, 500); > *data = *usbdata; > kfree(usbdata); > >