From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751754AbdHCIl5 (ORCPT <rfc822;w@1wt.eu>);
        Thu, 3 Aug 2017 04:41:57 -0400
Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:36488 "EHLO
        foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751162AbdHCIlx (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 3 Aug 2017 04:41:53 -0400
Subject: Re: Suspend-resume failure on Intel Eagle Lake Core2Duo
To: Masahiro Yamada <yamada.masahiro@socionext.com>,
        Thomas Gleixner <tglx@linutronix.de>
References: <4d6b511a-61d5-3c5e-a406-9f71d83670b6@linux.intel.com>
 <alpine.DEB.2.20.1707272138080.2368@nanos>
 <alpine.DEB.2.20.1707272209130.2368@nanos>
 <alpine.DEB.2.20.1707272306310.2368@nanos>
 <7287f845-1012-51af-e696-99d26bcb9b7f@intel.com>
 <alpine.DEB.2.20.1707281439120.1986@nanos>
 <alpine.DEB.2.20.1707281514000.1986@nanos>
 <f7f52efa-f45c-7e9e-e407-a72c13a55089@intel.com>
 <alpine.DEB.2.20.1707281609250.1986@nanos>
 <d7c5c87e-7ff4-6599-4f93-5ea4a9ae17b4@intel.com>
 <alpine.DEB.2.20.1707281649210.1828@nanos>
 <1d2c51f3-a655-2223-68a9-e6d700e7d8e1@intel.com>
 <alpine.DEB.2.20.1707281734240.1828@nanos>
 <e0b96b01-a033-4e28-08c8-fc04f8edd2fc@intel.com>
 <alpine.DEB.2.20.1707310935370.2314@nanos>
 <412a3ab0-4ae5-b27a-0b2d-d2e03b27a999@intel.com>
 <alpine.DEB.2.20.1707311701480.2314@nanos>
 <b9280675-fe26-da23-2c6b-fce7dcc3e762@intel.com>
 <alpine.DEB.2.20.1707311754200.2314@nanos>
 <CAK7LNAQZB+VqWSxjfmjnzDJx3q1i-Da1SAaqbC4099qK7OwAfg@mail.gmail.com>
Cc: Tomi Sarvela <tomi.p.sarvela@intel.com>,
        Martin Peres <martin.peres@linux.intel.com>,
        Jeffy Chen <jeffy.chen@rock-chips.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
From: Marc Zyngier <marc.zyngier@arm.com>
Organization: ARM Ltd
Message-ID: <fdf71b0f-dd38-60e5-d96e-caedc2754a0b@arm.com>
Date: Thu, 3 Aug 2017 09:41:49 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <CAK7LNAQZB+VqWSxjfmjnzDJx3q1i-Da1SAaqbC4099qK7OwAfg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Masahiro,

On 03/08/17 08:32, Masahiro Yamada wrote:
> Hi.
> 
> 2017-08-01 0:55 GMT+09:00 Thomas Gleixner <tglx@linutronix.de>:
>> On Mon, 31 Jul 2017, Tomi Sarvela wrote:
>>> On 31/07/17 18:06, Thomas Gleixner wrote:
>>>> Can you please remove the patch. And try the following:
>>>>
>>>> # echo N > /sys/module/printk/parameters/console_suspend
>>>>
>>>> # echo mem > /sys/power/state
>>>>
>>>> and log the output of the serial console. That way we might get a clue
>>>> where it gets stuck.
>>>
>>> I'm afraid it hangs right away. No response from SSH, no output to serial.
>>
>> What means hangs right away? Is there no output at all on the serial
>> console? Or does it just stop at some point?
>>
>> Thanks,
>>
>>         tglx
>>
> 
> Sorry for jumping in.
> Finally, I found this thread.
> 
> 
> My environment is completely different (ARM64 board),
> I am also suffering from a hibernation problem
> since this commit.
> 
> 
> I get no response on the serial console
> after "Restarting tasks ... done." log message.
> 
> 
> By reverting bf22ff45bed6 ("genirq: Avoid unnecessary low level
> irq function calls", I can get hibernation working again.
> 
> 
> SW info:
> defconfig:  arch/arm64/configs/defconfig
> DT       :  arch/arm64/boot/dts/socionext/uniphier-ld20-ref.dts
> PSCI     :  ARM Trusted Firmware
> 
> 
> SoC info:
> CPU      :  Cortex-A72 * 2 + Cortex-A53 * 2
> irqchip  :  GICv3 (drivers/irq/irq-gic-v3.c)

Let me take an educated guess: It feels like your firmware doesn't
save/restore the GIC context across suspend/resume. Is that something
you could check, assuming you have access to the firmware source code?

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...