From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F6E0C3A589 for ; Tue, 20 Aug 2019 05:10:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 40DE42087E for ; Tue, 20 Aug 2019 05:10:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=c-s.fr header.i=@c-s.fr header.b="iK5h35DW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729273AbfHTFKG (ORCPT ); Tue, 20 Aug 2019 01:10:06 -0400 Received: from pegase1.c-s.fr ([93.17.236.30]:51749 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729060AbfHTFKF (ORCPT ); Tue, 20 Aug 2019 01:10:05 -0400 Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 46CJky58BGz9tyvg; Tue, 20 Aug 2019 07:10:02 +0200 (CEST) Authentication-Results: localhost; dkim=pass reason="1024-bit key; insecure key" header.d=c-s.fr header.i=@c-s.fr header.b=iK5h35DW; dkim-adsp=pass; dkim-atps=neutral X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id oP4J9rGVqrDA; Tue, 20 Aug 2019 07:10:02 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 46CJky3k81z9tyvd; Tue, 20 Aug 2019 07:10:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=c-s.fr; s=mail; t=1566277802; bh=/UI9QJC3ZH9u+c1qny2Oir9/BEulbaJcTlOTBJsWOEE=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=iK5h35DWBOvWbtHP97XrIp76nbRp3qzumgVgE4pAfbzMUiZBEtGiKvSfXD+WUmsAG 8rhOEt0AVk0fchtyAediLNzIWJfpf16ApPGhgnS9tTV7W71VUNjtaZ0B6SJ1Q8IsXI 7ghzLiEH4bryT2ravrGh7HehNGYGOWOft9kfwn1k= Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 281E38B782; Tue, 20 Aug 2019 07:10:04 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id nK8vtjC-v5h3; Tue, 20 Aug 2019 07:10:04 +0200 (CEST) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id B85C98B756; Tue, 20 Aug 2019 07:10:03 +0200 (CEST) Subject: Re: [PATCH v1 05/10] powerpc/mm: Do early ioremaps from top to bottom on PPC64 too. To: Michael Ellerman , Nicholas Piggin , Benjamin Herrenschmidt , Paul Mackerras Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org References: <6bc35eca507359075528bc0e55938bc1ce8ee485.1565726867.git.christophe.leroy@c-s.fr> <019c5d90f7027ccff00e38a3bcd633d290f6af59.1565726867.git.christophe.leroy@c-s.fr> <1566221500.6f5zxv68dm.astroid@bobo.none> <87r25g662n.fsf@concordia.ellerman.id.au> From: Christophe Leroy Message-ID: Date: Tue, 20 Aug 2019 07:10:03 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <87r25g662n.fsf@concordia.ellerman.id.au> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 20/08/2019 à 02:20, Michael Ellerman a écrit : > Nicholas Piggin writes: >> Christophe Leroy's on August 14, 2019 6:11 am: >>> Until vmalloc system is up and running, ioremap basically >>> allocates addresses at the border of the IOREMAP area. >>> >>> On PPC32, addresses are allocated down from the top of the area >>> while on PPC64, addresses are allocated up from the base of the >>> area. >> >> This series looks pretty good to me, but I'm not sure about this patch. >> >> It seems like quite a small divergence in terms of code, and it looks >> like the final result still has some ifdefs in these functions. Maybe >> you could just keep existing behaviour for this cleanup series so it >> does not risk triggering some obscure regression? > > Yeah that is also my feeling. Changing it *should* work, and I haven't > found anything that breaks yet, but it's one of those things that's > bound to break something for some obscure reason. > > Christophe do you think you can rework it to retain the different > allocation directions at least for now? > Yes I have started addressing the comments I received, and I think for now I'll keep all the machinery aside from the merge. Not sure yet if I'll leave it in pgtables_32/64.c or if I'll add ioremap_32/64.c Christophe