From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7C51C433F4 for ; Wed, 19 Sep 2018 15:28:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9428A2098A for ; Wed, 19 Sep 2018 15:28:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZYv4a8lw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9428A2098A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732532AbeISVGp (ORCPT ); Wed, 19 Sep 2018 17:06:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:45560 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731661AbeISVGp (ORCPT ); Wed, 19 Sep 2018 17:06:45 -0400 Received: from [192.168.0.101] (unknown [117.62.222.247]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 726B020877; Wed, 19 Sep 2018 15:28:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1537370898; bh=EVlh8mqq2ZKTiAHpYqlHN3bFjbKGfZsgmIxEoTwWmks=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=ZYv4a8lwljQ+nd6wcCLh51M7bYb6jl8Duot9EDirBMvTSyKhuzFIIWprLSsATX6ZM yNy91hTPJkJpprZmebNTOWWldkA29B237Cwx/UVPXdxg/jotOFdfJRA6ne277e8RHp QuQOiBWI9eTvLEc+KwyTZmMiTJUK5jAoXQLry73g= Subject: Re: [PATCH 6/6] staging: erofs: simplify return value of `xattr_foreach' To: Gao Xiang , Greg Kroah-Hartman , Chao Yu , devel@driverdev.osuosl.org Cc: Miao Xie , linux-erofs@lists.ozlabs.org, LKML , Du Wei References: <1537336150-90604-1-git-send-email-gaoxiang25@huawei.com> <1537336150-90604-6-git-send-email-gaoxiang25@huawei.com> From: Chao Yu Message-ID: Date: Wed, 19 Sep 2018 23:28:04 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1537336150-90604-6-git-send-email-gaoxiang25@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018/9/19 13:49, Gao Xiang wrote: > As Dan Carpenter pointed out, there is no need to propagate positive > return values back to its callers. > > Suggested-by: Dan Carpenter > Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Thanks,