From: Jyri Sarha <jsarha@ti.com>
To: David Lechner <david@lechnology.com>, <dri-devel@lists.freedesktop.org>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Sekhar Nori <nsekhar@ti.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/tilcdc: Fix setting clock divider for omap-l138
Date: Mon, 19 Mar 2018 11:05:06 +0200 [thread overview]
Message-ID: <fe2866d2-6dd4-f6e4-ea0e-72d8a9334075@ti.com> (raw)
In-Reply-To: <1521068325-15077-1-git-send-email-david@lechnology.com>
Thanks,
I'll pick this for v4.18.
Best regards,
Jyri
On 15/03/18 00:58, David Lechner wrote:
> This fixes setting the clock divider on the TI OMAP-L138 LCDK board.
>
> The clock drivers for OMAP-L138 are being covernted to the common clock
> framework. When this happens, clk_set_rate() will no longer return an
> error. However, on this SoC, the clock rate cannot actually be changed
> because the clock has to maintain a fixed ratio to the ARM clock. So
> after attempting to set the clock rate, we need to check to see if the
> new rate is actually close enough. If not, then follow the previous
> error path to adjust the divider in LCDC IP block to compensate for not
> being able to change the parent clock rate.
>
> Tested working on a TI OMAP-L138 LCDK board.
>
> Signed-off-by: David Lechner <david@lechnology.com>
> ---
> drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
> index 8bf6bb9..6931777 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
> @@ -224,7 +224,7 @@ static void tilcdc_crtc_set_clk(struct drm_crtc *crtc)
>
> ret = clk_set_rate(priv->clk, req_rate * clkdiv);
> clk_rate = clk_get_rate(priv->clk);
> - if (ret < 0) {
> + if (ret < 0 || tilcdc_pclk_diff(req_rate, clk_rate) > 5) {
> /*
> * If we fail to set the clock rate (some architectures don't
> * use the common clock framework yet and may not implement
>
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next prev parent reply other threads:[~2018-03-19 9:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-14 22:58 [PATCH] drm/tilcdc: Fix setting clock divider for omap-l138 David Lechner
2018-03-19 9:05 ` Jyri Sarha [this message]
2018-05-09 16:22 ` David Lechner
2018-05-09 17:42 ` Jyri Sarha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe2866d2-6dd4-f6e4-ea0e-72d8a9334075@ti.com \
--to=jsarha@ti.com \
--cc=bgolaszewski@baylibre.com \
--cc=david@lechnology.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).