From: Hans Verkuil <hverkuil@xs4all.nl>
To: Jacob Chen <jacob-chen@iotwrt.com>, linux-rockchip@lists.infradead.org
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, heiko@sntech.de,
mchehab@kernel.org, linux-media@vger.kernel.org,
laurent.pinchart+renesas@ideasonboard.com,
hans.verkuil@cisco.com, tfiga@chromium.org, nicolas@ndufresne.ca
Subject: Re: [PATCH v7] rockchip/rga: v4l2 m2m support
Date: Mon, 21 Aug 2017 16:16:39 +0200 [thread overview]
Message-ID: <fe2c1de6-dd6c-378f-8a1e-d790807310b1@xs4all.nl> (raw)
In-Reply-To: <1501737812-24171-1-git-send-email-jacob-chen@iotwrt.com>
Hi Jacob,
On 08/03/2017 07:23 AM, Jacob Chen wrote:
> Rockchip RGA is a separate 2D raster graphic acceleration unit. It
> accelerates 2D graphics operations, such as point/line drawing, image
> scaling, rotation, BitBLT, alpha blending and image blur/sharpness
>
> The drvier is mostly based on s5p-g2d v4l2 m2m driver
> And supports various operations from the rendering pipeline.
> - copy
> - fast solid color fill
> - rotation
> - flip
> - alpha blending
>
> The code in rga-hw.c is used to configure regs according to operations
> The code in rga-buf.c is used to create private mmu table for RGA.
>
> changes in V7:
> - fix some warning reported by "checkpatch --strict"
>
> Signed-off-by: Jacob Chen <jacob-chen@iotwrt.com>
Can you post the v4l2-compliance output? I gather that there is at least one
colorspace-related error that appears to be a v4l2-compliance bug, so I'd
like to see the exact error it gives. I'll see if I can fix it so this driver
has a clean compliance output.
I apologize that this driver probably won't make 4.14. Too much to review...
I hope to do the v7 review within a week.
Regards,
Hans
next prev parent reply other threads:[~2017-08-21 14:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-03 5:23 [PATCH v7] rockchip/rga: v4l2 m2m support Jacob Chen
2017-08-13 0:44 ` kbuild test robot
2017-08-13 1:04 ` kbuild test robot
2017-08-21 14:16 ` Hans Verkuil [this message]
2017-08-25 14:57 ` Jacob Chen
2017-08-25 12:09 ` Hans Verkuil
2017-09-11 10:53 ` Jacob Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe2c1de6-dd6c-378f-8a1e-d790807310b1@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=hans.verkuil@cisco.com \
--cc=heiko@sntech.de \
--cc=jacob-chen@iotwrt.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=nicolas@ndufresne.ca \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).